Bump DiscordRPC plugin to v5 (#583)

Bump DiscordRPC plugin to v5 which corresponds to the first version that supports plugins v3

.github/workflows/build.yml

@@ -28,13 +28,13 @@ jobs:
       - name: Wait for launcher release build to be ready
         timeout-minutes: 30 # Only wait for 30 minutes. If we take longer, something probably broke
         run:
-          bash northstar/wait_for_launcher_dl.sh
+          bash northstar/wait_for_launcher_dl.sh $NORTHSTAR_VERSION
       - name: Download compiled launcher
         run:
           wget "https://github.com/R2Northstar/NorthstarLauncher/releases/download/${{ env.NORTHSTAR_VERSION }}/northstar-launcher.zip"
       - name: Download DiscordRPC plugin
         run:
-          wget "https://github.com/R2Northstar/NorthstarDiscordRPC/releases/download/v4/northstar-discord-rpc.zip"
+          wget "https://github.com/R2Northstar/NorthstarDiscordRPC/releases/download/v5/northstar-discord-rpc.zip"
       - name: Download compiled stubs
         run:
           wget "https://github.com/R2Northstar/NorthstarStubs/releases/download/v1/NorthstarStubs.zip"
@@ -82,7 +82,7 @@ jobs:
       - name: Cleanup root Northstar repository files
         working-directory: northstar
         run: |
-          rm -rf .git .github .gitignore *.md LICENSE thunderstore .ci.env.example
+          rm -rf .git .github .gitignore *.md LICENSE thunderstore .ci.env.example *.sh
       - name: Upload
         uses: actions/upload-artifact@v3
         with:

wait_for_launcher_dl.sh

@@ -6,14 +6,14 @@ if [ -z "$1" ]; then
     exit 1
 fi
 
-url="https://github.com/R2Northstar/NorthstarLauncher/releases/tag/$1"
+url="https://github.com/R2Northstar/NorthstarLauncher/releases/download/$1/northstar-launcher.zip"
 wait_time_seconds=60
 
 # Loop until the response code changes
 while true; do
     response=$(curl --silent --output /dev/null --write-out "%{http_code}" $url)
-    if [ $response -ne 200 ]; then
-        echo "Response is not 200. Retrying in $wait_time_seconds seconds."
+    if [ $response -eq 404 ]; then
+        echo "Response is 404. Retrying in $wait_time_seconds seconds."
         sleep $wait_time_seconds
     else
         echo "Site is accessible with response code $response."