1
mirror of https://code.videolan.org/videolan/vlc synced 2024-10-07 03:56:28 +02:00
Commit Graph

81345 Commits

Author SHA1 Message Date
Thomas Guillem
ae0f98f72f rc: fix item leak
There is no need to hold the item since the player is locked while it is
accessed.

Fixes #22328

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2019-05-28 20:26:30 +03:00
Thomas Guillem
60220ade56 rc: lock the player only once while processing commands
And avoid racy states due to successive lock/unlock

Refs #22328

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Conflicts:
	modules/control/rc.c
2019-05-28 20:25:59 +03:00
Rémi Denis-Courmont
e22b496b5f rc: fix potential use-after-free 2019-05-28 20:23:30 +03:00
Rémi Denis-Courmont
13c2620955 lua: remove RC interface aliases 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
b5543e33a8 rc: add cli and oldrc aliases 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
1f128ba388 rc: rename back to rc from oldrc 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
60eb593c18 rc: fix potential use-after-free 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
a862cfbdab rc: move outstanding void commands to table 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
daf758a1e4 rc: remove unused arguments to void command handlers 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
8ecf33f5db rc: split out snapshot command
(and avoid nonsensical string comparison on void variable)
2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
a29f55d397 rc: use separate callback for void player commands 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
5c5007d957 rc: use separate callback for void playlist commands 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
7721510638 rc: pass intf_thread_t rather than vlc_object_t pointer 2019-05-28 19:56:21 +03:00
Rémi Denis-Courmont
23a7951266 rc: don't name macro and function the same 2019-05-28 19:56:18 +03:00
Rémi Denis-Courmont
0c99962f65 rc: don't block input/playlist commands when paused
Lua RC does allow them.
2019-05-28 19:56:08 +03:00
Rémi Denis-Courmont
d3af793572 rc: use a table for commands with parameters 2019-05-28 19:56:08 +03:00
Rémi Denis-Courmont
1133a865e0 rc: use a table for parameter-less commands 2019-05-28 19:56:08 +03:00
Rémi Denis-Courmont
5458013bf8 rc: move command processing to separate function 2019-05-28 19:56:08 +03:00
Rémi Denis-Courmont
2aee653993 rc: add missing static qualifier 2019-05-28 19:56:08 +03:00
Rémi Denis-Courmont
16011d3745 rc: reorder to avoid forward declarations 2019-05-28 19:56:08 +03:00
Rémi Denis-Courmont
32bc2c18cf misc: remove unused vlc_error_string() 2019-05-28 19:56:08 +03:00
Thomas Guillem
4d75329c8f Revert "Remove libvlc_free"
As decided by the VLC TC.
 - 4 in favor: David, Denis, Hugo, Thomas
 - 1 against: Rémi

cf. discussion here https://mailman.videolan.org/pipermail/vlc-devel/2019-May/124752.html

This reverts commit fa0d74966e.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
Signed-off-by: David Fuhrmann <dfuhrmann@videolan.org>
Signed-off-by: Denis Charmet <typx@videolan.org>
2019-05-28 14:06:54 +02:00
Steve Lhomme
80ea20b275 libvlc: document the function to call to release some allocated structures 2019-05-27 15:29:07 +02:00
Steve Lhomme
cfb18f369d contrib: update libmatroska to 1.5.1 2019-05-27 09:11:44 +02:00
Steve Lhomme
7196586c6d contrib: update libebml to 1.3.8 2019-05-27 09:11:44 +02:00
Francois Cartegnie
740c1ad4ea demux: adaptive: rework pl update, keep played segments 2019-05-26 16:06:34 +02:00
Francois Cartegnie
a2de7e4fe7 demux: adaptive: enable timeshift for live content 2019-05-26 15:57:43 +02:00
Francois Cartegnie
93a0c4a914 demux: adaptive: fix timeline lookups 2019-05-26 15:50:30 +02:00
Francois Cartegnie
1363e2cba9 demux: adaptive: ensure presentation delay is used for live start 2019-05-26 15:50:14 +02:00
Francois Cartegnie
00021e8e6e demux: adaptive: cache total segments length 2019-05-26 15:43:08 +02:00
Francois Cartegnie
dad3c2d7d7 demux: smooth: set timeshift buffer 2019-05-24 23:42:15 +02:00
Francois Cartegnie
aa63b8cdea demux: smooth: don't create empty segments list just for init 2019-05-24 23:41:14 +02:00
Francois Cartegnie
ec82072b15 demux: adaptive: don't fill tokens from non templates 2019-05-24 23:41:03 +02:00
Francois Cartegnie
ea1838ef6b demux: adaptive: remove chunk to segment reference & refcounting
Only copy all properties so we can prune playlist at will
2019-05-24 23:40:55 +02:00
Francois Cartegnie
ae99d8cdd0 demux: adaptive: merge controls value updates 2019-05-24 23:40:47 +02:00
Francois Cartegnie
167b3d148b demux: adaptive: remove getDuration() 2019-05-24 23:33:07 +02:00
Felix Paul Kühne
d463b561b7 macosx/player: Explicitely initalize cb_device_changed 2019-05-24 19:30:21 +02:00
Hugo Beauzée-Luyssen
8d0444f14b qt: player_controller: Explicitely initalize on_device_changed 2019-05-24 13:57:37 +02:00
Romain Vimont
2ff16109cd qt: fix if-block scope
Oops.

Fixes commit 3f659b04f6.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
2019-05-24 13:48:01 +02:00
Hugo Beauzée-Luyssen
3ffd6408bc qt: Fix duration conversion 2019-05-24 13:42:55 +02:00
David Fuhrmann
fdbf7317e0 macosx: Unset p_interface_thread outside of the autoreleasepool
In theory, some objects are only released during drain of the
autorelease pool (i.e. at the place of the closing bracket of
the @autorelease block).

Some of those objects might need getInf() in their dealloc code,
so this pointer should stay available at this stage.

Should fix crash id 8f0bb1b4-fa5a-4d92-bcb3-9f6c0130fc86.
2019-05-23 21:04:52 +02:00
Hugo Beauzée-Luyssen
c6b07d7cec dmo: Fix use after free
https://hackerone.com/reports/513704
2019-05-23 17:16:13 +02:00
Hugo Beauzée-Luyssen
5ef3830f38 subsvtt: Don't pass a NULL pointer to qsort 2019-05-23 17:16:13 +02:00
Hugo Beauzée-Luyssen
81023659c7 mkv: Fix potential double free 2019-05-23 17:16:13 +02:00
Zinuo Han
3d2507c632 svcdsub: Fix potential buffer overrun
https://hackerone.com/reports/504722

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
2019-05-23 17:16:13 +02:00
Hugo Beauzée-Luyssen
de2d56055b ps: Fix read buffer overflow
https://hackerone.com/reports/504484
2019-05-23 17:16:13 +02:00
Hugo Beauzée-Luyssen
2e7d1075b7 avi: Fix potential integer overflow
Leading to an out of bound read

https://hackerone.com/reports/501971
https://hackerone.com/reports/484398
2019-05-23 17:16:13 +02:00
Hugo Beauzée-Luyssen
1c1923d8f6 mkv: Drop mismatched track types
https://hackerone.com/reports/503218
2019-05-23 17:16:13 +02:00
Hugo Beauzée-Luyssen
af75fb6f24 mkv: Fix potential buffer overflow
https://hackerone.com/reports/503218
2019-05-23 17:16:13 +02:00
Zinuo Han
f8c682365b ps: Fix off by one
https://hackerone.com/reports/504469

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
2019-05-23 17:16:13 +02:00