this allows to prioritize common shortcuts (Ctrl+C/Ctrl+V for instance) over vlc
custom shortcuts (resp. open media/open url). ideally we would use qt mechanism
onShortcutOverride but this is buggy before 5.13
fix: #26150
the shortcut should open the dialog only when triggered from the main view. The
other shortcuts are kept as application shortcut as triggering the shortcut will
close the associated dialog
libtool is notoriously known to have been patched over the time and was
provided as 2.4.7-dirty on archlinux, which makes the integer comparison
test fail since 7-dirty is not an integer.
shell || nicely handles the commands on the other lines without escaping
the end of line, which provides better error message in case of error.
In addition, priority of operators is much more obvious since the []
test syntax provides a visible scope-like feeling.
Errors can also be reported via generic cbs, that will cause the
vlc_smb2_mainloop to abort. In that case, we should destroy the smb2
context to fix the issue mentioned by 924c951518
Only the visualisation aout filters need the clock for the vout (for
now).
Create one slave clock per visualisation aout filter instead of always
creating one for all visualisation aout filters.
ubsan is enabled in the contrib recipe :
b3d158a304/CMakeLists.txt (lines-67)
This will require vlc to be always built with ubsan and we don't want this in production.
pl-output-hint is an integer variable, and it was leading to warnings
when compiling:
../../modules/video_output/libplacebo/display.c: In function 'UpdateColorspaceHint':
../../modules/video_output/libplacebo/display.c:499:5: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
499 | case OUTPUT_HDR10:
| ^~~~
../../modules/video_output/libplacebo/display.c:503:5: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
503 | case OUTPUT_HLG:
| ^~~~
../../modules/video_output/libplacebo/display.c:477:5: warning: switch condition has boolean value [-Wswitch-bool]
477 | switch (var_InheritBool(vd, "pl-output-hint")) {
| ^~~~~~
All interop modules reused the util function opengl_interop_init()
(written for the software interop) to initialize the textures properties
from the chroma.
However, the actual texture format may not always be deduced from the
chroma: only the interop implementations have the full knowledge of the
texture details.
Therefore, initialize texture properties directly from each interop
implementation.
Fixes#26735Fixes#26769
This will allow to call this function from interop modules.
This function is currently called from opengl_interop_init_impl() (the
init function pointer), which will be removed (so this narrows the scope
of helpers code exposed to modules).
In the future, more work will be needed to also remove this function
pointer.
The interop determines the format (currently based on the chroma and the
existence of the extension "GL_ARB_texture_rg").
Store this format in the vlc_gl_format, so that the sampler doesn't have
to guess by performing the same checks.
