github
/
revanced-integrations
mirror of https://github.com/revanced/revanced-integrations
1
Fork 0
Code Releases Activity

fix(youtube/downloads): rename patch to `external-downloads` (#414)

This commit is contained in:
LisoUseInAIKyrios 2023-05-26 15:03:31 +04:00 committed by GitHub
parent 3bd94b2f6a
commit b3c7e7f638
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/app/revanced/integrations/settings/SettingsEnum.java
View File

@ -32,7 +32,7 @@ import java.util.Objects;
public enum SettingsEnum { public enum SettingsEnum {
// External downloader // External downloader
EXTERNAL_DOWNLOADER("revanced_external_downloader", BOOLEAN, TRUE), EXTERNAL_DOWNLOADER("revanced_external_downloader", BOOLEAN, FALSE),
EXTERNAL_DOWNLOADER_PACKAGE_NAME("revanced_external_downloader_name", STRING, EXTERNAL_DOWNLOADER_PACKAGE_NAME("revanced_external_downloader_name", STRING,
"org.schabi.newpipe" /* NewPipe */, parents(EXTERNAL_DOWNLOADER)), "org.schabi.newpipe" /* NewPipe */, parents(EXTERNAL_DOWNLOADER)),

18
app/src/main/java/app/revanced/integrations/videoplayer/DownloadButton.java → app/src/main/java/app/revanced/integrations/videoplayer/ExternalDownloadButton.java
View File

@ -13,16 +13,16 @@ import app.revanced.integrations.utils.LogHelper;
import app.revanced.integrations.utils.ReVancedUtils; import app.revanced.integrations.utils.ReVancedUtils;
import app.revanced.integrations.utils.StringRef; import app.revanced.integrations.utils.StringRef;
public class DownloadButton extends BottomControlButton { public class ExternalDownloadButton extends BottomControlButton {
@Nullable @Nullable
private static DownloadButton instance; private static ExternalDownloadButton instance;
public DownloadButton(ViewGroup viewGroup) { public ExternalDownloadButton(ViewGroup viewGroup) {
super( super(
viewGroup, viewGroup,
"download_button", "external_download_button",
SettingsEnum.EXTERNAL_DOWNLOADER, SettingsEnum.EXTERNAL_DOWNLOADER,
DownloadButton::onDownloadClick, ExternalDownloadButton::onDownloadClick,
null null
); );
} }
@ -32,7 +32,7 @@ public class DownloadButton extends BottomControlButton {
*/ */
public static void initializeButton(View view) { public static void initializeButton(View view) {
try { try {
instance = new DownloadButton((ViewGroup) view); instance = new ExternalDownloadButton((ViewGroup) view);
} catch (Exception ex) { } catch (Exception ex) {
LogHelper.printException(() -> "initializeButton failure", ex); LogHelper.printException(() -> "initializeButton failure", ex);
} }
@ -46,7 +46,7 @@ public class DownloadButton extends BottomControlButton {
} }
private static void onDownloadClick(View view) { private static void onDownloadClick(View view) {
LogHelper.printDebug(() -> "Download button clicked"); LogHelper.printDebug(() -> "External download button clicked");
final var context = view.getContext(); final var context = view.getContext();
var downloaderPackageName = SettingsEnum.EXTERNAL_DOWNLOADER_PACKAGE_NAME.getString(); var downloaderPackageName = SettingsEnum.EXTERNAL_DOWNLOADER_PACKAGE_NAME.getString();
@ -55,12 +55,12 @@ public class DownloadButton extends BottomControlButton {
try { try {
packageEnabled = context.getPackageManager().getApplicationInfo(downloaderPackageName, 0).enabled; packageEnabled = context.getPackageManager().getApplicationInfo(downloaderPackageName, 0).enabled;
} catch (PackageManager.NameNotFoundException error) { } catch (PackageManager.NameNotFoundException error) {
LogHelper.printDebug(() -> "Downloader could not be found: " + error); LogHelper.printDebug(() -> "External downloader could not be found: " + error);
} }
// If the package is not installed, show the toast // If the package is not installed, show the toast
if (!packageEnabled) { if (!packageEnabled) {
ReVancedUtils.showToastLong(downloaderPackageName + " " + StringRef.str("downloader_not_installed_warning")); ReVancedUtils.showToastLong(downloaderPackageName + " " + StringRef.str("external_downloader_not_installed_warning"));
return; return;
} }