WIP: Fix links creation for windows/winfsp

.gitignore

@@ -16,3 +16,5 @@ Thumbs.db
 __pycache__
 .DS_Store
 *.kate-swp
+*debug*bin*
+.vscode/

vfs/dir.go

@@ -1101,12 +1101,18 @@ func (d *Dir) Rename(oldName, newName string, destDir *Dir) error {
 			rnewName += fs.LinkSuffix
 		}
 
-		_, err = destDir.stat(rnewName)
+		statFile, err := destDir.stat(rnewName)
 
 		switch err {
 		case ENOENT:
 			// not found, carry on
 		case nil:
+			// Special case for windows / winfsp symlinks, it create a file early that is never deleted, leading to clash.
+			if d.vfs.Opt.Links && isLink && strings.HasPrefix(oldName, ".fuse_hidden") {
+				statFile.(*File).winfspPendingSymlink = true
+				break
+			}
+
 			return EEXIST
 		default:
 			// a different error - report

vfs/file.go

@@ -53,6 +53,7 @@ type File struct {
 	sys                  atomic.Value                    // user defined info to be attached here
 	nwriters             atomic.Int32                    // len(writers)
 	appendMode           bool                            // file was opened with O_APPEND
+	winfspPendingSymlink bool                            // windows/winfsp symlinks support - when true, this file node needs to be deleted
 }
 
 // newFile creates a new File
@@ -285,6 +286,10 @@ func (f *File) addWriter(h Handle) {
 // delWriter removes a write handle from the file
 func (f *File) delWriter(h Handle) {
 	f.mu.Lock()
+	// Special case for windows / winfsp symlinks
+	if f.d.vfs.Opt.Links && f.winfspPendingSymlink && len(f.writers) == 1 {
+		defer f.Remove()
+	}
 	defer f.applyPendingRename()
 	defer f.mu.Unlock()
 	var found = -1

vfs/vfstest/file.go

@@ -78,10 +78,6 @@ func TestFileModTimeWithOpenWriters(t *testing.T) {
 func TestSymlinks(t *testing.T) {
 	run.skipIfNoFUSE(t)
 
-	if runtime.GOOS == "windows" {
-		t.Skip("Skipping test on Windows")
-	}
-
 	{
 		// VFS only implements os.Stat, which return information to target for symlinks, getting symlink information would require os.Lstat implementation.
 		// We will not bother to add Lstat implemented, but in the test we can just call os.Lstat which return the information needed when !useVFS