Fix wrong 'tracker error' count

This happens when a torrent contains some tracker URLs that share the same domain.
Closes #17808.

.github/workflows/ci_macos.yaml

@@ -46,7 +46,7 @@ jobs:
           mv "${{ github.workspace }}/.."/boost_* "${{ env.boost_path }}"
 
       - name: Install Qt
-        uses: jurplel/install-qt-action@v2
+        uses: jurplel/install-qt-action@v3
         with:
           version: ${{ matrix.qt_version }}
 

.github/workflows/ci_ubuntu.yaml

@@ -35,7 +35,7 @@ jobs:
             max_size=2G
 
       - name: Install Qt
-        uses: jurplel/install-qt-action@v2
+        uses: jurplel/install-qt-action@v3
         with:
           version: ${{ matrix.qt_version }}
 

.github/workflows/ci_windows.yaml

@@ -70,7 +70,7 @@ jobs:
           move "${{ github.workspace }}/../boost_*" "${{ env.boost_path }}"
 
       - name: Install Qt
-        uses: jurplel/install-qt-action@v2
+        uses: jurplel/install-qt-action@v3
         with:
           version: "5.15.2"
 

.github/workflows/coverity-scan.yml

@@ -21,7 +21,7 @@ jobs:
             libboost-dev libssl-dev zlib1g-dev
 
       - name: Install Qt
-        uses: jurplel/install-qt-action@v2
+        uses: jurplel/install-qt-action@v3
         with:
           version: "5.15.2"
 

Changelog

@@ -1,3 +1,35 @@
+Tue Aug 30 2022 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.4.5
+    - BUGFIX: Fix missing trackers when adding magnet link. Affects libtorrent 2.0.x builds. (glassez)
+
+Mon Aug 22 2022 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.4.4
+    - BUGFIX: Correctly handle data decompression with Qt 6.3 (brvphoenix)
+    - BUGFIX: Fix wrong file names displayed in tooltip (Chocobo1)
+    - BUGFIX: Fix incorrect "max outgoing port" setting (glassez)
+    - BUGFIX: Make working set limit available only on libtorrent 2.0.x builds (summer)
+    - BUGFIX: Try to recover missing tags (summer)
+    - RSS: Clear RSS parsing error after use (glassez)
+    - WEBAPI: Set HTTP method restriction on WebAPI actions (Chocobo1)
+    - WINDOWS: Work around application stuttering on Windows (Chocobo1)
+    - WINDOWS: NSIS: Update Portuguese, Italian, Korean, Latvian translations(Blackspirits, bovirus, Minseo Lee, Coool)
+    - LINUX: Improve D-Bus notifications handling (glassez)
+    - MACOS: Open destination folders on macOS in separate thread (Nick Korotysh)
+
+Tue May 24 2022 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.4.3.1
+    - BUGFIX: Fix broken translations (sledgehammer999)
+
+Sun May 22 2022 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.4.3
+    - BUGFIX: Correctly handle changing of temp save path (glassez)
+    - BUGFIX: Fix storage in SQLite (glassez)
+    - BUGFIX: Correctly apply content layout when "Skip hash check" is enabled (glassez)
+    - BUGFIX: Don't corrupt IDs of v2 torrents (glassez)
+    - BUGFIX: Reduce the number of hashing threads by default (improves hashing speed on HDDs) (summer)
+    - BUGFIX: Prevent the "update dialog" from blocking input on other windows (summer)
+    - BUGFIX: Add trackers in exported .torrent files (glassez)
+    - BUGFIX: Fix wrong GUI behavior in "Optional IP address to bind to" setting (Chocobo1)
+    - WEBUI: Fix WebUI crash due to missing tags from config (An0n)
+    - WEBUI: Show correct location path (Chocobo1)
+    - MACOS: Fix main window freezing after opening a files dialog (glassez)
+
 Tue Mar 22 2022 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.4.2
     - FEATURE: Allow to limit max memory working set size (glassez)
     - BUGFIX: Fix UI crash when torrent is in a non-existent category (Kevin Cox)

cmake/Modules/FindQtTranslations.cmake

@@ -0,0 +1,25 @@
+# Return Qt translations files as list of paths
+# It will return .qm files of qt/qtbase that aren't stub files.
+# Requires that Qt has been found first because it depends on qmake being available
+
+function(qbt_get_qt_translations qt_translations)
+    get_target_property(QT_QMAKE_EXECUTABLE Qt::qmake IMPORTED_LOCATION)
+    execute_process(COMMAND "${QT_QMAKE_EXECUTABLE}" -query QT_INSTALL_TRANSLATIONS
+                    OUTPUT_VARIABLE QT_TRANSLATIONS_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
+
+    FILE(GLOB QT_TEMP_TRANSLATIONS CONFIGURE_DEPENDS
+        "${QT_TRANSLATIONS_DIR}/qt_??.qm"
+        "${QT_TRANSLATIONS_DIR}/qt_??_??.qm"
+        "${QT_TRANSLATIONS_DIR}/qtbase_??.qm"
+        "${QT_TRANSLATIONS_DIR}/qtbase_??_??.qm")
+
+    foreach(TRANSLATION ${QT_TEMP_TRANSLATIONS})
+        FILE(SIZE "${TRANSLATION}" translation_size)
+        # Consider files less than 10KB as stub translations
+        if (translation_size GREATER_EQUAL 10240)
+            list(APPEND QT_FINAL_TRANSLATIONS "${TRANSLATION}")
+        endif()
+    endforeach()
+
+    SET(${qt_translations} ${QT_FINAL_TRANSLATIONS} PARENT_SCOPE)
+endfunction()

configure

@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.71 for qbittorrent v4.4.2.
+# Generated by GNU Autoconf 2.71 for qbittorrent v4.4.5.
 #
 # Report bugs to <bugs.qbittorrent.org>.
 #
@@ -611,8 +611,8 @@ MAKEFLAGS=
 # Identity of this package.
 PACKAGE_NAME='qbittorrent'
 PACKAGE_TARNAME='qbittorrent'
-PACKAGE_VERSION='v4.4.2'
-PACKAGE_STRING='qbittorrent v4.4.2'
+PACKAGE_VERSION='v4.4.5'
+PACKAGE_STRING='qbittorrent v4.4.5'
 PACKAGE_BUGREPORT='bugs.qbittorrent.org'
 PACKAGE_URL='https://www.qbittorrent.org/'
 
@@ -1329,7 +1329,7 @@ if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures qbittorrent v4.4.2 to adapt to many kinds of systems.
+\`configure' configures qbittorrent v4.4.5 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1400,7 +1400,7 @@ fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of qbittorrent v4.4.2:";;
+     short | recursive ) echo "Configuration of qbittorrent v4.4.5:";;
    esac
   cat <<\_ACEOF
 
@@ -1533,7 +1533,7 @@ fi
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-qbittorrent configure v4.4.2
+qbittorrent configure v4.4.5
 generated by GNU Autoconf 2.71
 
 Copyright (C) 2021 Free Software Foundation, Inc.
@@ -1648,7 +1648,7 @@ cat >config.log <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by qbittorrent $as_me v4.4.2, which was
+It was created by qbittorrent $as_me v4.4.5, which was
 generated by GNU Autoconf 2.71.  Invocation command line was
 
   $ $0$ac_configure_args_raw
@@ -4779,7 +4779,7 @@ fi
 
 # Define the identity of the package.
  PACKAGE='qbittorrent'
- VERSION='v4.4.2'
+ VERSION='v4.4.5'
 
 
 printf "%s\n" "#define PACKAGE \"$PACKAGE\"" >>confdefs.h
@@ -7254,7 +7254,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by qbittorrent $as_me v4.4.2, which was
+This file was extended by qbittorrent $as_me v4.4.5, which was
 generated by GNU Autoconf 2.71.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -7314,7 +7314,7 @@ ac_cs_config_escaped=`printf "%s\n" "$ac_cs_config" | sed "s/^ //; s/'/'\\\\\\\\
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config='$ac_cs_config_escaped'
 ac_cs_version="\\
-qbittorrent config.status v4.4.2
+qbittorrent config.status v4.4.5
 configured by $0, generated by GNU Autoconf 2.71,
   with options \\"\$ac_cs_config\\"
 

configure.ac

@@ -1,4 +1,4 @@
-AC_INIT([qbittorrent], [v4.4.2], [bugs.qbittorrent.org], [], [https://www.qbittorrent.org/])
+AC_INIT([qbittorrent], [v4.4.5], [bugs.qbittorrent.org], [], [https://www.qbittorrent.org/])
 AC_CONFIG_AUX_DIR([build-aux])
 AC_CONFIG_MACRO_DIR([m4])
 : ${CFLAGS=""}

dist/mac/Info.plist

@@ -55,7 +55,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>4.4.2</string>
+	<string>4.4.5</string>
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>