Update changelog

QBtSession::processBigRatios() must fetch the global ratio, if
applicable, before checking for NO_RATIO_LIMIT.

LP: #835217

Changelog

@@ -1,3 +1,22 @@
+* Sun Jun 24 2012 - Christophe Dumez <chris@qbittorrent.org> - v2.9.10
+    - BUGFIX: Fix possible crash when showing torrent content (closes #1002586)
+    - BUGFIX: Add support for RSS feeds using magnet links (closes #1016379)
+    - BUGFIX: Remove 100kb limit for torrent file size in Web UI
+    - BUGFIX: Fix ratio limiting bug (closes #835217)
+    - BUGFIX: Do not display .!qB file extensions in Web UI
+    - BUGFIX: Stop using absolute URLs in Web UI ajax requests (closes #1011226)
+    - BUGFIX: Fix torrent association and loading on Mac OS X (closes #1011229)
+    - BUGFIX: Fix unreversible "Minimize to tray" on some window managers (closes #917825)
+
+* Sun May 20 2012 - Christophe Dumez <chris@qbittorrent.org> - v2.9.9
+    - BUGFIX: More reliable RSS feed parsing (closes #1001777)
+    - BUGFIX: Better support for cookies in RSS
+    - BUGFIX: Make sure show/hide text in tray icon menu is correct
+    - COSMETIC: Improve style of left panel
+    - COSMETIC: Never disable properties panel
+    - COSMETIC: Make sure first tab is initially selected in options dialog
+    - COSMETIC: Fix a few focus issues on Mac OS X
+
 * Sat May 5 2012 - Christophe Dumez <chris@qbittorrent.org> - v2.9.8
     - BUGFIX: Various UI style fixes
     - BUGFIX: Fix compilation with gcc 4.7

macxconf.pri

@@ -5,6 +5,7 @@ DATADIR = /usr/local/share
 # Use pkg-config to get all necessary libtorrent DEFINES
 CONFIG += link_pkgconfig
 PKGCONFIG += libtorrent-rasterbar
+DEFINES += BOOST_ASIO_DYN_LINK
 
 # Special include/libs paths (macports)
 INCLUDEPATH += /usr/include/openssl /usr/include /opt/local/include/boost /opt/local/include

src/Info.plist

@@ -13,10 +13,6 @@
 			<string>qBitTorrentDocument</string>
 			<key>CFBundleTypeName</key>
 			<string>BitTorrent Document</string>
-			<key>CFBundleTypeMIMETypes</key>
-			<array>
-				<string>application/x-bittorrent</string>
-			</array>
 			<key>CFBundleTypeRole</key>
 			<string>Viewer</string>
 			<key>LSHandlerRank</key>
@@ -40,21 +36,55 @@
 			<string>BitTorrent Magnet URL</string>
 		</dict>
 	</array>
+	<key>CFBundleName</key>
+	<string>qBittorrent</string>
 	<key>CFBundleIconFile</key>
 	<string>qbittorrent_mac.icns</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
-	<key>CFBundleGetInfoString</key>
-	<string>2.9.8</string>
+	<key>CFBundleShortVersionString</key>
+	<string>2.9.10</string>
 	<key>CFBundleSignature</key>
-	<string>????</string>
+	<string>qBit</string>
 	<key>CFBundleExecutable</key>
 	<string>qbittorrent</string>
 	<key>CFBundleIdentifier</key>
 	<string>org.qbittorrent</string>
-	<key>NOTE</key>
-	<string>This file was generated by Qt/QMake.</string>
+	<key>NSAppleScriptEnabled</key>
+	<string>YES</string>
+	<key>NSHumanReadableCopyright</key>
+	<string>Copyright © 2006-2012 Christophe Dumez</string>
+	<key>UTExportedTypeDeclarations</key>
+	<array>
+		<dict>
+			<key>UTTypeConformsTo</key>
+			<array>
+				<string>public.data</string>
+				<string>public.item</string>
+				<string>com.bittorrent.torrent</string>
+			</array>
+			<key>UTTypeDescription</key>
+			<string>BitTorrent Document</string>
+			<key>UTTypeIconFile</key>
+			<string>qBitTorrentDocument</string>
+			<key>UTTypeIdentifier</key>
+			<string>org.bittorrent.torrent</string>
+			<key>UTTypeReferenceURL</key>
+			<string>http://www.bittorrent.org/beps/bep_0000.html</string>
+			<key>UTTypeTagSpecification</key>
+			<dict>
+				<key>com.apple.ostype</key>
+				<string>TORR</string>
+				<key>public.filename-extension</key>
+				<array>
+					<string>torrent</string>
+				</array>
+				<key>public.mime-type</key>
+				<string>application/x-bittorrent</string>
+			</dict>
+		</dict>
+	</array>
 </dict>
 </plist>

src/downloadthread.cpp

@@ -32,7 +32,6 @@
 #include <QNetworkAccessManager>
 #include <QNetworkRequest>
 #include <QNetworkProxy>
-#include <QNetworkCookie>
 #include <QNetworkCookieJar>
 
 #include "downloadthread.h"
@@ -109,39 +108,21 @@ void DownloadThread::processDlFinished(QNetworkReply* reply) {
   reply->deleteLater();
 }
 
-#ifndef DISABLE_GUI
-void DownloadThread::loadCookies(const QString &host_name, QString url) {
-  const QList<QByteArray> raw_cookies = RssSettings().getHostNameCookies(host_name);
-  QNetworkCookieJar *cookie_jar = m_networkManager.cookieJar();
-  QList<QNetworkCookie> cookies;
-  qDebug("Loading cookies for host name: %s", qPrintable(host_name));
-  foreach(const QByteArray& raw_cookie, raw_cookies) {
-    QList<QByteArray> cookie_parts = raw_cookie.split('=');
-    if(cookie_parts.size() == 2) {
-      qDebug("Loading cookie: %s", raw_cookie.constData());
-      cookies << QNetworkCookie(cookie_parts.first(), cookie_parts.last());
-    }
-  }
-  cookie_jar->setCookiesFromUrl(cookies, url);
-  m_networkManager.setCookieJar(cookie_jar);
-}
-#endif
-
-void DownloadThread::downloadTorrentUrl(const QString &url) {
+void DownloadThread::downloadTorrentUrl(const QString &url, const QList<QNetworkCookie>& cookies)
+{
   // Process request
-  QNetworkReply *reply = downloadUrl(url);
+  QNetworkReply *reply = downloadUrl(url, cookies);
   connect(reply, SIGNAL(downloadProgress(qint64,qint64)), this, SLOT(checkDownloadSize(qint64,qint64)));
 }
 
-QNetworkReply* DownloadThread::downloadUrl(const QString &url){
+QNetworkReply* DownloadThread::downloadUrl(const QString &url, const QList<QNetworkCookie>& cookies) {
   // Update proxy settings
   applyProxySettings();
-#ifndef DISABLE_GUI
-  // Load cookies
-  QString host_name = QUrl::fromEncoded(url.toUtf8()).host();
-  if(!host_name.isEmpty())
-    loadCookies(host_name, url);
-#endif
+  // Set cookies
+  if (!cookies.empty()) {
+    qDebug("Setting %d cookies for url: %s", cookies.size(), qPrintable(url));
+    m_networkManager.cookieJar()->setCookiesFromUrl(cookies, url);
+  }
   // Process download request
   qDebug("url is %s", qPrintable(url));
   const QUrl qurl = QUrl::fromEncoded(url.toUtf8());

src/downloadthread.h

@@ -32,6 +32,7 @@
 #define DOWNLOADTHREAD_H
 
 #include <QNetworkReply>
+#include <QNetworkCookie>
 #include <QObject>
 #include <QHash>
 #include <QSslError>
@@ -45,8 +46,8 @@ class DownloadThread : public QObject {
 
 public:
   DownloadThread(QObject* parent = 0);
-  QNetworkReply* downloadUrl(const QString &url);
-  void downloadTorrentUrl(const QString &url);
+  QNetworkReply* downloadUrl(const QString &url, const QList<QNetworkCookie>& raw_cookies = QList<QNetworkCookie>());
+  void downloadTorrentUrl(const QString &url, const QList<QNetworkCookie>& raw_cookies = QList<QNetworkCookie>());
   //void setProxy(QString IP, int port, QString username, QString password);
 
 signals:
@@ -63,9 +64,6 @@ private slots:
 private:
   QString errorCodeToString(QNetworkReply::NetworkError status);
   void applyProxySettings();
-#ifndef DISABLE_GUI
-  void loadCookies(const QString &host_name, QString url);
-#endif
 
 private:
   QNetworkAccessManager m_networkManager;

src/executionlog.h

@@ -37,8 +37,8 @@ QT_BEGIN_NAMESPACE
 namespace Ui {
     class ExecutionLog;
 }
-class LogListWidget;
 QT_END_NAMESPACE
+class LogListWidget;
 
 class ExecutionLog : public QWidget
 {

src/main.cpp

@@ -307,6 +307,9 @@ int main(int argc, char *argv[]){
   QObject::connect(&app, SIGNAL(messageReceived(const QString&)),
                    &window, SLOT(processParams(const QString&)));
   app.setActivationWindow(&window);
+#ifdef Q_WS_MAC
+  static_cast<QMacApplication*>(&app)->setReadyToProcessEvents();
+#endif // Q_WS_MAC
 #else
   // Load Headless class
   HeadlessLoader loader(torrentCmdLine);

src/mainwindow.cpp

@@ -145,6 +145,7 @@ MainWindow::MainWindow(QWidget *parent, QStringList torrentCmdLine) : QMainWindo
   connect(QBtSession::instance(), SIGNAL(finishedTorrent(QTorrentHandle)), this, SLOT(finishedTorrent(QTorrentHandle)));
   connect(QBtSession::instance(), SIGNAL(trackerAuthenticationRequired(QTorrentHandle)), this, SLOT(trackerAuthenticationRequired(QTorrentHandle)));
   connect(QBtSession::instance(), SIGNAL(newDownloadedTorrent(QString, QString)), this, SLOT(processDownloadedFiles(QString, QString)));
+  connect(QBtSession::instance(), SIGNAL(newMagnetLink(QString)), this, SLOT(processNewMagnetLink(QString)));
   connect(QBtSession::instance(), SIGNAL(downloadFromUrlFailure(QString, QString)), this, SLOT(handleDownloadFromUrlFailure(QString, QString)));
   connect(QBtSession::instance(), SIGNAL(alternativeSpeedsModeChanged(bool)), this, SLOT(updateAltSpeedsBtn(bool)));
   connect(QBtSession::instance(), SIGNAL(recursiveTorrentDownloadPossible(QTorrentHandle)), this, SLOT(askRecursiveTorrentDownloadConfirmation(QTorrentHandle)));
@@ -701,20 +702,12 @@ void MainWindow::toggleVisibility(QSystemTrayIcon::ActivationReason e) {
           return;
       }
       show();
-      if(isMinimized()) {
-        if(isMaximized()) {
-          showMaximized();
-        }else{
-          showNormal();
-        }
-      }
       raise();
       activateWindow();
     }else{
       hide();
     }
   }
-  actionToggleVisibility->setText(isVisible() ? tr("Hide") : tr("Show"));
 }
 
 // Display About Dialog
@@ -818,7 +811,7 @@ bool MainWindow::event(QEvent * e) {
         // Iconify if there is no modal window
         if(!has_modal_window) {
           qDebug("Minimize to Tray enabled, hiding!");
-          e->accept();
+          e->ignore();
           QTimer::singleShot(0, this, SLOT(hide()));
           return true;
         }
@@ -993,6 +986,17 @@ void MainWindow::processDownloadedFiles(QString path, QString url) {
   }
 }
 
+void MainWindow::processNewMagnetLink(const QString& link)
+{
+  QIniSettings settings(QString::fromUtf8("qBittorrent"), QString::fromUtf8("qBittorrent"));
+  const bool useTorrentAdditionDialog = settings.value(QString::fromUtf8("Preferences/Downloads/AdditionDialog"), true).toBool();
+  if (useTorrentAdditionDialog) {
+    torrentAdditionDialog *dialog = new torrentAdditionDialog(this);
+    dialog->showLoadMagnetURI(link);
+  } else
+    QBtSession::instance()->addMagnetUri(link);
+}
+
 void MainWindow::optionsSaved() {
   loadPreferences();
 }
@@ -1209,12 +1213,17 @@ void MainWindow::updateAltSpeedsBtn(bool alternative) {
   actionUse_alternative_speed_limits->setChecked(alternative);
 }
 
+void MainWindow::updateTrayIconMenu()
+{
+  actionToggleVisibility->setText(isVisible() ? tr("Hide") : tr("Show"));
+}
+
 QMenu* MainWindow::getTrayIconMenu() {
   if(myTrayIconMenu)
     return myTrayIconMenu;
   // Tray icon Menu
   myTrayIconMenu = new QMenu(this);
-  actionToggleVisibility->setText(isVisible() ? tr("Hide") : tr("Show"));
+  connect(myTrayIconMenu, SIGNAL(aboutToShow()), SLOT(updateTrayIconMenu()));
   myTrayIconMenu->addAction(actionToggleVisibility);
   myTrayIconMenu->addSeparator();
   myTrayIconMenu->addAction(actionOpen);

src/mainwindow.h

@@ -111,6 +111,7 @@ protected slots:
   void notifyOfUpdate(QString);
   void showConnectionSettings();
   void minimizeWindow();
+  void updateTrayIconMenu();
   // Keyboard shortcuts
   void createKeyboardShortcuts();
   void displayTransferTab() const;
@@ -128,6 +129,7 @@ protected slots:
   void addTorrent(QString path);
   void addUnauthenticatedTracker(const QPair<QTorrentHandle,QString> &tracker);
   void processDownloadedFiles(QString path, QString url);
+  void processNewMagnetLink(const QString& link);
   void finishedTorrent(const QTorrentHandle& h) const;
   void askRecursiveTorrentDownloadConfirmation(const QTorrentHandle &h);
   // Options slots

src/preferences/options.ui

@@ -72,7 +72,7 @@
        <bool>false</bool>
       </property>
       <property name="currentRow">
-       <number>-1</number>
+       <number>0</number>
       </property>
       <item>
        <property name="text">
@@ -1419,7 +1419,7 @@
             <rect>
              <x>0</x>
              <y>0</y>
-             <width>395</width>
+             <width>363</width>
              <height>480</height>
             </rect>
            </property>

src/properties/propertieswidget.cpp

@@ -70,7 +70,6 @@ PropertiesWidget::PropertiesWidget(QWidget *parent, MainWindow* main_window, Tra
   trackerDownButton->setIcon(IconProvider::instance()->getIcon("go-down"));
 
   state = VISIBLE;
-  setEnabled(false);
 
   // Set Properties list model
   PropListModel = new TorrentFilesFilterModel();
@@ -204,7 +203,6 @@ void PropertiesWidget::clear() {
   PropListModel->model()->clear();
   showPiecesAvailability(false);
   showPiecesDownloaded(false);
-  setEnabled(false);
 }
 
 QTorrentHandle PropertiesWidget::getCurrentTorrent() const {
@@ -241,7 +239,6 @@ void PropertiesWidget::loadTorrentInfos(const QTorrentHandle &_h) {
     clear();
     return;
   }
-  setEnabled(true);
 
   try {
     // Save path
@@ -655,7 +652,7 @@ void PropertiesWidget::deleteSelectedUrlSeeds(){
 
 bool PropertiesWidget::applyPriorities() {
   qDebug("Saving files priorities");
-  const std::vector<int> priorities = PropListModel->model()->getFilesPriorities(h.get_torrent_info().num_files());
+  const std::vector<int> priorities = PropListModel->model()->getFilesPriorities();
   // Save first/last piece first option state
   bool first_last_piece_first = h.first_last_piece_first();
   // Prioritize the files

src/qmacapplication.cpp

@@ -34,11 +34,21 @@
 #include "qmacapplication.h"
 
 QMacApplication::QMacApplication(QString appid, int &argc, char** argv) :
-    QtSingleApplication(appid, argc, argv)
+  QtSingleApplication(appid, argc, argv),
+  m_readyToProcessEvents(false)
 {
   qDebug("Constructing a QMacApplication to receive file open events");
 }
 
+void QMacApplication::setReadyToProcessEvents()
+{
+  m_readyToProcessEvents = true;
+  if (!m_torrentsQueue.isEmpty()) {
+    emit newFileOpenMacEvent(m_torrentsQueue.join("|"));
+    m_torrentsQueue.clear();
+  }
+}
+
 bool QMacApplication::event(QEvent * ev) {
   switch (ev->type()) {
   case QEvent::FileOpen:
@@ -49,7 +59,10 @@ bool QMacApplication::event(QEvent * ev) {
         path = static_cast<QFileOpenEvent *>(ev)->url().toString();
       }
       qDebug("Received a mac file open event: %s", qPrintable(path));
-      emit newFileOpenMacEvent(path);
+      if (m_readyToProcessEvents)
+        emit newFileOpenMacEvent(path);
+      else
+        m_torrentsQueue.append(path);
       return true;
     }
   default:

src/qmacapplication.h

@@ -31,12 +31,14 @@
 #define QMACAPPLICATION_H
 
 #include "qtsingleapplication.h"
+#include <QStringList>
 
 class QMacApplication : public QtSingleApplication
 {
   Q_OBJECT
 public:
   explicit QMacApplication(QString appid, int &argc, char** argv);
+  void setReadyToProcessEvents();
 
 signals:
   void newFileOpenMacEvent(const QString &path);
@@ -44,6 +46,9 @@ signals:
 protected:
   bool event(QEvent *);
 
+private:
+  bool m_readyToProcessEvents;
+  QStringList m_torrentsQueue;
 };
 
 #endif // QMACAPPLICATION_H

src/qtlibtorrent/qbtsession.cpp

@@ -181,7 +181,7 @@ QBtSession::QBtSession()
   const QString peer_id = "qB";
   // Construct session
   s = new session(fingerprint(peer_id.toLocal8Bit().constData(), version.at(0), version.at(1), version.at(2), version.at(3)), 0);
-  std::cout << "Peer ID: " << fingerprint(peer_id.toLocal8Bit().constData(), version.at(0), version.at(1), version.at(2), version.at(3)).to_string() << std::endl;
+  //std::cout << "Peer ID: " << fingerprint(peer_id.toLocal8Bit().constData(), version.at(0), version.at(1), version.at(2), version.at(3)).to_string() << std::endl;
   addConsoleMessage("Peer ID: "+misc::toQString(fingerprint(peer_id.toLocal8Bit().constData(), version.at(0), version.at(1), version.at(2), version.at(3)).to_string()));
 
   // Set severity level of libtorrent session
@@ -280,10 +280,10 @@ void QBtSession::processBigRatios() {
       const QString hash = h.hash();
       const qreal ratio = getRealRatio(hash);
       qreal ratio_limit = TorrentPersistentData::getRatioLimit(hash);
-      if(ratio_limit == TorrentPersistentData::NO_RATIO_LIMIT)
-        continue;
       if(ratio_limit == TorrentPersistentData::USE_GLOBAL_RATIO)
         ratio_limit = global_ratio_limit;
+      if(ratio_limit == TorrentPersistentData::NO_RATIO_LIMIT)
+        continue;
       qDebug("Ratio: %f (limit: %f)", ratio, ratio_limit);
       Q_ASSERT(ratio_limit >= 0.f);
       if(ratio <= MAX_RATIO && ratio >= ratio_limit) {
@@ -445,7 +445,7 @@ void QBtSession::configureSession() {
   // * Session settings
   session_settings sessionSettings = s->settings();
   sessionSettings.user_agent = "qBittorrent "VERSION;
-  std::cout << "HTTP user agent is " << sessionSettings.user_agent << std::endl;
+  //std::cout << "HTTP user agent is " << sessionSettings.user_agent << std::endl;
   addConsoleMessage(tr("HTTP user agent is %1").arg(misc::toQString(sessionSettings.user_agent)));
 
   sessionSettings.upnp_ignore_nonrouters = true;
@@ -972,7 +972,17 @@ QTorrentHandle QBtSession::addMagnetUri(QString magnet_uri, bool resumed) {
   add_torrent_params p = initializeAddTorrentParams(hash);
 
   // Get save path
-  const QString savePath(getSavePath(hash, false));
+  QString savePath;
+  if (!resumed && savepathLabel_fromurl.contains(magnet_uri)) {
+    QPair<QString, QString> savePath_label = savepathLabel_fromurl.take(magnet_uri);
+    if(!savePath_label.first.isEmpty())
+      savePath = savePath_label.first;
+    // Remember label
+    if(!savePath_label.second.isEmpty())
+      TorrentTempData::setLabel(hash, savePath_label.second);
+  }
+  if (savePath.isEmpty())
+    savePath = getSavePath(hash, false);
   if(!defaultTempPath.isEmpty() && !TorrentPersistentData::isSeed(hash) && resumed) {
     qDebug("addMagnetURI: Temp folder is enabled.");
     QString torrent_tmp_path = defaultTempPath.replace("\\", "/");
@@ -2757,7 +2767,8 @@ QString QBtSession::getSavePath(const QString &hash, bool fromScanDir, QString f
 // Take an url string to a torrent file,
 // download the torrent file to a tmp location, then
 // add it to download list
-void QBtSession::downloadFromUrl(const QString &url) {
+void QBtSession::downloadFromUrl(const QString &url, const QList<QNetworkCookie>& cookies)
+{
   addConsoleMessage(tr("Downloading '%1', please wait...", "e.g: Downloading 'xxx.torrent', please wait...").arg(url)
                   #ifndef DISABLE_GUI
                     , QPalette::WindowText
@@ -2765,7 +2776,7 @@ void QBtSession::downloadFromUrl(const QString &url) {
                     );
   //emit aboutToDownloadFromUrl(url);
   // Launch downloader thread
-  downloader->downloadTorrentUrl(url);
+  downloader->downloadTorrentUrl(url, cookies);
 }
 
 void QBtSession::downloadFromURLList(const QStringList& urls) {
@@ -2774,14 +2785,22 @@ void QBtSession::downloadFromURLList(const QStringList& urls) {
   }
 }
 
-void QBtSession::addMagnetSkipAddDlg(QString uri) {
+void QBtSession::addMagnetInteractive(const QString& uri)
+{
+  emit newMagnetLink(uri);
+}
+
+void QBtSession::addMagnetSkipAddDlg(const QString& uri, const QString& save_path, const QString& label) {
+  if (!save_path.isEmpty() || !label.isEmpty())
+    savepathLabel_fromurl[uri] = qMakePair(save_path, label);
   addMagnetUri(uri, false);
 }
 
 void QBtSession::downloadUrlAndSkipDialog(QString url, QString save_path, QString label) {
   //emit aboutToDownloadFromUrl(url);
   const QUrl qurl = QUrl::fromEncoded(url.toUtf8());
-  savepathLabel_fromurl[qurl] = qMakePair(save_path, label);
+  if (!save_path.isEmpty() || !label.isEmpty())
+    savepathLabel_fromurl[qurl] = qMakePair(save_path, label);
   url_skippingDlg << qurl;
   // Launch downloader thread
   downloader->downloadTorrentUrl(url);

src/qtlibtorrent/qbtsession.h

@@ -41,6 +41,7 @@
 #endif
 #include <QPointer>
 #include <QTimer>
+#include <QNetworkCookie>
 
 #include <libtorrent/version.hpp>
 #include <libtorrent/session.hpp>
@@ -107,7 +108,7 @@ public slots:
   QTorrentHandle addMagnetUri(QString magnet_uri, bool resumed=false);
   void loadSessionState();
   void saveSessionState();
-  void downloadFromUrl(const QString &url);
+  void downloadFromUrl(const QString &url, const QList<QNetworkCookie>& cookies = QList<QNetworkCookie>());
   void deleteTorrent(const QString &hash, bool delete_local_files = false);
   void startUpTorrents();
   void recheckTorrent(const QString &hash);
@@ -163,7 +164,8 @@ public slots:
 #endif
   void addPeerBanMessage(QString msg, bool from_ipfilter);
   void processDownloadedFile(QString, QString);
-  void addMagnetSkipAddDlg(QString uri);
+  void addMagnetSkipAddDlg(const QString& uri, const QString& save_path = QString(), const QString& label = QString());
+  void addMagnetInteractive(const QString& uri);
   void downloadFromURLList(const QStringList& urls);
   void configureSession();
   void banIP(QString ip);
@@ -204,6 +206,7 @@ signals:
   void trackerError(const QString &hash, QString time, QString msg);
   void trackerAuthenticationRequired(const QTorrentHandle& h);
   void newDownloadedTorrent(QString path, QString url);
+  void newMagnetLink(const QString& link);
   void updateFileSize(const QString &hash);
   void downloadFromUrlFailure(QString url, QString reason);
   void torrentFinishedChecking(const QTorrentHandle& h);

src/rss/rss_imp.cpp

@@ -124,13 +124,14 @@ void RSSImp::on_actionManage_cookies_triggered() {
   Q_ASSERT(!m_feedList->selectedItems().empty());
   // Get feed hostname
   QString feed_url = m_feedList->getItemID(m_feedList->selectedItems().first());
-  QString feed_hostname = QUrl::fromEncoded(feed_url.toLocal8Bit()).host();
+  QString feed_hostname = QUrl::fromEncoded(feed_url.toUtf8()).host();
   qDebug("RSS Feed hostname is: %s", qPrintable(feed_hostname));
   Q_ASSERT(!feed_hostname.isEmpty());
   bool ok = false;
   RssSettings settings;
   QList<QByteArray> raw_cookies = CookiesDlg::askForCookies(this, settings.getHostNameCookies(feed_hostname), &ok);
-  if(ok) {
+  if (ok) {
+    qDebug() << "Settings cookies for host name: " << feed_hostname;
     settings.setHostNameCookies(feed_hostname, raw_cookies);
   }
 }
@@ -325,10 +326,28 @@ void RSSImp::downloadTorrent() {
   foreach(const QListWidgetItem* item, selected_items) {
     const RssArticle article =  m_feedList->getRSSItemFromUrl(item->data(Article::FeedUrlRole).toString())
         ->getItem(item->data(Article::IdRole).toString());
-    if(article.hasAttachment()) {
-      QBtSession::instance()->downloadFromUrl(article.torrentUrl());
-    } else {
-      QBtSession::instance()->downloadFromUrl(article.link());
+
+    QString torrentLink = article.hasAttachment() ? article.torrentUrl() : article.link();
+
+    // Check if it is a magnet link
+    if (torrentLink.startsWith("magnet:", Qt::CaseInsensitive))
+      QBtSession::instance()->addMagnetInteractive(torrentLink);
+    else {
+      // Load possible cookies
+      QList<QNetworkCookie> cookies;
+      QString feed_url = m_feedList->getItemID(m_feedList->selectedItems().first());
+      QString feed_hostname = QUrl::fromEncoded(feed_url.toUtf8()).host();
+      const QList<QByteArray> raw_cookies = RssSettings().getHostNameCookies(feed_hostname);
+      foreach (const QByteArray& raw_cookie, raw_cookies) {
+        QList<QByteArray> cookie_parts = raw_cookie.split('=');
+        if (cookie_parts.size() == 2) {
+          qDebug("Loading cookie: %s = %s", cookie_parts.first().constData(), cookie_parts.last().constData());
+          cookies << QNetworkCookie(cookie_parts.first(), cookie_parts.last());
+        }
+      }
+      qDebug("Loaded %d cookies for RSS item\n", cookies.size());
+
+      QBtSession::instance()->downloadFromUrl(torrentLink, cookies);
     }
   }
 }

src/rss/rssarticle.cpp

@@ -229,6 +229,13 @@ RssArticle::RssArticle(RssFeed* parent, QXmlStreamReader& xml)
       }
     }
   }
+  // If guid is empty, fall back to some other identifier
+  if (d->guid.isEmpty()) {
+    if (!d->link.isEmpty())
+      d->guid = d->link;
+    else if (!d->title.isEmpty())
+      d->guid = d->title;
+  }
 }
 
 RssArticle::RssArticle(RssFeed* parent, const QString &guid) {

src/rss/rssfeed.cpp

@@ -314,7 +314,10 @@ void RssFeed::downloadMatchingArticleTorrents() {
       item.markAsRead();
       // Download the torrent
       QBtSession::instance()->addConsoleMessage(tr("Automatically downloading %1 torrent from %2 RSS feed...").arg(item.title()).arg(displayName()));
-      QBtSession::instance()->downloadUrlAndSkipDialog(torrent_url, matching_rule.savePath(), matching_rule.label());
+      if (torrent_url.startsWith("magnet:", Qt::CaseInsensitive))
+        QBtSession::instance()->addMagnetSkipAddDlg(torrent_url, matching_rule.savePath(), matching_rule.label());
+      else
+        QBtSession::instance()->downloadUrlAndSkipDialog(torrent_url, matching_rule.savePath(), matching_rule.label());
     }
   }
 }

src/searchengine/nova/engines/kickasstorrents.py

@@ -1,4 +1,4 @@
-#VERSION: 1.21
+#VERSION: 1.22
 #AUTHORS: Christophe Dumez (chris@qbittorrent.org)
 
 # Redistribution and use in source and binary forms, with or without
@@ -39,7 +39,7 @@ class kickasstorrents(object):
     self.results = []
 
   def download_torrent(self, info):
-    print download_file(info)
+    print download_file(info, info)
 
   def search(self, what, cat='all'):
     ret = []

src/searchengine/nova3/engines/kickasstorrents.py

@@ -1,4 +1,4 @@
-#VERSION: 1.21
+#VERSION: 1.22
 #AUTHORS: Christophe Dumez (chris@qbittorrent.org)
 
 # Redistribution and use in source and binary forms, with or without
@@ -39,7 +39,7 @@ class kickasstorrents(object):
     self.results = []
 
   def download_torrent(self, info):
-    print(download_file(info))
+    print(download_file(info, info))
 
   def search(self, what, cat='all'):
     ret = []

src/searchengine/searchengine.cpp

@@ -421,7 +421,8 @@ void SearchEngine::downloadTorrent(QString engine_url, QString torrent_url) {
     qDebug("Converting bc link to magnet link");
     torrent_url = misc::bcLinkToMagnet(torrent_url);
   }
-  if(torrent_url.startsWith("magnet:")) {
+  qDebug() << Q_FUNC_INFO << torrent_url;
+  if (torrent_url.startsWith("magnet:")) {
     QStringList urls;
     urls << torrent_url;
     mp_mainWindow->downloadFromURLList(urls);

src/torrentadditiondlg.cpp

@@ -501,10 +501,8 @@ void torrentAdditionDialog::updateDiskSpaceLabels() {
     // Determine torrent size
     qulonglong torrent_size = 0;
     if(t->num_files() > 1) {
-      const unsigned int nbFiles = t->num_files();
-      const std::vector<int> priorities = PropListModel->model()->getFilesPriorities(nbFiles);
-
-      for(unsigned int i=0; i<nbFiles; ++i) {
+      const std::vector<int> priorities = PropListModel->model()->getFilesPriorities();
+      for(unsigned int i=0; i<priorities.size(); ++i) {
         if(priorities[i] > 0)
           torrent_size += t->file_at(i).size;
       }
@@ -598,7 +596,7 @@ bool torrentAdditionDialog::allFiltered() const {
 void torrentAdditionDialog::savePiecesPriorities(){
   qDebug("Saving pieces priorities");
   Q_ASSERT(!is_magnet);
-  const std::vector<int> priorities = PropListModel->model()->getFilesPriorities(t->num_files());
+  const std::vector<int> priorities = PropListModel->model()->getFilesPriorities();
   TorrentTempData::setFilesPriority(hash, priorities);
 }
 

src/torrentfilesmodel.h

@@ -338,11 +338,10 @@ class TorrentFilesModel:  public QAbstractItemModel {
 
 private:
   TorrentFileItem *rootItem;
-  TorrentFileItem **files_index;
+  std::vector<TorrentFileItem *> files_index;
 
 public:
   TorrentFilesModel(QObject *parent=0): QAbstractItemModel(parent) {
-    files_index = 0;
     QList<QVariant> rootData;
     rootData << tr("Name") << tr("Size") << tr("Progress") << tr("Priority");
     rootItem = new TorrentFileItem(rootData);
@@ -350,13 +349,16 @@ public:
 
   ~TorrentFilesModel() {
     qDebug() << Q_FUNC_INFO << "ENTER";
-    delete [] files_index;
     delete rootItem;
     qDebug() << Q_FUNC_INFO << "EXIT";
   }
 
-  void updateFilesProgress(std::vector<libtorrent::size_type> fp) {
+  void updateFilesProgress(const std::vector<libtorrent::size_type>& fp) {
     emit layoutAboutToBeChanged();
+
+    if (fp.size() != files_index.size())
+      return;
+
     for(unsigned int i=0; i<fp.size(); ++i) {
       Q_ASSERT(fp[i] >= 0);
       files_index[i]->setProgress(fp[i]);
@@ -366,6 +368,10 @@ public:
 
   void updateFilesPriorities(const std::vector<int> &fprio) {
     emit layoutAboutToBeChanged();
+
+    if (fprio.size() != files_index.size())
+      return;
+
     for(unsigned int i=0; i<fprio.size(); ++i) {
       //qDebug("Called updateFilesPriorities with %d", fprio[i]);
       files_index[i]->setPriority(fprio[i]);
@@ -373,9 +379,9 @@ public:
     emit dataChanged(index(0,0), index(rowCount(), columnCount()));
   }
 
-  std::vector<int> getFilesPriorities(unsigned int nbFiles) const {
+  std::vector<int> getFilesPriorities() const {
     std::vector<int> prio;
-    for(unsigned int i=0; i<nbFiles; ++i) {
+    for(unsigned int i=0; i<files_index.size(); ++i) {
       //qDebug("Called getFilesPriorities: %d", files_index[i]->getPriority());
       prio.push_back(files_index[i]->getPriority());
     }
@@ -541,10 +547,7 @@ public:
   void clear() {
     qDebug("clear called");
     beginResetModel();
-    if(files_index) {
-      delete [] files_index;
-      files_index = 0;
-    }
+    files_index.clear();
     rootItem->deleteAllChildren();
     endResetModel();
   }
@@ -555,7 +558,7 @@ public:
     emit layoutAboutToBeChanged();
     // Initialize files_index array
     qDebug("Torrent contains %d files", t.num_files());
-    files_index = new TorrentFileItem*[t.num_files()];
+    files_index.reserve(t.num_files());
 
     TorrentFileItem *parent = this->rootItem;
     TorrentFileItem *root_folder = parent;
@@ -582,8 +585,7 @@ public:
         current_parent = new_parent;
       }
       // Actually create the file
-      TorrentFileItem *f = new TorrentFileItem(t, fentry, current_parent, i);
-      files_index[i] = f;
+      files_index.push_back(new TorrentFileItem(t, fentry, current_parent, i));
     }
     emit layoutChanged();
   }

src/transferlistfilterswidget.h

@@ -42,6 +42,7 @@
 #include <QStandardItemModel>
 #include <QMessageBox>
 #include <QScrollBar>
+#include <QLabel>
 
 #include "transferlistdelegate.h"
 #include "transferlistwidget.h"
@@ -62,6 +63,7 @@ public:
     // Accept drop
     setAcceptDrops(true);
     setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding);
+    setStyleSheet("QListWidget { background: transparent; border: 0 }");
   }
 
   // Redefine addItem() to make sure the list stays sorted
@@ -158,13 +160,14 @@ public:
     setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
     // Height is fixed (sizeHint().height() is used)
     setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed);
+    setStyleSheet("QListWidget { background: transparent; border: 0 }");
   }
 
 protected:
   QSize sizeHint() const {
     QSize size = QListWidget::sizeHint();
     // Height should be exactly the height of the content
-    size.setHeight(contentsSize().height() + 2 * frameWidth());
+    size.setHeight(contentsSize().height() + 2 * frameWidth() + 6);
     return size;
   }
 
@@ -190,10 +193,23 @@ public:
     // Construct lists
     vLayout = new QVBoxLayout();
     vLayout->setContentsMargins(0, 4, 0, 4);
+    QFont font;
+    font.setBold(true);
+    font.setCapitalization(QFont::SmallCaps);
+    QLabel *torrentsLabel = new QLabel(tr("Torrents"));
+    torrentsLabel->setIndent(2);
+    torrentsLabel->setFont(font);
+    vLayout->addWidget(torrentsLabel);
     statusFilters = new StatusFiltersWidget(this);
     vLayout->addWidget(statusFilters);
+    statusFilters->setFocusPolicy(Qt::NoFocus);
+    QLabel *labelsLabel = new QLabel(tr("Labels"));
+    labelsLabel->setIndent(2);
+    labelsLabel->setFont(font);
+    vLayout->addWidget(labelsLabel);
     labelFilters = new LabelFiltersList(this);
     vLayout->addWidget(labelFilters);
+    labelFilters->setFocusPolicy(Qt::NoFocus);
     setLayout(vLayout);
     labelFilters->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
     statusFilters->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);

src/webui/eventmanager.cpp

@@ -109,7 +109,10 @@ QList<QVariantMap> EventManager::getPropFilesInfo(QString hash) const {
   h.file_progress(fp);
   for(int i=0; i<h.num_files(); ++i) {
     QVariantMap file;
-    file["name"] = h.filename_at(i);
+    QString fileName = h.filename_at(i);
+    if (fileName.endsWith(".!qB"))
+      fileName.chop(4);
+    file["name"] = fileName;
     libtorrent::size_type size = h.filesize_at(i);
     file["size"] = misc::friendlyUnit((double)size);
     if(size > 0)

src/webui/html/about.html

@@ -1,4 +1,4 @@
-<img src="../images/skin/mascot.png" align="right"></img>
+<img src="images/skin/mascot.png" align="right"></img>
 <p>qBittorrent ${VERSION} (Web UI)</p>
 <p>Copyright (c) 2011 <a href="mailto:chris@qbittorrent.org">Christophe Dumez</a></p>
 <p>Homepage: <a href="http://www.qbittorrent.com">http://www.qbittorrent.com</a></p>

src/webui/html/addtrackers.html

@@ -12,7 +12,7 @@
 	$('addTrackersButton').addEvent('click', function(e){
 		new Event(e).stop();
 		var hash = new URI().getData('hash');
-		new Request({url: '/command/addTrackers', method: 'post', data: {hash: hash, urls: $('trackersUrls').value},
+		new Request({url: 'command/addTrackers', method: 'post', data: {hash: hash, urls: $('trackersUrls').value},
 			onComplete: function() {
 				window.parent.document.getElementById('trackersPage').parentNode.removeChild(window.parent.document.getElementById('trackersPage'));
 			}

src/webui/html/confirmdeletion.html

@@ -45,9 +45,9 @@ window.addEvent('domready', function(){
         });
 	$('confirmBtn').addEvent('click', function(e){
 		new Event(e).stop();
-		var cmd = '/command/delete';
+		var cmd = 'command/delete';
                 if($('deleteFromDiskCB').get('checked'))
-			 cmd = '/command/deletePerm';
+			 cmd = 'command/deletePerm';
                 new Request({url: cmd, 
                              method: 'post', 
                              data: {hashes: hashes.join('|')},

src/webui/html/downloadlimit.html

@@ -25,7 +25,7 @@
 	setDlLimit = function() {
 		var limit = $("dllimitUpdatevalue").get('html').toInt() * 1024;
 		if(hash == "global") {
-			new Request({url: '/command/setGlobalDlLimit',
+			new Request({url: 'command/setGlobalDlLimit',
 				    method: 'post',
 				    data: {'limit': limit},
 				    onComplete: function() {
@@ -33,7 +33,7 @@
 				    }
 			}).send();
 		} else {
-			new Request({url: '/command/setTorrentDlLimit',
+			new Request({url: 'command/setTorrentDlLimit',
 				    method: 'post',
 				    data: {'hash': hash, 'limit': limit},
 				    onComplete: function() {
@@ -51,4 +51,4 @@
 </script>
 
 </body>
-</html>
+</html>

src/webui/html/preferences_content.html

@@ -196,7 +196,7 @@
 
 <fieldset class="settings">
   <legend>_(Torrent Queueing)</legend>
-  <input type="checkbox" id="queueing_checkbox" onclick="updateQueuingSystem();"/>
+  <input type="checkbox" id="queueing_checkbox" onclick="updateQueueingSystem();"/>
   <label for="queueing_checkbox">_(Torrent Queueing)</label><br/>
   <div class="formRow">
   <label for="max_active_dl_value" style="margin-left: 20px;" class="leftLabelLarge">_(Maximum active downloads:)</label>
@@ -1043,7 +1043,7 @@ applyPreferences = function() {
   // Send it to qBT
   var json_str = JSON.encode(settings);
 
-  new Request({url: '/command/setPreferences',
+  new Request({url: 'command/setPreferences',
 			    method: 'post',
 			    data: {'json': json_str,
                                    },

src/webui/html/prop-files.html

@@ -88,7 +88,7 @@ var allCBUnchecked = function() {
     
 var setFilePriority = function(id, priority) {
   if(current_hash == "") return;
-  new Request({url: '/command/setFilePrio', method: 'post', data: {'hash': current_hash, 'id': id, 'priority': priority}}).send();
+  new Request({url: 'command/setFilePrio', method: 'post', data: {'hash': current_hash, 'id': id, 'priority': priority}}).send();
   // Display or add combobox
   if(priority > 0) {
     $('comboPrio'+id).set("value", 1);

src/webui/html/upload.html

@@ -15,7 +15,7 @@ function hideAll() {
 <iframe id="upload_frame" name="upload_frame" style="width:1px;height:1px;border:0px;" src="javascript:false;"></iframe>
 <center>
 	<h1 class="vcenter"><img class="vcenter" title="Download local torrent" src="theme/list-add"/>_(Download local torrent)</h1>
-<form action="/command/upload" enctype="multipart/form-data" method="post" id="uploadForm" target="upload_frame">
+<form action="command/upload" enctype="multipart/form-data" method="post" id="uploadForm" target="upload_frame">
   <input type="file" name="torrentfile" id="torrentfile" size="40"/><br/><br/>
   <input type="submit" value="_(Download)" id="upButton"/>
 </form>