bitcoin/test/functional
Samuel Dobson 629c4ab2e3
Merge bitcoin/bitcoin#22100: refactor: Clean up new wallet spend, receive files added #21207
b11a195ef4 refactor: Detach wallet transaction methods (followup for move-only) (Russell Yanofsky)

Pull request description:

  This makes `CWallet` and `CWalletTx` methods in `spend.cpp` and `receive.cpp` files into standalone functions.

  It's a followup to [#21207 MOVEONLY: CWallet transaction code out of wallet.cpp/.h](https://github.com/bitcoin/bitcoin/pull/21207), which moved code from `wallet.cpp` to new `spend.cpp` and `receive.cpp` files.

  There are no changes in behavior. This is just making methods into functions and removing circular dependencies created by #21207. There are no comment or documentation changes, either. Removed comments from `transaction.h` are just migrated to `spend.h`, `receive.h`, and `wallet.h`.

  ---

  This commit was split off from #21206 so there are a few earlier review comments there

ACKs for top commit:
  achow101:
    ACK b11a195ef4
  Sjors:
    utACK b11a195ef4
  meshcollider:
    light ACK b11a195ef4

Tree-SHA512: 75ce818d3f03b728b14b12e2d21bd20b7be73978601989cb37ff98254393300d1bb7823281449cd3d9e40756d67d42bd9a46bbdafd2e8baa95aaf2cb1c84549f
2021-09-03 21:21:58 +12:00
..
data Merge bitcoin/bitcoin#22363: test: refactor: use `script_util` helpers for creating P2{PKH,SH,WPKH,WSH} scripts 2021-07-09 11:17:58 +02:00
mocks rpc: send: support external signer 2021-02-23 14:34:32 +01:00
test_framework Set regtest.BIP65Height = 111 to speed up tests 2021-08-26 11:08:24 +02:00
.gitignore
README.md doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
combine_logs.py scripted-diff: Add missed copyright headers 2020-01-04 20:18:28 +02:00
combined_log_template.html
create_cache.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
example_test.py doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
feature_abortnode.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
feature_anchors.py test: Disable automatic connections by default 2021-07-26 19:11:13 +02:00
feature_asmap.py test: use f-strings in feature_asmap.py 2021-08-18 09:52:25 +08:00
feature_assumevalid.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
feature_backwards_compatibility.py test: use f-strings in feature_backwards_compatibility.py 2021-08-18 12:39:08 +08:00
feature_bind_extra.py net: don't bind on 0.0.0.0 if binds are restricted to Tor 2021-07-07 15:46:38 +02:00
feature_bip68_sequence.py test: remove `ToHex` helper, use .serialize().hex() instead 2021-06-21 14:30:03 +02:00
feature_block.py Merge bitcoin/bitcoin#16333: test: Set BIP34Height = 2 for regtest 2021-08-03 10:10:43 +02:00
feature_blockfilterindex_prune.py index: Avoid async shutdown on init error 2021-05-12 10:47:35 +02:00
feature_blocksdir.py test: use f-strings in feature_blocksdir.py 2021-08-18 12:39:17 +08:00
feature_cltv.py Set regtest.BIP65Height = 111 to speed up tests 2021-08-26 11:08:24 +02:00
feature_coinstatsindex.py Merge bitcoin/bitcoin#22047: index, rpc: Coinstatsindex follow-ups 2021-07-28 15:19:34 +02:00
feature_config_args.py Merge bitcoin/bitcoin#22622: util: Check if specified config file cannot be opened 2021-08-23 12:58:01 +02:00
feature_csv_activation.py test: use f-strings in feature_csv_activation.py 2021-08-18 12:39:17 +08:00
feature_dbcrash.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
feature_dersig.py test: use f-strings in feature_dersig.py 2021-08-18 12:39:17 +08:00
feature_fee_estimation.py test: use f-strings in feature_fee_estimation.py 2021-08-18 12:39:18 +08:00
feature_filelock.py test: use f-strings in feature_filelock.py 2021-08-18 12:39:18 +08:00
feature_help.py test: use f-strings in feature_help.py 2021-08-18 12:39:18 +08:00
feature_includeconf.py Cleanup -includeconf error message 2021-05-21 10:54:12 +02:00
feature_loadblock.py test: use f-strings in feature_loadblock.py 2021-08-18 12:39:18 +08:00
feature_logging.py test: use f-strings in feature_logging.py 2021-08-18 12:39:18 +08:00
feature_maxuploadtarget.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
feature_minchainwork.py test: use f-strings in feature_minchainwork.py 2021-08-18 12:39:19 +08:00
feature_notifications.py test: use f-strings in feature_notifications.py 2021-08-18 12:39:19 +08:00
feature_nulldummy.py test: fix failure in feature_nulldummy.py on single-core machines 2021-08-23 18:11:37 +02:00
feature_presegwit_node_upgrade.py [test] remove or move tests using `-segwitheight=-1` 2021-07-07 22:12:04 -07:00
feature_proxy.py test: use f-strings in feature_proxy.py 2021-08-18 12:39:20 +08:00
feature_pruning.py test: use f-strings in feature_pruning.py 2021-08-18 12:39:19 +08:00
feature_rbf.py test: Check that non-signaling BIP125 tx can be replaced via parent 2021-08-30 17:01:46 +02:00
feature_reindex.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_segwit.py test: use f-strings in feature_segwit.py 2021-08-18 12:39:20 +08:00
feature_settings.py test: use f-strings in feature_settings.py 2021-08-18 12:39:19 +08:00
feature_shutdown.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_signet.py signet: do not log signet startup messages for other chains 2020-10-01 11:25:42 +02:00
feature_taproot.py Merge bitcoin/bitcoin#20354: test: Add feature_taproot.py --previous_release 2021-07-14 10:57:06 +02:00
feature_uacomment.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_utxo_set_hash.py scripted-diff: test: rename `FromHex` to `from_hex` 2021-06-21 14:33:59 +02:00
feature_versionbits_warning.py test: use f-strings in feature_versionbits_warning.py 2021-08-18 12:39:19 +08:00
interface_bitcoin_cli.py test: use f-strings in interface_*.py tests 2021-08-18 12:39:20 +08:00
interface_http.py test: use f-strings in interface_*.py tests 2021-08-18 12:39:20 +08:00
interface_rest.py test: use f-strings in interface_*.py tests 2021-08-18 12:39:20 +08:00
interface_rpc.py test: use f-strings in interface_*.py tests 2021-08-18 12:39:20 +08:00
interface_zmq.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
mempool_accept.py Merge bitcoin/bitcoin#22378: test: remove confusing `MAX_BLOCK_BASE_SIZE` 2021-08-02 15:51:48 +02:00
mempool_accept_wtxid.py test: use getmempoolentry instead of getrawmempool in functional tests when appropriate 2021-08-16 18:29:07 +05:00
mempool_compatibility.py test: use getmempoolentry instead of getrawmempool in functional tests when appropriate 2021-08-16 18:29:07 +05:00
mempool_expiry.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
mempool_limit.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
mempool_package_limits.py test: use getmempoolentry instead of getrawmempool in functional tests when appropriate 2021-08-16 18:29:07 +05:00
mempool_package_onemore.py test: only use verbose for getrawmempool when necessary in functional tests 2021-08-16 18:34:14 +05:00
mempool_packages.py test: use getmempoolentry instead of getrawmempool in functional tests when appropriate 2021-08-16 18:29:07 +05:00
mempool_persist.py rpc: Return total fee in mempool 2021-01-28 10:43:22 +01:00
mempool_reorg.py scripted-diff: Rename recentRejects 2021-07-20 13:14:32 +01:00
mempool_resurrect.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
mempool_spend_coinbase.py test: Speed up mempool_spend_coinbase.py 2021-04-23 09:56:02 +02:00
mempool_unbroadcast.py Merge bitcoin/bitcoin#22741: test: Add generate* calls to test framework 2021-08-24 16:22:30 +08:00
mempool_updatefromblock.py test: improve mempool_updatefrom efficiency by using getmempoolentry for specific txns 2021-08-16 17:56:28 +05:00
mining_basic.py test: use f-strings in mining_*.py tests 2021-08-18 12:39:20 +08:00
mining_getblocktemplate_longpoll.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
mining_prioritisetransaction.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
p2p_add_connections.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_addr_relay.py Merge bitcoin/bitcoin#22604: p2p, rpc, test: address rate-limiting follow-ups 2021-08-14 13:33:47 +08:00
p2p_addrfetch.py test: add addr-fetch timeout connection coverage in p2p_addrfetch.py 2021-07-28 18:02:02 +02:00
p2p_addrv2_relay.py Randomize the order of addr processing 2021-07-15 12:59:23 -07:00
p2p_blockfilters.py test: Add missing syncwithvalidationinterfacequeue 2021-06-22 19:42:51 +02:00
p2p_blocksonly.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
p2p_compactblocks.py scripted-diff: test: rename `FromHex` to `from_hex` 2021-06-21 14:33:59 +02:00
p2p_compactblocks_hb.py tests: Add test for compact block HB selection 2021-06-10 10:22:13 -04:00
p2p_disconnect_ban.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_dns_seeds.py [test] Test the delay before querying DNS seeds 2021-07-30 11:15:49 -07:00
p2p_dos_header_tree.py scripted-diff: test: rename `FromHex` to `from_hex` 2021-06-21 14:33:59 +02:00
p2p_eviction.py test: introduce `tx_from_hex` helper for tx deserialization 2021-06-21 14:28:05 +02:00
p2p_feefilter.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
p2p_filter.py test: Fix intermittent issue in p2p_addr_relay.py 2021-04-28 08:16:29 +02:00
p2p_fingerprint.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_getaddr_caching.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_getdata.py test: use explicit p2p objects where available 2020-09-26 10:48:54 +02:00
p2p_i2p_ports.py test: ensure I2P ports are handled as expected 2021-07-09 11:19:37 +02:00
p2p_ibd_txrelay.py test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until 2020-07-19 13:37:54 +02:00
p2p_invalid_block.py test: check rejected future block later accepted 2021-06-15 21:35:29 +01:00
p2p_invalid_locator.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_invalid_messages.py test: refactor: remove `hex_str_to_bytes` helper 2021-08-01 19:26:51 +02:00
p2p_invalid_tx.py test, doc: refer to the correct variable names in p2p_invalid_tx.py 2021-08-25 22:55:10 +02:00
p2p_leak.py test: Fix p2p_leak.py intermittent failure by lowering timeout 2021-06-04 22:42:04 +02:00
p2p_leak_tx.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
p2p_message_capture.py test: remove type: comments in favour of actual annotations 2021-02-08 13:24:44 +08:00
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_node_network_limited.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_permissions.py scripted-diff: Rename recentRejects 2021-07-20 13:14:32 +01:00
p2p_ping.py scripted-diff: Rename mininode to p2p 2020-08-21 15:52:20 +01:00
p2p_segwit.py Merge bitcoin/bitcoin#22378: test: remove confusing `MAX_BLOCK_BASE_SIZE` 2021-08-02 15:51:48 +02:00
p2p_sendheaders.py test: Update wait_until usage in tests not to use the one from utils 2020-08-26 18:01:59 +02:00
p2p_timeouts.py net: use peer=N instead of from=N in debug log 2021-01-28 16:04:04 +10:00
p2p_tx_download.py test: introduce `tx_from_hex` helper for tx deserialization 2021-06-21 14:28:05 +02:00
p2p_unrequested_blocks.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
rpc_addresses_deprecation.py test: refactor: remove `hex_str_to_bytes` helper 2021-08-01 19:26:51 +02:00
rpc_bind.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_blockchain.py Set regtest.BIP65Height = 111 to speed up tests 2021-08-26 11:08:24 +02:00
rpc_createmultisig.py test: refactor: remove binascii from test_framework 2021-08-04 19:59:13 +01:00
rpc_decodescript.py test: refactor: remove `hex_str_to_bytes` helper 2021-08-01 19:26:51 +02:00
rpc_deprecated.py Remove deprecated bumpfee behavior 2021-01-08 18:58:58 -05:00
rpc_deriveaddresses.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
rpc_dumptxoutset.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
rpc_estimatefee.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
rpc_fundrawtransaction.py Use waste metric for deciding which selection to use 2021-08-27 12:46:19 -04:00
rpc_generate.py rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining) 2020-08-14 12:37:19 +02:00
rpc_generateblock.py rpc: deprecate `addresses` and `reqSigs` from rpc outputs 2021-03-23 10:51:43 -04:00
rpc_getblockfilter.py test: check that getblockfilter RPC fails without block filter index 2021-01-20 01:55:24 +01:00
rpc_getblockstats.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
rpc_getchaintips.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
rpc_getdescriptorinfo.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_help.py rpc: add external signer RPC files 2021-02-23 14:34:30 +01:00
rpc_invalid_address_message.py Use Bech32m encoding for v1+ segwit addresses 2021-03-16 10:48:36 -07:00
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_misc.py test: assert logging categories are sorted in rpc and help 2021-07-28 12:36:28 +02:00
rpc_named_arguments.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_net.py Merge bitcoin/bitcoin#21989: test: Use COINBASE_MATURITY in functional tests 2021-05-31 11:26:25 +02:00
rpc_packages.py extract/rename helper functions from rpc_packages.py 2021-08-06 10:04:59 +01:00
rpc_preciousblock.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_psbt.py Merge bitcoin/bitcoin#21359: rpc: include_unsafe option for fundrawtransaction 2021-05-10 16:05:23 +02:00
rpc_rawtransaction.py test, refactor: rpc_rawtransaction PEP8 2021-08-31 21:59:51 +02:00
rpc_scantxoutset.py wallet: Make -wallet setting not create wallets 2020-10-21 08:48:43 -04:00
rpc_setban.py style: remove () from assert in rpc_setban.py 2021-06-21 15:29:28 +02:00
rpc_signer.py Move external signer out of wallet module 2021-04-08 17:56:00 +02:00
rpc_signmessagewithprivkey.py test: added test for disabled wallet 2021-08-12 18:14:56 +05:30
rpc_signrawtransaction.py Set regtest.BIP65Height = 111 to speed up tests 2021-08-26 11:08:24 +02:00
rpc_txoutproof.py scripted-diff: test: rename `FromHex` to `from_hex` 2021-06-21 14:33:59 +02:00
rpc_uptime.py util: Disallow negative mocktime 2021-02-02 08:43:19 +00:00
rpc_users.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_whitelist.py test: Change filemode of rpc_whitelist.py 2019-12-27 21:19:44 +01:00
test-shell.md doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
test_runner.py test: added test for disabled wallet 2021-08-12 18:14:56 +05:30
tool_wallet.py Merge #20267: Disable and fix tests for when BDB is not compiled 2021-02-05 14:26:10 +01:00
wallet_abandonconflict.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
wallet_address_types.py wallet: Add error message to GetReservedDestination 2021-06-22 21:57:04 -04:00
wallet_avoidreuse.py wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100 2021-05-18 02:09:18 +02:00
wallet_backup.py Change the wallet_backup.py test to use the restorewallet RPC command instead of restoring wallets manually. 2021-08-10 22:44:54 -03:00
wallet_balance.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
wallet_basic.py refactor: Detach wallet transaction methods (followup for move-only) 2021-09-01 02:22:58 -05:00
wallet_bumpfee.py test: introduce `tx_from_hex` helper for tx deserialization 2021-06-21 14:28:05 +02:00
wallet_coinbase_category.py Test coinbase category in wallet rpcs 2018-12-01 13:00:38 -05:00
wallet_create_tx.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_createwallet.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
wallet_descriptor.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
wallet_disable.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_dump.py tests: Test for dumpwallet lock order issue 2021-07-19 12:25:11 -04:00
wallet_encryption.py doc: fix various typos 2021-01-04 12:31:31 +08:00
wallet_fallbackfee.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
wallet_groups.py test: remove `ToHex` helper, use .serialize().hex() instead 2021-06-21 14:30:03 +02:00
wallet_hd.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
wallet_implicitsegwit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_import_rescan.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_import_with_label.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
wallet_importdescriptors.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
wallet_importmulti.py Disallow bech32m addresses for legacy wallet things 2021-06-22 21:57:04 -04:00
wallet_importprunedfunds.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
wallet_keypool.py wallet: Add error message to GetReservedDestination 2021-06-22 21:57:04 -04:00
wallet_keypool_topup.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
wallet_labels.py Disallow bech32m addresses for legacy wallet things 2021-06-22 21:57:04 -04:00
wallet_listdescriptors.py Merge bitcoin/bitcoin#21500: wallet, rpc: add an option to list private descriptors 2021-08-09 14:09:07 +12:00
wallet_listreceivedby.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_listsinceblock.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
wallet_listtransactions.py test: add logging to wallet_listtransactions 2021-07-16 01:15:49 +02:00
wallet_multiwallet.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
wallet_orphanedreward.py Add sync_blocks in wallet_orphanedreward.py. 2021-06-08 09:52:10 +02:00
wallet_reorgsrestore.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_resendwallettransactions.py test: remove `ToHex` helper, use .serialize().hex() instead 2021-06-21 14:30:03 +02:00
wallet_send.py Merge bitcoin/bitcoin#21359: rpc: include_unsafe option for fundrawtransaction 2021-05-10 16:05:23 +02:00
wallet_signer.py Move external signer out of wallet module 2021-04-08 17:56:00 +02:00
wallet_signmessagewithaddress.py test: added test for disabled wallet 2021-08-12 18:14:56 +05:30
wallet_startup.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_taproot.py Merge bitcoin/bitcoin#22154: Add OutputType::BECH32M and related wallet support for fetching bech32m addresses 2021-06-24 14:20:28 +02:00
wallet_txn_clone.py test: introduce `tx_from_hex` helper for tx deserialization 2021-06-21 14:28:05 +02:00
wallet_txn_doublespend.py test: Remove unused bug workaround 2021-02-16 16:28:40 +01:00
wallet_upgradewallet.py Test that descriptor wallet upgrade does nothing 2021-07-16 15:34:56 -04:00
wallet_watchonly.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00

README.md

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: