Merge branch 'fix-next-video' of git://github.com/mauriciocolli/NewPipe into strfx

Fix list in readme

.travis.yml

@@ -11,29 +11,9 @@ android:
     - android-25
 
     # Additional components
-    - extra-android-support
     - extra-android-m2repository
-    - extra-google-m2repository
 
-    # Emulators
-    - sys-img-armeabi-v7a-android-21
-    - sys-img-armeabi-v7a-android-19
-    - sys-img-armeabi-v7a-android-15
-
-env:
-  global:
-    - ADB_INSTALL_TIMEOUT=8 # minutes (2 by default)
-    - GRADLE_OPTS=-Xmx512m # give gradle more memory since it seem to fail otherwise
-  matrix:
-    - ANDROID_TARGET=android-21  ANDROID_ABI=armeabi-v7a
-
-before_script:
-  - echo no | android create avd --force -n test -t $ANDROID_TARGET --abi $ANDROID_ABI
-  - emulator -avd test -no-skin -no-audio -no-window &
-  - android-wait-for-emulator
-  - adb shell input keyevent 82 &
-
-script: ./gradlew --info build connectedCheck
+script: ./gradlew -Dorg.gradle.jvmargs=-Xmx1536m assembleDebug lintDebug testDebugUnitTest
 
 licenses:
   - '.+'

README.md

@@ -37,23 +37,27 @@ NewPipe does not use any Google framework libraries, or the YouTube API. It only
 * Listen to YouTube videos (experimental)
 * Select the streaming player to watch the video with
 * Download videos 
-* Download audio only * Open a video in Kodi
+* Download audio only
+* Open a video in Kodi
 * Show Next/Related videos
 * Search YouTube in a specific language
 * Watch age restricted material
 * Display general information about channels
 * Search channels
+* Watch videos from a channel
+* Orbot/Tor support (not yet directly)
 
 ### Coming Features
 
-* Orbot/Tor support
 * Bookmarks
 * View history
 * Search history
 * Subscribe to channels
-* Watch videos from a channel
 * Search/Watch Playlists
 * Queeing videos
+* Subtitles support
+* 1080p support
+* livestream support
 * ... and many more
 
 ### Multiservice support

app/build.gradle

@@ -8,8 +8,8 @@ android {
         applicationId "org.schabi.newpipe"
         minSdkVersion 15
         targetSdkVersion 25
-        versionCode 26
-        versionName "0.8.12"
+        versionCode 27
+        versionName "0.9.0"
     }
     buildTypes {
         release {
@@ -32,6 +32,9 @@ android {
 
 dependencies {
     testCompile 'junit:junit:4.12'
+    testCompile 'org.mockito:mockito-core:1.10.19'
+    testCompile 'org.json:json:20160810'
+
     compile 'com.android.support:appcompat-v7:25.1.0'
     compile 'com.android.support:support-v4:25.1.0'
     compile 'com.android.support:design:25.1.0'
@@ -45,8 +48,5 @@ dependencies {
     compile 'com.google.code.gson:gson:2.4'
     compile 'com.nononsenseapps:filepicker:3.0.0'
     compile 'ch.acra:acra:4.9.0'
-    compile 'com.devbrackets.android:exomedia:3.1.1'
-    testCompile 'junit:junit:4.12'
-    testCompile 'org.mockito:mockito-core:1.10.19'
-    testCompile 'org.json:json:20160810'
+    compile 'com.google.android.exoplayer:exoplayer:r2.3.1'
 }

app/src/main/AndroidManifest.xml

@@ -51,24 +51,7 @@
             android:configChanges="keyboard|keyboardHidden|orientation|screenSize"
             android:label="@string/app_name"
             android:launchMode="singleInstance"
-            android:theme="@style/PlayerTheme">
-            <intent-filter>
-                <action android:name="org.schabi.newpipe.exoplayer.action.VIEW" />
-
-                <category android:name="android.intent.category.DEFAULT" />
-
-                <data android:scheme="http" />
-                <data android:scheme="https" />
-                <data android:scheme="content" />
-                <data android:scheme="asset" />
-                <data android:scheme="file" />
-            </intent-filter>
-        </activity>
-
-        <service
-            android:name=".player.BackgroundPlayer"
-            android:exported="false"
-            android:label="@string/background_player_name" />
+            android:theme="@style/PlayerTheme"/>
 
         <activity
             android:name=".settings.SettingsActivity"
@@ -138,6 +121,7 @@
                 <data android:host="www.youtube.com" />
                 <!-- video prefix -->
                 <data android:pathPrefix="/v/" />
+                <data android:pathPrefix="/embed/" />
                 <data android:pathPrefix="/watch" />
                 <data android:pathPrefix="/attribution_link" />
                 <!-- channel prefix -->
@@ -179,7 +163,7 @@
 
         <activity android:name=".PopupActivity"
             android:theme="@android:style/Theme.NoDisplay"
-            android:label="NewPipe Popup mode">
+            android:label="@string/popup_mode_share_menu_title">
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
                 <action android:name="android.media.action.MEDIA_PLAY_FROM_SEARCH" />
@@ -195,6 +179,7 @@
                 <data android:host="www.youtube.com" />
                 <!-- video prefix -->
                 <data android:pathPrefix="/v/" />
+                <data android:pathPrefix="/embed/" />
                 <data android:pathPrefix="/watch" />
                 <data android:pathPrefix="/attribution_link" />
                 <!-- channel prefix -->
@@ -238,4 +223,4 @@
 
     </application>
 
-</manifest>
+</manifest>

app/src/main/java/org/schabi/newpipe/ChannelActivity.java

@@ -19,7 +19,7 @@ import android.widget.Toast;
 
 import com.nostra13.universalimageloader.core.ImageLoader;
 
-import org.schabi.newpipe.detail.VideoItemDetailFragment;
+import org.schabi.newpipe.detail.VideoItemDetailActivity;
 import org.schabi.newpipe.extractor.NewPipe;
 import org.schabi.newpipe.extractor.StreamingService;
 import org.schabi.newpipe.extractor.channel.ChannelExtractor;
@@ -31,10 +31,12 @@ import org.schabi.newpipe.info_list.InfoListAdapter;
 import org.schabi.newpipe.report.ErrorActivity;
 import org.schabi.newpipe.settings.SettingsActivity;
 import org.schabi.newpipe.util.NavStack;
-import java.io.IOException;
-import static android.os.Build.VERSION.SDK_INT;
 import org.schabi.newpipe.util.ThemeHelper;
 
+import java.io.IOException;
+
+import static android.os.Build.VERSION.SDK_INT;
+
 
 /**
  * Copyright (C) Christian Schabesberger 2016 <chris.schabesberger@mailbox.org>
@@ -147,6 +149,7 @@ public class ChannelActivity extends AppCompatActivity {
             serviceId = savedInstanceState.getInt(NavStack.SERVICE_ID);
             NavStack.getInstance()
                     .restoreSavedInstanceState(savedInstanceState);
+            handleIntent(getIntent());
         }
 
     }
@@ -298,7 +301,7 @@ public class ChannelActivity extends AppCompatActivity {
                     postNewErrorToast(h, R.string.network_error);
                     ioe.printStackTrace();
                 } catch(ParsingException pe) {
-                    ErrorActivity.reportError(h, ChannelActivity.this, pe, VideoItemDetailFragment.class, null,
+                    ErrorActivity.reportError(h, ChannelActivity.this, pe, VideoItemDetailActivity.class, null,
                             ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_CHANNEL,
                                     service.getServiceInfo().name, channelUrl, R.string.parsing_error));
                     h.post(new Runnable() {
@@ -313,7 +316,7 @@ public class ChannelActivity extends AppCompatActivity {
                     if(service != null) {
                         name = service.getServiceInfo().name;
                     }
-                    ErrorActivity.reportError(h, ChannelActivity.this, ex, VideoItemDetailFragment.class, null,
+                    ErrorActivity.reportError(h, ChannelActivity.this, ex, VideoItemDetailActivity.class, null,
                             ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_CHANNEL,
                                     name, channelUrl, R.string.parsing_error));
                     h.post(new Runnable() {
@@ -324,7 +327,7 @@ public class ChannelActivity extends AppCompatActivity {
                     });
                     ex.printStackTrace();
                 } catch(Exception e) {
-                    ErrorActivity.reportError(h, ChannelActivity.this, e, VideoItemDetailFragment.class, null,
+                    ErrorActivity.reportError(h, ChannelActivity.this, e, VideoItemDetailActivity.class, null,
                             ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_CHANNEL,
                                     service.getServiceInfo().name, channelUrl, R.string.general_error));
                     h.post(new Runnable() {

app/src/main/java/org/schabi/newpipe/RouterActivity.java

@@ -2,14 +2,12 @@ package org.schabi.newpipe;
 
 import android.app.Activity;
 import android.content.Intent;
-import android.preference.PreferenceManager;
-import android.support.v7.app.AppCompatActivity;
 import android.os.Bundle;
+import android.preference.PreferenceManager;
 import android.util.Log;
 import android.widget.Toast;
 
 import org.schabi.newpipe.detail.VideoItemDetailActivity;
-import org.schabi.newpipe.detail.VideoItemDetailFragment;
 import org.schabi.newpipe.extractor.NewPipe;
 import org.schabi.newpipe.extractor.StreamingService;
 import org.schabi.newpipe.util.NavStack;
@@ -136,7 +134,7 @@ public class RouterActivity extends Activity {
                     break;
                 case STREAM:
                     callIntent.setClass(this, VideoItemDetailActivity.class);
-                    callIntent.putExtra(VideoItemDetailFragment.AUTO_PLAY,
+                    callIntent.putExtra(VideoItemDetailActivity.AUTO_PLAY,
                             PreferenceManager.getDefaultSharedPreferences(this)
                                     .getBoolean(
                                             getString(R.string.autoplay_through_intent_key), false));

app/src/main/java/org/schabi/newpipe/detail/StreamExtractorWorker.java

@@ -0,0 +1,250 @@
+package org.schabi.newpipe.detail;
+
+import android.app.Activity;
+import android.os.Handler;
+import android.util.Log;
+import android.view.View;
+
+import org.schabi.newpipe.R;
+import org.schabi.newpipe.extractor.NewPipe;
+import org.schabi.newpipe.extractor.StreamingService;
+import org.schabi.newpipe.extractor.exceptions.ParsingException;
+import org.schabi.newpipe.extractor.exceptions.ReCaptchaException;
+import org.schabi.newpipe.extractor.services.youtube.YoutubeStreamExtractor;
+import org.schabi.newpipe.extractor.stream_info.StreamExtractor;
+import org.schabi.newpipe.extractor.stream_info.StreamInfo;
+import org.schabi.newpipe.report.ErrorActivity;
+
+import java.io.IOException;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+/**
+ * Extract {@link StreamInfo} with {@link StreamExtractor} from the given url of the given service
+ */
+@SuppressWarnings("WeakerAccess")
+public class StreamExtractorWorker extends Thread {
+    private static final String TAG = "StreamExtractorWorker";
+
+    private Activity activity;
+    private final String videoUrl;
+    private final int serviceId;
+    private OnStreamInfoReceivedListener callback;
+
+    private final AtomicBoolean isRunning = new AtomicBoolean(false);
+    private final Handler handler = new Handler();
+
+
+    public interface OnStreamInfoReceivedListener {
+        void onReceive(StreamInfo info);
+        void onError(int messageId);
+        void onReCaptchaException();
+        void onBlockedByGemaError();
+        void onContentErrorWithMessage(int messageId);
+        void onContentError();
+    }
+
+    public StreamExtractorWorker(Activity activity, String videoUrl, int serviceId, OnStreamInfoReceivedListener callback) {
+        this.serviceId = serviceId;
+        this.videoUrl = videoUrl;
+        this.activity = activity;
+        this.callback = callback;
+    }
+
+    /**
+     * Returns a new instance <b>already</b> started  of {@link StreamExtractorWorker}.<br>
+     * The caller is responsible to check if {@link StreamExtractorWorker#isRunning()}, or {@link StreamExtractorWorker#cancel()} it
+     *
+     * @param serviceId id of the request service
+     * @param url       videoUrl of the service (e.g. https://www.youtube.com/watch?v=HyHNuVaZJ-k)
+     * @param activity  activity for error reporting purposes
+     * @param callback  listener that will be called-back when events occur (check {@link OnStreamInfoReceivedListener})
+     * @return new instance already started of {@link StreamExtractorWorker}
+     */
+    public static StreamExtractorWorker startExtractorThread(int serviceId, String url, Activity activity, OnStreamInfoReceivedListener callback) {
+        StreamExtractorWorker extractorThread = getExtractorThread(serviceId, url, activity, callback);
+        extractorThread.start();
+        return extractorThread;
+    }
+
+    /**
+     * Returns a new instance of {@link StreamExtractorWorker}.<br>
+     * The caller is responsible to check if {@link StreamExtractorWorker#isRunning()}, or {@link StreamExtractorWorker#cancel()}
+     * when it doesn't need it anymore
+     * <p>
+     * <b>Note:</b> this instance is <b>not</b> started yet
+     *
+     * @param serviceId id of the request service
+     * @param url       videoUrl of the service (e.g. https://www.youtube.com/watch?v=HyHNuVaZJ-k)
+     * @param activity  activity for error reporting purposes
+     * @param callback  listener that will be called-back when events occur (check {@link OnStreamInfoReceivedListener})
+     * @return instance of {@link StreamExtractorWorker}
+     */
+    public static StreamExtractorWorker getExtractorThread(int serviceId, String url, Activity activity, OnStreamInfoReceivedListener callback) {
+        return new StreamExtractorWorker(activity, url, serviceId, callback);
+    }
+
+    @Override
+    //Just ignore the errors for now
+    @SuppressWarnings("ConstantConditions")
+    public void run() {
+        // TODO: Improve error checking
+        // and this method in general
+
+        StreamInfo streamInfo = null;
+        StreamingService service;
+        try {
+            service = NewPipe.getService(serviceId);
+        } catch (Exception e) {
+            e.printStackTrace();
+            ErrorActivity.reportError(handler, activity, e, VideoItemDetailActivity.class, null,
+                    ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
+                            "", videoUrl, R.string.could_not_get_stream));
+            return;
+        }
+        try {
+            isRunning.set(true);
+            StreamExtractor streamExtractor = service.getExtractorInstance(videoUrl);
+            streamInfo = StreamInfo.getVideoInfo(streamExtractor);
+
+            final StreamInfo info = streamInfo;
+            if (callback != null) handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    callback.onReceive(info);
+                }
+            });
+            isRunning.set(false);
+            // look for errors during extraction
+            // this if statement only covers extra information.
+            // if these are not available or caused an error, they are just not available
+            // but don't render the stream information unusalbe.
+            if (streamInfo != null && !streamInfo.errors.isEmpty()) {
+                Log.e(TAG, "OCCURRED ERRORS DURING EXTRACTION:");
+                for (Throwable e : streamInfo.errors) {
+                    e.printStackTrace();
+                    Log.e(TAG, "------");
+                }
+
+                View rootView = activity != null ? activity.findViewById(R.id.video_item_detail) : null;
+                ErrorActivity.reportError(handler, activity,
+                        streamInfo.errors, null, rootView,
+                        ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
+                                service.getServiceInfo().name, videoUrl, 0 /* no message for the user */));
+            }
+
+            // These errors render the stream information unusable.
+        } catch (ReCaptchaException e) {
+            if (callback != null) handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    callback.onReCaptchaException();
+                }
+            });
+        } catch (IOException e) {
+            if (callback != null) handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    callback.onError(R.string.network_error);
+                }
+            });
+            if (callback != null) e.printStackTrace();
+        } catch (YoutubeStreamExtractor.DecryptException de) {
+            // custom service related exceptions
+            ErrorActivity.reportError(handler, activity, de, VideoItemDetailActivity.class, null,
+                    ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
+                            service.getServiceInfo().name, videoUrl, R.string.youtube_signature_decryption_error));
+            handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    activity.finish();
+                }
+            });
+            de.printStackTrace();
+        } catch (YoutubeStreamExtractor.GemaException ge) {
+            if (callback != null) handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    callback.onBlockedByGemaError();
+                }
+            });
+        } catch (YoutubeStreamExtractor.LiveStreamException e) {
+            if (callback != null) handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    callback.onContentErrorWithMessage(R.string.live_streams_not_supported);
+                }
+            });
+        }
+        // ----------------------------------------
+        catch (StreamExtractor.ContentNotAvailableException e) {
+            if (callback != null) handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    callback.onContentError();
+                }
+            });
+            e.printStackTrace();
+        } catch (StreamInfo.StreamExctractException e) {
+            if (!streamInfo.errors.isEmpty()) {
+                // !!! if this case ever kicks in someone gets kicked out !!!
+                ErrorActivity.reportError(handler, activity, e, VideoItemDetailActivity.class, null,
+                        ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
+                                service.getServiceInfo().name, videoUrl, R.string.could_not_get_stream));
+            } else {
+                ErrorActivity.reportError(handler, activity, streamInfo.errors, VideoItemDetailActivity.class, null,
+                        ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
+                                service.getServiceInfo().name, videoUrl, R.string.could_not_get_stream));
+            }
+            handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    activity.finish();
+                }
+            });
+            e.printStackTrace();
+        } catch (ParsingException e) {
+            ErrorActivity.reportError(handler, activity, e, VideoItemDetailActivity.class, null,
+                    ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
+                            service.getServiceInfo().name, videoUrl, R.string.parsing_error));
+            handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    activity.finish();
+                }
+            });
+            e.printStackTrace();
+        } catch (Exception e) {
+            ErrorActivity.reportError(handler, activity, e, VideoItemDetailActivity.class, null,
+                    ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
+                            service.getServiceInfo().name, videoUrl, R.string.general_error));
+            handler.post(new Runnable() {
+                @Override
+                public void run() {
+                    activity.finish();
+                }
+            });
+            e.printStackTrace();
+        }
+    }
+
+    /**
+     * Return true if the extraction is not completed yet
+     *
+     * @return the value of the AtomicBoolean {@link #isRunning}
+     */
+    public boolean isRunning() {
+        return isRunning.get();
+    }
+
+    /**
+     * Cancel this ExtractorThread, setting the callback to null, the AtomicBoolean {@link #isRunning} to false and interrupt this thread.
+     * <p>
+     * <b>Note:</b> Any I/O that is active in the moment that this method is called will be canceled and a Exception will be thrown, because of the {@link #interrupt()}.<br>
+     * This is useful when you don't want the resulting {@link StreamInfo} anymore, but don't want to waste bandwidth, otherwise it'd run till it receives the StreamInfo.
+     */
+    public void cancel() {
+        this.callback = null;
+        this.isRunning.set(false);
+        this.interrupt();
+    }
+}

app/src/main/java/org/schabi/newpipe/detail/StreamInfoWorker.java

@@ -1,230 +0,0 @@
-package org.schabi.newpipe.detail;
-
-import android.app.Activity;
-import android.os.Handler;
-import android.util.Log;
-import android.view.View;
-
-import org.schabi.newpipe.extractor.exceptions.ParsingException;
-import org.schabi.newpipe.extractor.exceptions.ReCaptchaException;
-import org.schabi.newpipe.extractor.stream_info.StreamExtractor;
-import org.schabi.newpipe.extractor.stream_info.StreamInfo;
-import org.schabi.newpipe.report.ErrorActivity;
-import org.schabi.newpipe.R;
-import org.schabi.newpipe.extractor.NewPipe;
-import org.schabi.newpipe.extractor.StreamingService;
-import org.schabi.newpipe.extractor.services.youtube.YoutubeStreamExtractor;
-
-import java.io.IOException;
-
-/**
- * Created by Christian Schabesberger on 02.08.16.
- *
- * Copyright (C) Christian Schabesberger 2016 <chris.schabesberger@mailbox.org>
- * StreamInfoWorker.java is part of NewPipe.
- *
- * NewPipe is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * NewPipe is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with NewPipe.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-public class StreamInfoWorker {
-
-    private static final String TAG = StreamInfoWorker.class.toString();
-
-    public interface OnStreamInfoReceivedListener {
-        void onReceive(StreamInfo info);
-        void onError(int messageId);
-        void onReCaptchaException();
-        void onBlockedByGemaError();
-        void onContentErrorWithMessage(int messageId);
-        void onContentError();
-    }
-
-    private class StreamExtractorRunnable implements Runnable {
-        private final Handler h = new Handler();
-        private StreamExtractor streamExtractor;
-        private final int serviceId;
-        private final String videoUrl;
-        private Activity a;
-
-        public StreamExtractorRunnable(Activity a, String videoUrl, int serviceId) {
-            this.serviceId = serviceId;
-            this.videoUrl = videoUrl;
-            this.a = a;
-        }
-
-        @Override
-        public void run() {
-            StreamInfo streamInfo = null;
-            StreamingService service = null;
-            try {
-                service = NewPipe.getService(serviceId);
-            } catch (Exception e) {
-                e.printStackTrace();
-                ErrorActivity.reportError(h, a, e, VideoItemDetailFragment.class, null,
-                        ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
-                                "", videoUrl, R.string.could_not_get_stream));
-                return;
-            }
-            try {
-                streamExtractor = service.getExtractorInstance(videoUrl);
-                streamInfo = StreamInfo.getVideoInfo(streamExtractor);
-
-                final StreamInfo info = streamInfo;
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        onStreamInfoReceivedListener.onReceive(info);
-                    }
-                });
-
-                // look for errors during extraction
-                // this if statement only covers extra information.
-                // if these are not available or caused an error, they are just not available
-                // but don't render the stream information unusalbe.
-                if(streamInfo != null &&
-                        !streamInfo.errors.isEmpty()) {
-                    Log.e(TAG, "OCCURRED ERRORS DURING EXTRACTION:");
-                    for (Throwable e : streamInfo.errors) {
-                        e.printStackTrace();
-                        Log.e(TAG, "------");
-                    }
-
-                    View rootView = a != null ? a.findViewById(R.id.video_item_detail) : null;
-                    ErrorActivity.reportError(h, a,
-                            streamInfo.errors, null, rootView,
-                            ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
-                                    service.getServiceInfo().name, videoUrl, 0 /* no message for the user */));
-                }
-
-                // These errors render the stream information unusable.
-            } catch (ReCaptchaException e) {
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        onStreamInfoReceivedListener.onReCaptchaException();
-                    }
-                });
-            } catch (IOException e) {
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        onStreamInfoReceivedListener.onError(R.string.network_error);
-                    }
-                });
-                e.printStackTrace();
-            } catch (YoutubeStreamExtractor.DecryptException de) {
-                // custom service related exceptions
-                ErrorActivity.reportError(h, a, de, VideoItemDetailFragment.class, null,
-                        ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
-                                service.getServiceInfo().name, videoUrl, R.string.youtube_signature_decryption_error));
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        a.finish();
-                    }
-                });
-                de.printStackTrace();
-            } catch (YoutubeStreamExtractor.GemaException ge) {
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        onStreamInfoReceivedListener.onBlockedByGemaError();
-                    }
-                });
-            } catch(YoutubeStreamExtractor.LiveStreamException e) {
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        onStreamInfoReceivedListener
-                                .onContentErrorWithMessage(R.string.live_streams_not_supported);
-                    }
-                });
-            }
-            // ----------------------------------------
-            catch(StreamExtractor.ContentNotAvailableException e) {
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        onStreamInfoReceivedListener
-                                .onContentError();
-                    }
-                });
-                e.printStackTrace();
-            } catch(StreamInfo.StreamExctractException e) {
-                if(!streamInfo.errors.isEmpty()) {
-                    // !!! if this case ever kicks in someone gets kicked out !!!
-                    ErrorActivity.reportError(h, a, e, VideoItemDetailFragment.class, null,
-                            ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
-                                    service.getServiceInfo().name, videoUrl, R.string.could_not_get_stream));
-                } else {
-                    ErrorActivity.reportError(h, a, streamInfo.errors, VideoItemDetailFragment.class, null,
-                            ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
-                                    service.getServiceInfo().name, videoUrl, R.string.could_not_get_stream));
-                }
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        a.finish();
-                    }
-                });
-                e.printStackTrace();
-            } catch (ParsingException e) {
-                ErrorActivity.reportError(h, a, e, VideoItemDetailFragment.class, null,
-                        ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
-                                service.getServiceInfo().name, videoUrl, R.string.parsing_error));
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        a.finish();
-                    }
-                });
-                e.printStackTrace();
-            } catch(Exception e) {
-                ErrorActivity.reportError(h, a, e, VideoItemDetailFragment.class, null,
-                        ErrorActivity.ErrorInfo.make(ErrorActivity.REQUESTED_STREAM,
-                                service.getServiceInfo().name, videoUrl, R.string.general_error));
-                h.post(new Runnable() {
-                    @Override
-                    public void run() {
-                        a.finish();
-                    }
-                });
-                e.printStackTrace();
-            }
-        }
-    }
-
-    private static StreamInfoWorker streamInfoWorker = null;
-    private StreamExtractorRunnable runnable = null;
-    private OnStreamInfoReceivedListener onStreamInfoReceivedListener = null;
-
-    private StreamInfoWorker() {
-
-    }
-
-    public static StreamInfoWorker getInstance() {
-        return streamInfoWorker == null ? (streamInfoWorker = new StreamInfoWorker()) : streamInfoWorker;
-    }
-
-    public void search(int serviceId, String url, Activity a) {
-        runnable = new StreamExtractorRunnable(a, url, serviceId);
-        Thread thread = new Thread(runnable);
-        thread.start();
-    }
-
-    public void setOnStreamInfoReceivedListener(
-            OnStreamInfoReceivedListener onStreamInfoReceivedListener) {
-        this.onStreamInfoReceivedListener = onStreamInfoReceivedListener;
-    }
-}

app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java

@@ -26,7 +26,6 @@ import org.schabi.newpipe.ActivityCommunicator;
 import org.schabi.newpipe.BuildConfig;
 import org.schabi.newpipe.R;
 import org.schabi.newpipe.detail.VideoItemDetailActivity;
-import org.schabi.newpipe.detail.VideoItemDetailFragment;
 import org.schabi.newpipe.util.NavStack;
 
 import java.io.IOException;
@@ -343,7 +342,7 @@ public class BackgroundPlayer extends Service /*implements MediaPlayer.OnPrepare
 
             /*
             NotificationCompat.Action pauseButton = new NotificationCompat.Action.Builder
-                    (R.drawable.ic_pause_white_24dp, "Pause", playPI).build();
+                    (R.drawable.ic_pause_white, "Pause", playPI).build();
             */
 
             PendingIntent playPI = PendingIntent.getBroadcast(owner, noteID,
@@ -465,7 +464,7 @@ public class BackgroundPlayer extends Service /*implements MediaPlayer.OnPrepare
                 RemoteViews views = getContentView(), bigViews = getBigContentView();
                 int imageSrc;
                 if(isPlaying) {
-                    imageSrc = R.drawable.ic_pause_white_24dp;
+                    imageSrc = R.drawable.ic_pause_white;
                 } else {
                     imageSrc = R.drawable.ic_play_circle_filled_white_24dp;
                 }

app/src/main/java/org/schabi/newpipe/player/PlayVideoActivity.java

@@ -5,9 +5,8 @@ import android.content.Intent;
 import android.content.SharedPreferences;
 import android.content.pm.ActivityInfo;
 import android.content.res.Configuration;
-import android.graphics.drawable.Drawable;
-import android.media.MediaPlayer;
 import android.media.AudioManager;
+import android.media.MediaPlayer;
 import android.net.Uri;
 import android.os.Build;
 import android.os.Bundle;
@@ -28,7 +27,6 @@ import android.widget.MediaController;
 import android.widget.ProgressBar;
 import android.widget.VideoView;
 
-import org.schabi.newpipe.App;
 import org.schabi.newpipe.R;
 
 /**

app/src/main/java/org/schabi/newpipe/player/StateInterface.java

@@ -1,8 +1,9 @@
-package org.schabi.newpipe.player.popup;
+package org.schabi.newpipe.player;
 
 public interface StateInterface {
     int STATE_LOADING = 123;
-    int STATE_PLAYING = 125;
+    int STATE_PLAYING = 124;
+    int STATE_BUFFERING = 125;
     int STATE_PAUSED = 126;
     int STATE_PAUSED_SEEK = 127;
     int STATE_COMPLETED = 128;
@@ -11,6 +12,7 @@ public interface StateInterface {
 
     void onLoading();
     void onPlaying();
+    void onBuffering();
     void onPaused();
     void onPausedSeek();
     void onCompleted();

app/src/main/java/org/schabi/newpipe/player/popup/PopupViewHolder.java

@@ -1,93 +0,0 @@
-package org.schabi.newpipe.player.popup;
-
-import android.graphics.Color;
-import android.graphics.PorterDuff;
-import android.os.Build;
-import android.view.View;
-import android.widget.ImageView;
-import android.widget.LinearLayout;
-import android.widget.SeekBar;
-import android.widget.TextView;
-
-import com.devbrackets.android.exomedia.ui.widget.EMVideoView;
-
-import org.schabi.newpipe.R;
-
-public class PopupViewHolder {
-    private View rootView;
-    private EMVideoView videoView;
-    private View loadingPanel;
-    private ImageView endScreen;
-    private ImageView controlAnimationView;
-    private LinearLayout controlsRoot;
-    private SeekBar playbackSeekBar;
-    private TextView playbackCurrentTime;
-    private TextView playbackEndTime;
-
-    public PopupViewHolder(View rootView) {
-        if (rootView == null) return;
-        this.rootView = rootView;
-        this.videoView = (EMVideoView) rootView.findViewById(R.id.popupVideoView);
-        this.loadingPanel = rootView.findViewById(R.id.loadingPanel);
-        this.endScreen = (ImageView) rootView.findViewById(R.id.endScreen);
-        this.controlAnimationView = (ImageView) rootView.findViewById(R.id.controlAnimationView);
-        this.controlsRoot = (LinearLayout) rootView.findViewById(R.id.playbackControlRoot);
-        this.playbackSeekBar = (SeekBar) rootView.findViewById(R.id.playbackSeekBar);
-        this.playbackCurrentTime = (TextView) rootView.findViewById(R.id.playbackCurrentTime);
-        this.playbackEndTime = (TextView) rootView.findViewById(R.id.playbackEndTime);
-        doModifications();
-    }
-
-    private void doModifications() {
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) playbackSeekBar.getThumb().setColorFilter(Color.RED, PorterDuff.Mode.SRC_IN);
-        playbackSeekBar.getProgressDrawable().setColorFilter(Color.RED, PorterDuff.Mode.MULTIPLY);
-    }
-
-    public boolean isControlsVisible() {
-        return controlsRoot != null && controlsRoot.getVisibility() == View.VISIBLE;
-    }
-
-    public boolean isVisible(View view) {
-        return view != null && view.getVisibility() == View.VISIBLE;
-    }
-
-    ///////////////////////////////////////////////////////////////////////////
-    // GETTERS
-    ///////////////////////////////////////////////////////////////////////////
-
-    public View getRootView() {
-        return rootView;
-    }
-
-    public EMVideoView getVideoView() {
-        return videoView;
-    }
-
-    public View getLoadingPanel() {
-        return loadingPanel;
-    }
-
-    public ImageView getEndScreen() {
-        return endScreen;
-    }
-
-    public ImageView getControlAnimationView() {
-        return controlAnimationView;
-    }
-
-    public LinearLayout getControlsRoot() {
-        return controlsRoot;
-    }
-
-    public SeekBar getPlaybackSeekBar() {
-        return playbackSeekBar;
-    }
-
-    public TextView getPlaybackCurrentTime() {
-        return playbackCurrentTime;
-    }
-
-    public TextView getPlaybackEndTime() {
-        return playbackEndTime;
-    }
-}

app/src/main/java/org/schabi/newpipe/search_fragment/SearchInfoItemFragment.java

@@ -19,17 +19,14 @@ import android.view.inputmethod.InputMethodManager;
 import android.widget.ProgressBar;
 import android.widget.Toast;
 
-import org.schabi.newpipe.ChannelActivity;
+import org.schabi.newpipe.R;
 import org.schabi.newpipe.ReCaptchaActivity;
 import org.schabi.newpipe.extractor.NewPipe;
 import org.schabi.newpipe.extractor.search.SearchEngine;
 import org.schabi.newpipe.extractor.search.SearchResult;
 import org.schabi.newpipe.info_list.InfoItemBuilder;
-import org.schabi.newpipe.report.ErrorActivity;
-import org.schabi.newpipe.R;
-import org.schabi.newpipe.detail.VideoItemDetailActivity;
-import org.schabi.newpipe.detail.VideoItemDetailFragment;
 import org.schabi.newpipe.info_list.InfoListAdapter;
+import org.schabi.newpipe.report.ErrorActivity;
 import org.schabi.newpipe.util.NavStack;
 
 import java.util.EnumSet;

app/src/main/java/org/schabi/newpipe/util/NavStack.java

@@ -5,13 +5,10 @@ import android.content.Context;
 import android.content.Intent;
 import android.os.Bundle;
 import android.support.v4.app.NavUtils;
-import android.support.v7.app.AppCompatActivity;
-import android.util.Log;
 
 import org.schabi.newpipe.ChannelActivity;
 import org.schabi.newpipe.MainActivity;
 import org.schabi.newpipe.detail.VideoItemDetailActivity;
-import org.schabi.newpipe.detail.VideoItemDetailFragment;
 import org.schabi.newpipe.extractor.NewPipe;
 import org.schabi.newpipe.extractor.StreamingService;
 

app/src/main/java/org/schabi/newpipe/util/ThemeHelper.java

@@ -7,18 +7,21 @@ import org.schabi.newpipe.R;
 
 public class ThemeHelper {
 
-    public static void setTheme(Context context, boolean mode) {
-        // mode is true for normal theme, false for no action bar theme.
-
+    /**
+     * Apply the selected theme (on NewPipe settings) in the context
+     *
+     * @param context               context that the theme will be applied
+     * @param useActionbarTheme     whether to use an action bar theme or not
+     */
+    public static void setTheme(Context context, boolean useActionbarTheme) {
         String themeKey = context.getString(R.string.theme_key);
-        //String lightTheme = context.getResources().getString(R.string.light_theme_title);
         String darkTheme = context.getResources().getString(R.string.dark_theme_title);
         String blackTheme = context.getResources().getString(R.string.black_theme_title);
 
         String sp = PreferenceManager.getDefaultSharedPreferences(context)
                 .getString(themeKey, context.getResources().getString(R.string.light_theme_title));
 
-        if (mode) {
+        if (useActionbarTheme) {
             if (sp.equals(darkTheme)) context.setTheme(R.style.DarkTheme);
             else if (sp.equals(blackTheme)) context.setTheme(R.style.BlackTheme);
             else context.setTheme(R.style.AppTheme);