videolan
/
x264
mirror of https://code.videolan.org/videolan/x264
1
Fork 0
Code Releases Activity

Fix undefined behavior: division by zero

This commit is contained in:
Anton Mitrofanov 2020-03-01 13:38:46 +03:00
parent cc9d9e325e
commit d2833a49f4
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
encoder/slicetype.c
View File

@ -297,12 +297,21 @@ void x264_weights_analyse( x264_t *h, x264_frame_t *fenc, x264_frame_t *ref, int
float ref_mean[3];
for( int plane = 0; plane <= 2*!b_lookahead; plane++ )
{
int zero_bias = !ref->i_pixel_ssd[plane];
float fenc_var = fenc->i_pixel_ssd[plane] + zero_bias;
float ref_var = ref->i_pixel_ssd[plane] + zero_bias;
guess_scale[plane] = sqrtf( fenc_var / ref_var );
fenc_mean[plane] = (float)(fenc->i_pixel_sum[plane] + zero_bias) / (fenc->i_lines[!!plane] * fenc->i_width[!!plane]) / (1 << (BIT_DEPTH - 8));
ref_mean[plane] = (float)( ref->i_pixel_sum[plane] + zero_bias) / (fenc->i_lines[!!plane] * fenc->i_width[!!plane]) / (1 << (BIT_DEPTH - 8));
if( !plane || CHROMA_FORMAT )
{
int zero_bias = !ref->i_pixel_ssd[plane];
float fenc_var = fenc->i_pixel_ssd[plane] + zero_bias;
float ref_var = ref->i_pixel_ssd[plane] + zero_bias;
guess_scale[plane] = sqrtf( fenc_var / ref_var );
fenc_mean[plane] = (float)(fenc->i_pixel_sum[plane] + zero_bias) / (fenc->i_lines[!!plane] * fenc->i_width[!!plane]) / (1 << (BIT_DEPTH - 8));
ref_mean[plane] = (float)( ref->i_pixel_sum[plane] + zero_bias) / (fenc->i_lines[!!plane] * fenc->i_width[!!plane]) / (1 << (BIT_DEPTH - 8));
}
else
{
guess_scale[plane] = 1;
fenc_mean[plane] = 0;
ref_mean[plane] = 0;
}
}
int chroma_denom = 7;