_stricmp a Windows thing that is present in all the CRT, even in UCRT.
The stricmp() deprecated variant doesn't seem to exist elsewhere.
In some configuration it's not possible to link with stricmp() even though
_stricmp() is available.
${ac_cv_ld_bsymbolic} is a linker flag, and not a library to link, so
that should have been VLC_ADD_LDFLAGS. Similarly, ${X262_LIBS} are
linker flags to link a library, so that should have been VLC_ADD_LIBS.
With a proper C11 compiler we don't need this. Either they activate C11
things in the compiler which should be there anyway. Or in the SDK
which is __USE_MINGW_ANSI_STDIO for C99 and nothing else.
Any decent Windows SDK (and all mingw-w64 we support) will map the
_WIN32_IE value to the minimum OS selected. We build for Windows 7
which should use 0x0601 anyway.
Previously the wglew.h check would only be done when directx is enabled,
but when disabled, other OpenGL modules are still enabled and these
would break without the GL/wglew.h include, which would never be done
because HAVE_GL_WGLEW_H would not be defined.
In the CI the path is in a wine location. If we build WIX in contribs, we can
use that path instead.
We default to the contrib path unless set by the user.
winepath, wslpath and cygpath have a compatible syntax (at least -w and -u).
They should be used depending on what is available in the build environment
rather than hardcoding "wine winepath".
By default packaged files (Windows, Mac) are build in <top_build>/vlc-4.0.0-dev.
This allows setting a different directory which might avoid some copies when
building into a third party project.
I want to start using the pl_opengl integration, so we need to slightly
revise the check to ensure we also have the libplaceo opengl header
available.
It's worth pointing out that these headers eventually become
non-conditional (in libplacebo git master as of writing), but we need to
live with this transitional logic until then.
In the contribs we
* check that HOST-protoc has the same version as protobuf
otherwise
* check that protoc has the same version as protobuf
AC_CHECK_TOOL() only tests one version of protoc for the protobuf matching.
Since VLC 3.0.x, VA-API no longer forcefully depends on libavcodec, even
if it is not particularly useful without it.
In fact, if libva is present, libavcodec absent, and the build system
already gladly builds VA support minus the libavcodec plugin.
Older versions of mingw had only the simplified variants, but the official SDK
doesn't use these so we should use the prefix ones.
Do the same type of check for __x_ABI_CWindows_CStorage_CIApplicationData2
We require mingw 8+ to make UAP/UWP builds.
That's where our contribs put the headers. That's also where the libmpcdec
headers are in Debian which has a newer revision than our contribs (r495 vs
r481).
Steve Lhomme