Commit Graph

9 Commits

Author SHA1 Message Date
Rémi Denis-Courmont cc129a71d7 Remove old mail address from sources 2019-09-04 22:11:04 +03:00
Hugo Beauzée-Luyssen 2873288c7c upnp: Fix potential race during tear down.
If two threads call UpnpFinish at the same time (or more precisely, if a
2nd thread calls UpnpFinish before the first one sets UpnpSdkInit to 0)
we can end up double releasing most libupnp resources
2019-08-08 11:50:19 +02:00
Hugo Beauzée-Luyssen bf1d25097c upnp-wrapper: Minor simplifications 2018-11-21 15:12:45 +01:00
Hugo Beauzée-Luyssen a8249ee42b upnp: Fix race condition when invoking callbacks 2018-11-21 15:12:45 +01:00
Shaleen Jain d49fa572b2 upnp: do not pass the upnp instance as user data
UPNP SDK functions cannot be called from the registered
callback so there is no point in passing an instance of
upnp instance to the callback as a user data.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
2018-10-28 11:21:40 +01:00
Shaleen Jain 92f2a45aab upnp: fix headers
Header files should be self-contained and should not have
to adhere to special conditions or include order to include the header.
Also add a header guard

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
2018-10-28 11:21:40 +01:00
Hugo Beauzée-Luyssen 7f51eb6cff upnp: Fix windows build 2018-06-29 14:14:22 +02:00
Shaleen Jain 902b94fcc3 upnp: include config.h from source files
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
2018-06-29 13:21:12 +02:00
Shaleen Jain da4e3c45c0 upnp: move UpnpInstanceWrapper to upnp-wrapper
Move out UpnpInstanceWrapper into its own file
since it no longer has any dependencies on existing
modules and allow other modules to get references to it.
Move as well as the various helper functions that are
directly required by the UpnpInstanceWrapper class
and inline them for a small performance gain.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
2018-06-29 13:19:41 +02:00