stream_latency_cb() is needed to re-calculate the new derrered time (or start
late in the worst case scenario) when the audio device latency changes.
This callback called stream_start() with the first played system date. The
problem is that the delta calculated from stream_start was always late. Using
the last system date seems more logical. Indeed, the delta need to be
calculated from values using the same reference point (and vlc_pa_get_latency()
is calculated from the amount of buffers played).
This issue could be easily reproduced when the first played date was more than
100ms in the future, by using --audio-desync 100 for example.
This issue was not visible in most cases, because the deferred time is small by
default (10ms) and because the stream_latency_cb is often triggered after this
time.
Here are some logs to illustrate this (I added logs that print the played block
pts, the delay since the first play and when the stream_latency_cb is called).
* Logs without this patch when running vlc with "--audio-desync 100":
Play @110959, first play since 0us
[0000617000008d50] pulse audio output warning: cannot synchronize start
[0000617000008d50] pulse audio output warning: deferring start (110903 us)
Play @142466, first play since 493us
[0000617000008d50] pulse audio output warning: deferring start (110460 us)
Play @174193, first play since 766us
[0000617000008d50] pulse audio output warning: deferring start (110188 us)
Play @205943, first play since 1016us
[0000617000008d50] pulse audio output warning: deferring start (109937 us)
Play @237698, first play since 1261us
[0000617000008d50] pulse audio output warning: deferring start (109692 us)
Play @269435, first play since 1524us
[0000617000008d50] pulse audio output warning: deferring start (109430 us)
Play @301150, first play since 1809us
[0000617000008d50] pulse audio output warning: deferring start (109144 us)
Play @332900, first play since 2059us
[0000617000008d50] pulse audio output warning: deferring start (108895 us)
Play @364648, first play since 2311us
[0000617000008d50] pulse audio output warning: deferring start (108643 us)
Play @396354, first play since 2605us
[0000617000008d50] pulse audio output warning: deferring start (108349 us)
Play @428076, first play since 2883us
[0000617000008d50] pulse audio output warning: deferring start (108069 us)
Play @459788, first play since 3171us
[0000617000008d50] pulse audio output warning: deferring start (107783 us)
Play @491531, first play since 3428us
[0000617000008d50] pulse audio output warning: deferring start (107526 us)
Play @523276, first play since 3683us
[0000617000008d50] pulse audio output warning: deferring start (107271 us)
Play @555026, first play since 3933us
[0000617000008d50] pulse audio output warning: deferring start (107020 us)
stream_latency_cb
[0000617000008d50] pulse audio output warning: starting late (-396346 us)
starting since: 27318
[0000617000008d50] pulse audio output warning: started
[0000617000008d50] main audio output warning: playback too early (-78075): down-sampling
* Logs with this patch when running vlc with "--audio-desync 100":
Play @110978, first play since 0us
[000055e7c506d030] pulse audio output warning: cannot synchronize start
[000055e7c506d030] pulse audio output warning: deferring start (110952 us)
Play @142708, first play since 270us
[000055e7c506d030] pulse audio output warning: deferring start (110699 us)
Play @174601, first play since 377us
[000055e7c506d030] pulse audio output warning: deferring start (110597 us)
Play @206446, first play since 532us
[000055e7c506d030] pulse audio output warning: deferring start (110443 us)
Play @238302, first play since 676us
[000055e7c506d030] pulse audio output warning: deferring start (110298 us)
Play @270173, first play since 805us
[000055e7c506d030] pulse audio output warning: deferring start (110151 us)
Play @302008, first play since 970us
[000055e7c506d030] pulse audio output warning: deferring start (110005 us)
Play @333914, first play since 1064us
[000055e7c506d030] pulse audio output warning: deferring start (109911 us)
Play @365818, first play since 1160us
[000055e7c506d030] pulse audio output warning: deferring start (109814 us)
Play @397712, first play since 1266us
[000055e7c506d030] pulse audio output warning: deferring start (109708 us)
Play @429588, first play since 1390us
[000055e7c506d030] pulse audio output warning: deferring start (109584 us)
Play @461489, first play since 1489us
[000055e7c506d030] pulse audio output warning: deferring start (109485 us)
Play @493351, first play since 1627us
[000055e7c506d030] pulse audio output warning: deferring start (109347 us)
Play @525261, first play since 1717us
[000055e7c506d030] pulse audio output warning: deferring start (109257 us)
Play @557173, first play since 1805us
[000055e7c506d030] pulse audio output warning: deferring start (109169 us)
stream_latency_cb
[000055e7c506d030] pulse audio output warning: deferring start (74793 us)
Play @555762, first play since 35216us
[000055e7c506d030] pulse audio output warning: deferring start (75748 us)
Play @587642, first play since 35336us
[000055e7c506d030] pulse audio output warning: deferring start (75637 us)
Play @619520, first play since 35458us
[000055e7c506d030] pulse audio output warning: deferring start (75516 us)
Play @651428, first play since 35550us
[000055e7c506d030] pulse audio output warning: deferring start (75425 us)
Play @683305, first play since 35673us
[000055e7c506d030] pulse audio output warning: deferring start (75302 us)
Play @715187, first play since 35791us
[000055e7c506d030] pulse audio output warning: deferring start (75183 us)
Play @747067, first play since 35911us
[000055e7c506d030] pulse audio output warning: deferring start (75063 us)
Play @778930, first play since 36048us
[000055e7c506d030] pulse audio output warning: deferring start (74926 us)
stream_latency_cb
[000055e7c506d030] pulse audio output warning: deferring start (34708 us)
[000055e7c506d030] pulse audio output warning: starting deferred
starting since: 79393
[000055e7c506d030] pulse audio output warning: started
You can see, with this patch, that the resampler is not triggered anymore and
that the stream really start after 100ms (79393 + pulse latency).
In both case, audio and video have the same delay, but in the first case,
the core had to correct it (by playing silence or with the resampler).
Allow discovery of chromecast devices with the Avahi DNS-SD resolver.
Tested with a Chromecast version 2 (Audio/Video).
See: #19921https://forum.videolan.org/viewtopic.php?t=146211
Signed-off-by: Thomas Guillem <thomas@gllm.fr>
Instead of passing the services_discovery_t as userdata for the callbacks,
use a struct discovery_sys_t which is common for both the input and renderer
private data structures.
The discovery_sys_t is embedded into the service type specific private
member structs, i.e. struct services_discovery_sys_t (done here) and
struct vlc_renderer_discovery_sys (next patch).
Signed-off-by: Thomas Guillem <thomas@gllm.fr>
name is only set for AVAHI_BROWSER_NEW and AVAHI_BROWSER_REMOVE. Explicitly
check for REMOVE instead of deducing the event type from the name being
set.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>
Failing to initialize would not release the allocated self instance,
causing it to leak. Instead of the super dealloc just call release
on ourselves, this simplifies error handling too as dealloc takes
care of destroying the mutex and condition variables.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>
Return early when setCurrentContext fails, this simplifies
the following code and makes it much easier to read.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>
This provides bug compatibility with the SDI stream output and, on
error, the transcode stream output, which were incorrectly passing
a non-NULL first parameter to aout_FiltersDelete().
The following commit broke compilation of the decklink modules on
OSX, since CFStringRef is already const.
commit 651c58b9b4
Author: Marvin Scholz <epirat07@gmail.com>
Date: Mon Oct 22 09:27:21 2018 +0200
Decklink: Use typedef instead of macro
Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
Signed-off-by: Marvin Scholz <epirat07@gmail.com>
On EOF, the sout can receive one last block, the drained one. In that case,
GetSubId() will fail since the sout chain is already stopped (in order to
drain). The decoder_t error state was set to true in that case, and next flush
calls were ignored.
Yes, this is an other hack and the chromecast is always dropping the last
drained buffer (it was already the case before). For the moment, I can't find a
proper solution without modyfing heavily the demux filter API (so no 3.0
backport).
hw/vaapi/filters.c:296:9: warning: variable 'pipeline_buf' is used uninitialized whenever 'if' condition is true
[-Wsometimes-uninitialized]
if (vlc_vaapi_BeginPicture(VLC_OBJECT(filter),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/vaapi/filters.c:344:9: note: uninitialized use occurs here
if (pipeline_buf != VA_INVALID_ID)
^~~~~~~~~~~~
hw/vaapi/filters.c:296:5: note: remove the 'if' if its condition is always false
if (vlc_vaapi_BeginPicture(VLC_OBJECT(filter),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/vaapi/filters.c:292:9: warning: variable 'pipeline_buf' is used uninitialized whenever 'if' condition is true
[-Wsometimes-uninitialized]
if (vlc_vaapi_UnmapBuffer(VLC_OBJECT(filter),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/vaapi/filters.c:344:9: note: uninitialized use occurs here
if (pipeline_buf != VA_INVALID_ID)
^~~~~~~~~~~~
hw/vaapi/filters.c:292:5: note: remove the 'if' if its condition is always false
if (vlc_vaapi_UnmapBuffer(VLC_OBJECT(filter),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/vaapi/filters.c:285:9: warning: variable 'pipeline_buf' is used uninitialized whenever 'if' condition is true
[-Wsometimes-uninitialized]
if (vlc_vaapi_MapBuffer(VLC_OBJECT(filter), filter_sys->va.dpy,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/vaapi/filters.c:344:9: note: uninitialized use occurs here
if (pipeline_buf != VA_INVALID_ID)
^~~~~~~~~~~~
hw/vaapi/filters.c:285:5: note: remove the 'if' if its condition is always false
if (vlc_vaapi_MapBuffer(VLC_OBJECT(filter), filter_sys->va.dpy,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/vaapi/filters.c:304:5: note: variable 'pipeline_buf' is declared here
VABufferID pipeline_buf = VA_INVALID_ID;
^
9 warnings generated.
Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
Before commit ec61edc0d0 chromecast depended on
vlc_sout_renderer_GetVcodecOption to signal the codec selected to transcode to.
Achieve that by introducing an output parameter where the codec used is
written.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>
