02ffd015fb
test/clock: specify epsilon in the scenario for lowprecision_check
2023-11-11 10:03:27 +00:00
6834df46ba
clock: fix timing report when decreasing the delay
2023-11-11 09:22:33 +00:00
0fa4d351ba
clock: don't include the delay for the master clock
...
If the source is the master, it needs to handle the delay itself by
delaying the playback by the delta returned by vlc_clock_SetDelay() (for
slaves, the return value will be always 0). This is already done by the
audio output, that is sending silence to reach that delta.
The delay was applied 2 times, one time in the audio output and one time
in the clock. Therefore, remove that extra delay.
2023-11-11 09:22:33 +00:00
f58c19a8b4
subpicture: don't call text renderer with no text
...
The text renderers and text to speech module don't produce anything if
there's no text. No need for defensive programming in each module.
2023-11-10 16:28:30 +00:00
8bac00db8c
text_renderer: remove rendundant check on input
...
It's already checked by the caller via SpuRenderText().
2023-11-10 16:28:30 +00:00
622f559f48
subpicture: remove unused subpicture_region_TextMarkRendered
...
We should not transform a text region into a picture region in the same region.
2023-11-10 16:28:30 +00:00
7261e7a01a
freetype: do not use the input region palette
...
The input region is a text region, it should not have a palette. We would
overwrite the input palette with out own values!
subpicture_region_New() takes care of creating a palette if the format
doesn't have one.
2023-11-10 16:28:30 +00:00
fe415420f3
vlc_filter: return a non-text subpicture region when rendering text regions
...
We no longer need to ugly hack that marks the output region as marked
and we don't mix the input and output regions.
2023-11-10 16:28:30 +00:00
569c1d039a
freetype: allocate the YUVP palette early
2023-11-10 16:28:30 +00:00
dd58d1c0ac
win32: build.sh: switch to $() instead of ``
2023-11-10 14:05:07 +00:00
f3dcaf51b1
win32: build.sh: add proper quoting
...
The `test` call expects two values between an operator like `=` and the
output of pkg-config can be null. In that case, no argument is given for
an empty string without proper quoting and test signal an error.
2023-11-10 14:05:07 +00:00
e374f506a1
interrupt: check EINTR for IO operations
...
The definition of read() and write() mandate from their prototype that
the return value and errno must be checked since the syscall can be
interrupted without being processed by a signal:
../../src/misc/interrupt.c: In function 'vlc_poll_i11e_inner':
WARNING : ../../src/misc/interrupt.c:358: 9: ignoring return value of 'read' declared with attribute 'warn_unused_result' [-Wunused-result]
358 | read(fd[0], &dummy, sizeof (dummy));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/misc/interrupt.c: In function 'vlc_poll_i11e_wake':
WARNING : ../../src/misc/interrupt.c:299: 5: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Wunused-result]
299 | write(fd[1], &value, sizeof (value));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In practice, we write and read into an eventfd or a pipe descriptor, and
we only read when poll() notify that a read operation will be
non-blocking, so the interruption can mostly never happen in production,
but it can happen when using different tools, like ones using SIGPROF
for instance.
See also commit 2f2a478740
2023-11-10 13:24:56 +00:00
823d7c3ae5
avcodec: chroma: fix for-loop condition
...
The previous `!= 0` was kept when the replacement to ARRAY_SIZE() was
done. Since <BOOL> != 0 evaluates to <BOOL>, no regression happened
because of that oversight.
Forgotten from 1eed0681cd
2023-11-10 12:17:48 +00:00
6aadea3959
build: add -Werror=format error
...
GCC and Clang can check that the % format strings are used with the proper
types. If they are not that can lead to security issues.
This cannot be added to global CFLAGS as it will issue an error when testing
for asprintf/vasprintf in AC_REPLACE_FUNCS().
2023-11-10 04:51:50 +00:00
203a9520f4
CI: build Android targets with extra compilation checks
2023-11-10 04:51:50 +00:00
aea00fb42b
CI: build WASM target with extra compilation checks
2023-11-10 04:51:50 +00:00
52be67e5fc
package/wasm: add --enable-extra-checks to add extra compilation errors
2023-11-10 04:51:50 +00:00
921c88a2e9
package/snap: build with --enable-extra-checks to add extra compilation errors
2023-11-10 04:51:50 +00:00
922e338e3b
CI: build iOS targets with extra compilation checks
2023-11-10 04:51:50 +00:00
3b6e27008c
package/apple: add --enable-extra-checks to add extra compilation errors
2023-11-10 04:51:50 +00:00
2324eff451
CI: use common error checks in Debian Meson build
2023-11-10 04:51:50 +00:00
fb4dd9195a
CI: use common error checks in Debian build
2023-11-10 04:51:50 +00:00
0f75cbf6b9
extras/package: use --enable-extra-checks instead of local errors
...
We have a common set of errors between all builds.
2023-11-10 04:51:50 +00:00
8f3d984910
meson: add extra_checks do add more compilation errors
...
These are the same options we already use in build scripts.
2023-11-10 04:51:50 +00:00
fded16c5cd
configure: add --enable-extra-checks do add more compilation errors
...
These are the same options we already use in build scripts.
2023-11-10 04:51:50 +00:00
f4fa047342
configure: test CXXFLAGS with the C++ compiler
2023-11-10 04:51:50 +00:00
75d83e3501
vlc_filter: pass the input text region as const
2023-11-09 12:55:09 +00:00
77b7e53190
text_renderer/svg: use the input region to compute the width/height
2023-11-09 12:55:09 +00:00
ea6bf194a0
text_renderer/svg: remove redundant check
...
The same check is done at the beginning of the function.
2023-11-09 12:55:09 +00:00
e8247d8fc8
freetype: separate input and output region internally
2023-11-09 12:55:09 +00:00
e2e4df6826
freetype: position the output region once it's settled
...
The region position is not used when rendering it.
2023-11-09 12:55:09 +00:00
19aba7aefa
freetype: constify line_desc_t parameters
2023-11-09 12:55:09 +00:00
90d4d0ce37
freetype: constify the FT_BBOX parameters
2023-11-09 12:55:09 +00:00
e90cfce365
freetype: avoid passing unused parameters in local functions
...
RenderYUVP and RenderAXYZ are different anyway
2023-11-09 12:55:09 +00:00
b960e0b563
freetype: simplify the video_format_t usage on rendering
2023-11-09 12:55:09 +00:00
49b9a60f21
freetype: pass the draw functions as a const pointer
...
Rather than passing the structure in each function.
2023-11-09 12:55:09 +00:00
6ae0c05535
freetype: fully fix the SAR forwarding
...
cfd849f0e3
2023-11-09 12:55:09 +00:00
5f449148af
dvbsub: fix handling of empty regions to encode
...
Consecutive to 3d610be9f0
2023-11-09 10:40:44 +00:00
f3196c6073
vout_subpicture: document the reason why we overwrite the region position
2023-11-09 10:40:44 +00:00
6c529ae891
vout_subpictures: don't handle the region any longer if it's not rendered
2023-11-09 10:40:44 +00:00
9918faccab
vout_subpictures: fix positioning of subtitles
...
Consecutive to 3d610be9f0
2023-11-09 10:40:44 +00:00
6170c3e5e7
subpicture: fix missing+leaking region in subpicture_NewFromPicture()
...
Consecutive to 3d610be9f0
2023-11-09 10:40:44 +00:00
6cef23c340
macosx: Queue entire parent item child item collection when playlist controller is in repeat mode, appending beginning items to end
...
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-11-09 09:25:54 +00:00
bc71962d9b
macosx: Respect playlist controller library playlist mode setting in VLCLibraryRepresentedItem
...
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-11-09 09:25:54 +00:00
bb8d42ef1e
macosx: Add a menu item to playback menu to enable/disable library playlist mode
...
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-11-09 09:25:54 +00:00
f1d35ebd37
macosx: Add libraryPlaylistMode property to playlist controller
...
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-11-09 09:25:54 +00:00
5a7209e406
macosx: Constify and access by self wherever possible in VLCLibraryAudioDataSource
...
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-11-09 09:25:54 +00:00
27119c64b1
macosx: Properly adapt VLCLibraryAudioDataSource to VLCMediaLibraryParentGroupType
...
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-11-09 09:25:54 +00:00
1ba45383f8
macosx: Properly handle video media library items in VLCLibraryRepresentedItem
...
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-11-09 09:25:54 +00:00
2eec6c4fd0
macosx: Properly set parent type for represented item in VLCLibraryVideoCollectionViewContainerView
...
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-11-09 09:25:54 +00:00
Thomas Guillem