Rename VLC_EBADVAR to VLC_EINVAL

include/vlc_common.h

@@ -483,7 +483,7 @@ typedef union
 /** Variable not found */
 #define VLC_ENOVAR         (-6)
 /** Bad variable value */
-#define VLC_EBADVAR        (-7)
+#define VLC_EINVAL         (-7)
 /** Item not found */
 #define VLC_ENOITEM        (-8)
 /** Operation forbidden */

modules/access/mms/mmstu.c

@@ -595,7 +595,7 @@ do \
     {\
         var_buffer_free( &buffer );\
         MMSClose( p_access );\
-        return VLC_EBADVAR;\
+        return VLC_EINVAL;\
     }\
     char *str = FromCharset( "UTF-16LE", p, (size) * 2 ); \
     p += (size) * 2; \
@@ -711,7 +711,7 @@ do \
     {
         var_buffer_free( &buffer );
         MMSClose( p_access );
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
 
     /*  1 for file ok, 2 for authen ok */

modules/access/satip.c

@@ -156,7 +156,7 @@ static int parse_port(char *str, uint16_t *port)
 {
     int p = atoi(str);
     if (p < 0 || p > UINT16_MAX)
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
 
     *port = p;
 

modules/demux/mp4/mp4.c

@@ -2532,7 +2532,7 @@ static int xTTS_CountEntries( demux_t *p_demux, uint32_t *pi_entry /* out */,
         if ( i_array_offset >= i_table_count )
         {
             msg_Err( p_demux, "invalid index counting total samples %u %u", i_array_offset,  i_table_count );
-            return VLC_EBADVAR;
+            return VLC_EINVAL;
         }
 
         if ( i_index_samples_left )

modules/gui/macosx/library/VLCLibraryController.m

@@ -141,7 +141,7 @@
         return VLC_EACCES;
     }
     if (!fileURL) {
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
     return vlc_ml_add_folder(_p_libraryInstance, [[fileURL absoluteString] UTF8String]);
 }
@@ -152,7 +152,7 @@
         return VLC_EACCES;
     }
     if (!fileURL) {
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
     return vlc_ml_ban_folder(_p_libraryInstance, [[fileURL absoluteString] UTF8String]);
 }
@@ -163,7 +163,7 @@
         return VLC_EACCES;
     }
     if (!fileURL) {
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
     return vlc_ml_unban_folder(_p_libraryInstance, [[fileURL absoluteString] UTF8String]);
 }
@@ -174,7 +174,7 @@
         return VLC_EACCES;
     }
     if (!fileURL) {
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
     return vlc_ml_remove_folder(_p_libraryInstance, [[fileURL absoluteString] UTF8String]);
 }

modules/gui/macosx/playlist/VLCPlayerController.m

@@ -1718,7 +1718,7 @@ static int BossCallback(vlc_object_t *p_this,
 - (int)enableAudioFilterWithName:(NSString *)name state:(BOOL)state
 {
     if (name == nil || name.length == 0) {
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
 
     return vlc_player_aout_EnableFilter(_p_player, [name UTF8String], state);

modules/gui/macosx/playlist/VLCPlaylistController.m

@@ -423,7 +423,7 @@ static const struct vlc_playlist_callbacks playlist_callbacks = {
 - (int)addInputItem:(input_item_t *)p_inputItem atPosition:(size_t)insertionIndex startPlayback:(BOOL)startPlayback
 {
     if (p_inputItem == NULL) {
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
     int ret = 0;
 

modules/hw/mmal/mmal_picture.c

@@ -535,7 +535,7 @@ int hw_mmal_copy_pic_to_buf(void * const buf_data,
         default:
             if (pLength != NULL)
                 *pLength = 0;
-            return VLC_EBADVAR;
+            return VLC_EINVAL;
     }
 
     if (!is_cma) {  // ** CMA is currently always uncached

modules/hw/vdpau/sharpen.c

@@ -110,7 +110,7 @@ static int Open(filter_t *filter)
     if (vdpau_decoder == NULL)
     {
         vlc_decoder_device_Release(dec_dev);
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
 
     /* Check for sharpen support */

modules/lua/libs/misc.c

@@ -99,7 +99,7 @@ int vlclua_push_ret( lua_State *L, int i_error )
         case VLC_SUCCESS:   err = 0;         break;
         case VLC_ENOMEM:    err = ENOMEM;    break;
         case VLC_ETIMEOUT:  err = ETIMEDOUT; break;
-        case VLC_EBADVAR:   err = EINVAL;    break;
+        case VLC_EINVAL:    err = EINVAL;    break;
         case VLC_ENOMOD:    err = ENOENT;    break;
         case VLC_ENOOBJ:    err = ENOENT;    break;
         case VLC_ENOVAR:    err = ENOENT;    break;

modules/misc/audioscrobbler.c

@@ -493,7 +493,7 @@ static int Handshake(intf_thread_t *p_this)
     {
         free(psz_username);
         free(psz_password);
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
 
     time(&timestamp);
@@ -713,7 +713,7 @@ static void *Run(void *data)
                 case VLC_ENOMEM:
                     goto out;
 
-                case VLC_EBADVAR:
+                case VLC_EINVAL:
                     /* username not set */
                     vlc_dialog_display_error(p_intf,
                         _("Last.fm username not set"),

modules/mux/mpeg/csa.c

@@ -88,7 +88,7 @@ int csa_SetCW( vlc_object_t *p_caller, csa_t *c, char *psz_ck, bool set_odd )
     if( strlen( psz_ck ) != 16 )
     {
         msg_Warn( p_caller, "invalid csa ck (it must be 16 chars long)" );
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
     }
     else
     {

modules/mux/mpeg/ts.c

@@ -801,7 +801,7 @@ static int ActiveKeyCallback( vlc_object_t *p_this, char const *psz_cmd,
     }
 
     if (use_odd < 0)
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
 
     vlc_mutex_lock( &p_sys->csa_lock );
     csa_UseKey( p_this, p_sys->csa, use_odd );

modules/video_output/opengl/renderer.c

@@ -402,7 +402,7 @@ vlc_gl_renderer_SetViewpoint(struct vlc_gl_renderer *renderer,
 {
     if (p_vp->fov > FIELD_OF_VIEW_DEGREES_MAX
             || p_vp->fov < FIELD_OF_VIEW_DEGREES_MIN)
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
 
     // Convert degree into radian
     float f_fovx = p_vp->fov * (float)M_PI / 180.f;

src/misc/addons.c

@@ -531,7 +531,7 @@ static int InstallEntry( addons_manager_t *p_manager, addon_entry_t *p_entry )
     if ( p_entry->e_type == ADDON_UNKNOWN ||
          p_entry->e_type == ADDON_PLUGIN ||
          p_entry->e_type == ADDON_OTHER )
-        return VLC_EBADVAR;
+        return VLC_EINVAL;
 
     vlc_mutex_lock( &p_manager->p_priv->installer.lock );
     ARRAY_APPEND( p_manager->p_priv->installer.entries, p_entry );