videolan/vlc
1
Fork 0
mirror of https://code.videolan.org/videolan/vlc synced 2024-09-28 23:09:59 +02:00
Code Releases Activity

i420_rgb: replace RGB2PIXEL(0,0,0) with 0

Browse Source 
It's clearer to signify the value is 0 (black). We could also use a define
for black.

All the filling of read, green and blue to 0 might be equivalent to a
big memset().

RGB2PIXEL() is only used when shifting is needed.
This commit is contained in:
Steve Lhomme 2023-10-02 09:33:53 +02:00
parent 0fadbab6a6
commit d978097117
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/video_chroma/i420_rgb.c
View File

@ -324,17 +324,17 @@ static void SetYUV( filter_t *p_filter, const video_format_t *vfmt )
p_sys->p_rgb16 = (uint16_t *)p_sys->p_base;
for( unsigned i_index = 0; i_index < RED_MARGIN; i_index++ )
{
p_sys->p_rgb16[RED_OFFSET - RED_MARGIN + i_index] = RGB2PIXEL( 0, 0, 0 );
p_sys->p_rgb16[RED_OFFSET - RED_MARGIN + i_index] = 0;
p_sys->p_rgb16[RED_OFFSET + 256 + i_index] = RGB2PIXEL( 255, 0, 0 );
}
for( unsigned i_index = 0; i_index < GREEN_MARGIN; i_index++ )
{
p_sys->p_rgb16[GREEN_OFFSET - GREEN_MARGIN + i_index] = RGB2PIXEL( 0, 0, 0 );
p_sys->p_rgb16[GREEN_OFFSET - GREEN_MARGIN + i_index] = 0;
p_sys->p_rgb16[GREEN_OFFSET + 256 + i_index] = RGB2PIXEL( 0, 255, 0 );
}
for( unsigned i_index = 0; i_index < BLUE_MARGIN; i_index++ )
{
p_sys->p_rgb16[BLUE_OFFSET - BLUE_MARGIN + i_index] = RGB2PIXEL( 0, 0, 0 );
p_sys->p_rgb16[BLUE_OFFSET - BLUE_MARGIN + i_index] = 0;
p_sys->p_rgb16[BLUE_OFFSET + BLUE_MARGIN + i_index] = RGB2PIXEL( 0, 0, 255 );
}
for( unsigned i_index = 0; i_index < 256; i_index++ )
@ -354,17 +354,17 @@ static void SetYUV( filter_t *p_filter, const video_format_t *vfmt )
p_sys->p_rgb32 = (uint32_t *)p_sys->p_base;
for( unsigned i_index = 0; i_index < RED_MARGIN; i_index++ )
{
p_sys->p_rgb32[RED_OFFSET - RED_MARGIN + i_index] = RGB2PIXEL( 0, 0, 0 );
p_sys->p_rgb32[RED_OFFSET - RED_MARGIN + i_index] = 0;
p_sys->p_rgb32[RED_OFFSET + 256 + i_index] = RGB2PIXEL( 255, 0, 0 );
}
for( unsigned i_index = 0; i_index < GREEN_MARGIN; i_index++ )
{
p_sys->p_rgb32[GREEN_OFFSET - GREEN_MARGIN + i_index] = RGB2PIXEL( 0, 0, 0 );
p_sys->p_rgb32[GREEN_OFFSET - GREEN_MARGIN + i_index] = 0;
p_sys->p_rgb32[GREEN_OFFSET + 256 + i_index] = RGB2PIXEL( 0, 255, 0 );
}
for( unsigned i_index = 0; i_index < BLUE_MARGIN; i_index++ )
{
p_sys->p_rgb32[BLUE_OFFSET - BLUE_MARGIN + i_index] = RGB2PIXEL( 0, 0, 0 );
p_sys->p_rgb32[BLUE_OFFSET - BLUE_MARGIN + i_index] = 0;
p_sys->p_rgb32[BLUE_OFFSET + BLUE_MARGIN + i_index] = RGB2PIXEL( 0, 0, 255 );
}
for( unsigned i_index = 0; i_index < 256; i_index++ )