videolan/vlc
1
Fork 0
mirror of https://code.videolan.org/videolan/vlc synced 2024-10-03 01:31:53 +02:00
Code Releases Activity

visual: no need to strdup the name of the effect as it's only use with strcmp.

Browse Source
This commit is contained in:
Rémi Duraffort 2009-05-30 11:15:13 +02:00
parent c062239e6c
commit d6c0a9652f
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/visualization/visual/visual.c
View File

@ -1,7 +1,7 @@
/*****************************************************************************
* visual.c : Visualisation system
*****************************************************************************
* Copyright (C) 2002-2006 the VideoLAN team
* Copyright (C) 2002-2009 the VideoLAN team
* $Id$
*
* Authors: Clément Stenac <zorglub@via.ecp.fr>
@ -243,7 +243,7 @@ static int Open( vlc_object_t *p_this )
strlen( pf_effect_run[i].psz_name ) ) )
{
p_effect->pf_run = pf_effect_run[i].pf_run;
p_effect->psz_name = strdup( pf_effect_run[i].psz_name );
p_effect->psz_name = pf_effect_run[i].psz_name;
break;
}
}
@ -261,7 +261,6 @@ static int Open( vlc_object_t *p_this )
if( ( psz_eoa = strchr( psz_parser, '}') ) == NULL )
{
msg_Err( p_filter, "unable to parse effect list. Aborting");
free( p_effect->psz_name );
free( p_effect );
break;
}
@ -314,7 +313,6 @@ static int Open( vlc_object_t *p_this )
msg_Err( p_filter, "no suitable vout module" );
for( int i = 0; i < p_sys->i_effect; i++ )
{
free( p_sys->effect[i]->psz_name );
free( p_sys->effect[i]->psz_args );
free( p_sys->effect[i] );
}
@ -404,7 +402,6 @@ static void Close( vlc_object_t *p_this )
free( ( ( spectrum_data * )p_effect->p_data )->prev_heights );
}
free( p_effect->p_data );
free( p_effect->psz_name );
free( p_effect->psz_args );
free( p_effect );
#undef p_effect

8
modules/visualization/visual/visual.h
View File

@ -1,7 +1,7 @@
/*****************************************************************************
* visual.h : Header for the visualisation system
*****************************************************************************
* Copyright (C) 2002 the VideoLAN team
* Copyright (C) 2002-2009 the VideoLAN team
* $Id$
*
* Authors: Clément Stenac <zorglub@via.ecp.fr>
@ -23,10 +23,10 @@
typedef struct visual_effect_t
{
char * psz_name; /* Filter name*/
const char *psz_name; /* Filter name*/
int (*pf_run)( struct visual_effect_t * , aout_instance_t *,
aout_buffer_t *, picture_t *);
int (*pf_run)( struct visual_effect_t * , aout_instance_t *,
aout_buffer_t *, picture_t *);
void * p_data; /* The effect stores whatever it wants here */
int i_width;
int i_height;