From 8a88f1005cef73a066f8aafce1a66b95a2c7257b Mon Sep 17 00:00:00 2001
From: Lyndon Brown <jnqnfe@gmail.com>
Date: Tue, 8 Mar 2022 07:04:13 +0000
Subject: [PATCH] mp4: fix null deref

This used one too many derefs, and then due to the earlier write of null
near the beginning of the function (making a null write here redundant)
there was thus a null-deref.

Regression from 0e9db4f7e603e88488f414b7ef44ba8c323f4df0.
---
 modules/demux/mp4/attachments.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/demux/mp4/attachments.c b/modules/demux/mp4/attachments.c
index 2e00c0468e..29ec73b99d 100644
--- a/modules/demux/mp4/attachments.c
+++ b/modules/demux/mp4/attachments.c
@@ -371,7 +371,6 @@ size_t MP4_GetAttachments( const MP4_Box_t *p_root, input_attachment_t ***ppp_at
     if ( i_count == 0 )
     {
         free( pp_attach );
-        **ppp_attach = NULL;
         return 0;
     }