videolan
/
vlc
mirror of https://code.videolan.org/videolan/vlc
1
Fork 0
Code Releases Activity

qt: fix deleting/updating items in cache before it's loaded

This commit is contained in:
Pierre Lamot 2022-04-01 14:44:35 +02:00 committed by Jean-Baptiste Kempf
parent 3035fa4ea2
commit 572b5887c4
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
modules/gui/qt/medialibrary/mllistcache.cpp
View File

@ -143,6 +143,10 @@ int MLListCache::updateItem(std::unique_ptr<MLItem>&& newItem)
if (m_oldData)
return -1;
//we can't update an item before we have any cache
if (unlikely(!m_cachedData))
return -1;
MLItemId mlid = newItem->getId();
//this may be inneficient to look at every items, maybe we can have a hashmap to access the items by id
auto it = std::find_if(m_cachedData->list.begin(), m_cachedData->list.end(), [mlid](const ItemType& item) {
@ -165,6 +169,10 @@ int MLListCache::deleteItem(const MLItemId& mlid)
if (m_oldData)
return -1;
//we can't remove an item before we have any cache
if (unlikely(!m_cachedData))
return -1;
auto it = std::find_if(m_cachedData->list.begin(), m_cachedData->list.end(), [mlid](const ItemType& item) {
return (item->getId() == mlid);
});
@ -192,6 +200,9 @@ void MLListCache::moveRange(int first, int last, int to)
if (first <= to && to <= last)
return;
if (unlikely(!m_cachedData))
return;
emit beginMoveRows(first, last, to);
auto it = m_cachedData->list.begin();
//build a temporary list with the items in order
@ -217,6 +228,9 @@ void MLListCache::moveRange(int first, int last, int to)
void MLListCache::deleteRange(int first, int last)
{
if (unlikely(!m_cachedData))
return;
assert(first <= last);
emit beginRemoveRows(first, last);
auto it = m_cachedData->list.begin();