From 03619d36d8b281b1c655e944ddb74b3e5e90f559 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= Date: Wed, 13 May 2009 23:13:10 +0300 Subject: [PATCH 1/2] XCB/window: do not depend on xcb-aux for one trivial function call --- configure.ac | 1 - modules/video_output/xcb/window.c | 21 +++++++++++++++++++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index be6e24cdd6..fea513b45e 100644 --- a/configure.ac +++ b/configure.ac @@ -4176,7 +4176,6 @@ AS_IF([test "${enable_xcb}" != "no"], [ ]) dnl xcb-utils - PKG_CHECK_MODULES(XCB_AUX, [xcb-aux]) PKG_CHECK_MODULES(XCB_KEYSYMS, [xcb-keysyms]) VLC_ADD_PLUGIN([xcb]) diff --git a/modules/video_output/xcb/window.c b/modules/video_output/xcb/window.c index 6b313519f2..dfc5020daa 100644 --- a/modules/video_output/xcb/window.c +++ b/modules/video_output/xcb/window.c @@ -31,7 +31,6 @@ #include /* HOST_NAME_MAX */ #include -#include typedef xcb_atom_t Atom; #include /* XA_WM_NAME */ @@ -140,8 +139,26 @@ static int Open (vlc_object_t *obj) if (xcb_connection_has_error (conn) /*== NULL*/) goto error; + /* Find configured screen */ + const xcb_setup_t *setup = xcb_get_setup (conn); + xcb_screen_t *scr = NULL; + for (xcb_screen_iterator_t i = xcb_setup_roots_iterator (setup); + i.rem > 0; xcb_screen_next (&i)) + { + if (snum == 0) + { + scr = i.data; + break; + } + snum--; + } + if (scr == NULL) + { + msg_Err (wnd, "bad X11 screen number"); + goto error; + } + /* Create window */ - xcb_screen_t *scr = xcb_aux_get_screen (conn, snum); const uint32_t mask = XCB_CW_BACK_PIXEL | XCB_CW_EVENT_MASK; uint32_t values[2] = { /* XCB_CW_BACK_PIXEL */ From 548f78df2e9dd0ba08055d34b021480a016870b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= Date: Wed, 13 May 2009 23:23:35 +0300 Subject: [PATCH 2/2] OpenGL: fix missing GLX window decoration --- modules/video_output/opengl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/video_output/opengl.c b/modules/video_output/opengl.c index 3fbe5e642f..ecacbeb48b 100644 --- a/modules/video_output/opengl.c +++ b/modules/video_output/opengl.c @@ -193,6 +193,8 @@ static int CreateVout( vlc_object_t *p_this ) p_sys->p_vout->b_autoscale = p_vout->b_autoscale; p_sys->p_vout->i_zoom = p_vout->i_zoom; p_sys->p_vout->i_alignment = p_vout->i_alignment; + var_Create( p_sys->p_vout, "video-deco", + VLC_VAR_BOOL | VLC_VAR_DOINHERIT ); psz = var_CreateGetString( p_vout, "opengl-provider" ); p_sys->p_vout->p_module =