videolan/vlc
1
Fork 0
mirror of https://code.videolan.org/videolan/vlc synced 2024-09-04 09:11:33 +02:00
Code Releases Activity

Remove VLCOPT support from M3U parser.

Browse Source 
This was blatantly insecure.
This commit is contained in:
Rémi Denis-Courmont 2007-11-20 18:54:04 +00:00
parent b83bd217a9
commit 05c8198d0f
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
modules/demux/playlist/m3u.c
View File

@ -145,6 +145,13 @@ static int Demux( demux_t *p_demux )
if( psz_artist )
psz_artist = strdup( psz_artist );
}
#if 0
/* You're going to need a pretty strong explanation, why
* this is not a big security hole if you are to uncomment
* this piece of code. Potentially untrusted input file must
* not be allowed to specify options in an open-handed fashion.
* -- Courmisch
*/
else if( !strncasecmp( psz_parse, "EXTVLCOPT:",
sizeof("EXTVLCOPT:") -1 ) )
{
@ -158,6 +165,7 @@ static int Demux( demux_t *p_demux )
INSERT_ELEM( ppsz_options, i_options, i_options,
psz_option );
}
#endif
}
else if( !strncasecmp( psz_parse, "RTSPtext", sizeof("RTSPtext") -1 ) )
{