mirror of
https://git.videolan.org/git/ffmpeg.git
synced 2024-07-21 11:44:12 +02:00
b6c207f535
The problem is that with particularly complex images and especially at high bit depths and 5-level transforms the coefficients would overflow, causing huge artifacts to appear. This was discovered thanks to the fate tests, which will have to be redone as this fixes a multitude of problems and increases PSNR. There is a slight performance drop associated with this change, making the encoder slower by 1.15 times, however this is necessary in order to avoid undefined behavior and overflows. It would be worth to template the transforms to keep the performance for 8 bit images as 32 bit coefficients are unnecessary for that case, but the primary use of the encoder is to encode video at 10 bits. Reviewed-by: Christophe Gisquet <christophe.gisquet@gmail.com> Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
53 lines
1.9 KiB
C
53 lines
1.9 KiB
C
/*
|
|
* Copyright (C) 2016 Open Broadcast Systems Ltd.
|
|
* Author 2016 Rostislav Pehlivanov <atomnuker@gmail.com>
|
|
*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef AVCODEC_VC2ENC_DWT_H
|
|
#define AVCODEC_VC2ENC_DWT_H
|
|
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
|
|
typedef int32_t dwtcoef;
|
|
|
|
enum VC2TransformType {
|
|
VC2_TRANSFORM_9_7 = 0, /* Deslauriers-Dubuc (9,7) */
|
|
VC2_TRANSFORM_5_3 = 1, /* LeGall (5,3) */
|
|
VC2_TRANSFORM_13_7 = 2, /* Deslauriers-Dubuc (13,7) */
|
|
VC2_TRANSFORM_HAAR = 3, /* Haar without shift */
|
|
VC2_TRANSFORM_HAAR_S = 4, /* Haar with 1 shift/lvl */
|
|
VC2_TRANSFORM_FIDEL = 5, /* Fidelity filter */
|
|
VC2_TRANSFORM_9_7_I = 6, /* Daubechies (9,7) */
|
|
|
|
VC2_TRANSFORMS_NB
|
|
};
|
|
|
|
typedef struct VC2TransformContext {
|
|
dwtcoef *buffer;
|
|
void (*vc2_subband_dwt[VC2_TRANSFORMS_NB])(struct VC2TransformContext *t,
|
|
dwtcoef *data, ptrdiff_t stride,
|
|
int width, int height);
|
|
} VC2TransformContext;
|
|
|
|
int ff_vc2enc_init_transforms(VC2TransformContext *t, int p_width, int p_height);
|
|
void ff_vc2enc_free_transforms(VC2TransformContext *t);
|
|
|
|
#endif /* AVCODEC_VC2ENC_DWT_H */
|