From f4facd2ce70b1d07ae2730abfcc050f2acbc3b53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Wed, 9 Jan 2013 22:57:41 +0200 Subject: [PATCH 1/2] x86: Add a Yasm-based emms() replacement This provides a fallback when building with Yasm enabled, but neither inline assembly, nor the _mm_empty intrinsic are available or enabled. Signed-off-by: Diego Biurrun --- libavutil/internal.h | 3 +++ libavutil/x86/Makefile | 1 + libavutil/x86/emms.asm | 30 ++++++++++++++++++++++++++++++ libavutil/x86/emms.h | 24 ++++++++++++++++++++++++ 4 files changed, 58 insertions(+) create mode 100644 libavutil/x86/emms.asm create mode 100644 libavutil/x86/emms.h diff --git a/libavutil/internal.h b/libavutil/internal.h index f0f5a635c8..5bc6a085d6 100644 --- a/libavutil/internal.h +++ b/libavutil/internal.h @@ -141,6 +141,9 @@ static av_always_inline void emms_c(void) #elif HAVE_MMX && HAVE_MM_EMPTY # include # define emms_c _mm_empty +#elif HAVE_MMX && HAVE_YASM +# include "libavutil/x86/emms.h" +# define emms_c avpriv_emms_yasm #else # define emms_c() #endif /* HAVE_MMX_INLINE */ diff --git a/libavutil/x86/Makefile b/libavutil/x86/Makefile index 3dd696c26a..ae07470b17 100644 --- a/libavutil/x86/Makefile +++ b/libavutil/x86/Makefile @@ -2,4 +2,5 @@ OBJS += x86/cpu.o \ x86/float_dsp_init.o \ YASM-OBJS += x86/cpuid.o \ + x86/emms.o \ x86/float_dsp.o \ diff --git a/libavutil/x86/emms.asm b/libavutil/x86/emms.asm new file mode 100644 index 0000000000..a6851acc99 --- /dev/null +++ b/libavutil/x86/emms.asm @@ -0,0 +1,30 @@ +;***************************************************************************** +;* Copyright (C) 2013 Martin Storsjo +;* +;* This file is part of Libav. +;* +;* Libav is free software; you can redistribute it and/or +;* modify it under the terms of the GNU Lesser General Public +;* License as published by the Free Software Foundation; either +;* version 2.1 of the License, or (at your option) any later version. +;* +;* Libav is distributed in the hope that it will be useful, +;* but WITHOUT ANY WARRANTY; without even the implied warranty of +;* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +;* Lesser General Public License for more details. +;* +;* You should have received a copy of the GNU Lesser General Public +;* License along with Libav; if not, write to the Free Software +;* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +;****************************************************************************** + +%include "x86util.asm" + +SECTION .text + +;----------------------------------------------------------------------------- +; void avpriv_emms_yasm(void) +;----------------------------------------------------------------------------- +cvisible emms_yasm, 0, 0 + emms + RET diff --git a/libavutil/x86/emms.h b/libavutil/x86/emms.h new file mode 100644 index 0000000000..6bb8ca3195 --- /dev/null +++ b/libavutil/x86/emms.h @@ -0,0 +1,24 @@ +/* + * This file is part of Libav. + * + * Libav is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * Libav is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with Libav; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef AVUTIL_X86_EMMS_H +#define AVUTIL_X86_EMMS_H + +void avpriv_emms_yasm(void); + +#endif /* AVUTIL_X86_EMMS_H */ From 822b0728f0e3c3ba60b20bd4fd971d5c4a3fe3e9 Mon Sep 17 00:00:00 2001 From: Diego Biurrun Date: Wed, 16 Jan 2013 23:50:57 +0100 Subject: [PATCH 2/2] x86: dsputil: Drop some unused macro definitions --- libavcodec/x86/dsputil_mmx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libavcodec/x86/dsputil_mmx.c b/libavcodec/x86/dsputil_mmx.c index 7ac6ecb2c4..13f215135a 100644 --- a/libavcodec/x86/dsputil_mmx.c +++ b/libavcodec/x86/dsputil_mmx.c @@ -196,14 +196,12 @@ DECLARE_ALIGNED(16, const double, ff_pd_2)[2] = { 2.0, 2.0 }; #define DEF(x) x ## _3dnow #define PAVGB "pavgusb" -#define OP_AVG PAVGB #define SKIP_FOR_3DNOW #include "dsputil_avg_template.c" #undef DEF #undef PAVGB -#undef OP_AVG #undef SKIP_FOR_3DNOW /***********************************/ @@ -213,13 +211,11 @@ DECLARE_ALIGNED(16, const double, ff_pd_2)[2] = { 2.0, 2.0 }; /* Introduced only in MMXEXT set */ #define PAVGB "pavgb" -#define OP_AVG PAVGB #include "dsputil_avg_template.c" #undef DEF #undef PAVGB -#undef OP_AVG #define put_no_rnd_pixels16_mmx put_pixels16_mmx #define put_no_rnd_pixels8_mmx put_pixels8_mmx