videolan/ffmpeg
1
Fork 0
mirror of https://git.videolan.org/git/ffmpeg.git synced 2024-07-20 03:04:12 +02:00
Code Releases Activity

eatgq: Pass error code from tgq_decode_mb() and let the caller fail.

Browse Source 
This fixes a over read.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Michael Niedermayer 2012-03-01 19:56:57 +01:00
parent 32f0c65828
commit dc945b1fa8
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libavcodec/eatgq.c
View File

@ -141,7 +141,7 @@ static void tgq_idct_put_mb_dconly(TgqContext *s, int mb_x, int mb_y, const int8
} }
} }
static void tgq_decode_mb(TgqContext *s, int mb_y, int mb_x, const uint8_t **bs, const uint8_t *buf_end){ static int tgq_decode_mb(TgqContext *s, int mb_y, int mb_x, const uint8_t **bs, const uint8_t *buf_end){
int mode; int mode;
int i; int i;
int8_t dc[6]; int8_t dc[6];
@ -149,7 +149,7 @@ static void tgq_decode_mb(TgqContext *s, int mb_y, int mb_x, const uint8_t **bs,
mode = bytestream_get_byte(bs); mode = bytestream_get_byte(bs);
if (mode>buf_end-*bs) { if (mode>buf_end-*bs) {
av_log(s->avctx, AV_LOG_ERROR, "truncated macroblock\n"); av_log(s->avctx, AV_LOG_ERROR, "truncated macroblock\n");
return; return AVERROR_INVALIDDATA;
} }
if (mode>12) { if (mode>12) {
@ -174,6 +174,8 @@ static void tgq_decode_mb(TgqContext *s, int mb_y, int mb_x, const uint8_t **bs,
tgq_idct_put_mb_dconly(s, mb_x, mb_y, dc); tgq_idct_put_mb_dconly(s, mb_x, mb_y, dc);
} }
*bs += mode; *bs += mode;
return 0;
} }
static void tgq_calculate_qtable(TgqContext *s, int quant){ static void tgq_calculate_qtable(TgqContext *s, int quant){
@ -196,7 +198,7 @@ static int tgq_decode_frame(AVCodecContext *avctx,
const uint8_t *buf_start = buf; const uint8_t *buf_start = buf;
const uint8_t *buf_end = buf + buf_size; const uint8_t *buf_end = buf + buf_size;
TgqContext *s = avctx->priv_data; TgqContext *s = avctx->priv_data;
int x,y; int x,y, ret;
int big_endian = AV_RL32(&buf[4]) > 0x000FFFFF; int big_endian = AV_RL32(&buf[4]) > 0x000FFFFF;
buf += 8; buf += 8;
@ -228,7 +230,8 @@ static int tgq_decode_frame(AVCodecContext *avctx,
for (y=0; y<(avctx->height+15)/16; y++) for (y=0; y<(avctx->height+15)/16; y++)
for (x=0; x<(avctx->width+15)/16; x++) for (x=0; x<(avctx->width+15)/16; x++)
tgq_decode_mb(s, y, x, &buf, buf_end); if ((ret=tgq_decode_mb(s, y, x, &buf, buf_end)) < 0)
return ret;
*data_size = sizeof(AVFrame); *data_size = sizeof(AVFrame);
*(AVFrame*)data = s->frame; *(AVFrame*)data = s->frame;