videolan
/
ffmpeg
mirror of https://git.videolan.org/git/ffmpeg.git
1
Fork 0
Code Releases Activity

avformat/http: Stop cookie_dict leaking on errors. 

This solves the memory leak reported in https://trac.ffmpeg.org/ticket/9273

Signed-off-by: Robert Bengtsson-Ölund <robert.bengtsson-olund@intinor.se>
This commit is contained in:
Robert Bengtsson-Ölund 2021-06-01 18:50:51 +02:00 committed by Tomas Härdin
parent 296dc876ec
commit ad06929d8d
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libavformat/http.c
View File

@ -605,6 +605,7 @@ static int http_listen(URLContext *h, const char *uri, int flags,
}
fail:
av_dict_free(&s->chained_options);
av_dict_free(&s->cookie_dict);
return ret;
}
@ -645,8 +646,10 @@ static int http_open(URLContext *h, const char *uri, int flags,
}
ret = http_open_cnx(h, options);
bail_out:
if (ret < 0)
if (ret < 0) {
av_dict_free(&s->chained_options);
av_dict_free(&s->cookie_dict);
}
return ret;
}
@ -1763,6 +1766,7 @@ static int http_close(URLContext *h)
if (s->hd)
ffurl_closep(&s->hd);
av_dict_free(&s->chained_options);
av_dict_free(&s->cookie_dict);
return ret;
}