mirror of https://github.com/rclone/rclone synced 2024-12-22 13:03:02 +01:00

Go to file

nielash 9b4b3033da fs/cache: fix parent not getting pinned when remote is a file Before this change, when cache.GetFn was called on a file rather than a directory, two cache entries would be added (the file + its parent) but only one of them would get pinned if the caller then called Pin(f). This left the other one exposed to expiration if the ci.FsCacheExpireDuration was reached. This was problematic because both entries point to the same Fs, and if one entry expires while the other is pinned, the Shutdown method gets erroneously called on an Fs that is still in use. An example of the problem showed up in the Hasher backend, which uses the Shutdown method to stop the bolt db used to store hashes. If a command was run on a Hasher file (ex. `rclone md5sum --download hasher:somelargefile.zip`) and hashing the file took longer than the --fs-cache-expire-duration (5m by default), the bolt db was stopped before the hashing operation completed, resulting in an error. This change fixes the issue by ensuring that: 1. only one entry is added to the cache (the file's parent, not the file). 2. future lookups correctly find the entry regardless of whether they are called with the parent name or one of its children. 3. fs.ErrorIsFile is returned when (and only when) fsString points to a file (preserving the fix from `8d5bc7f28b`). Note that f.Root() should always point to the parent dir as of `c69eb84573`		2024-09-28 13:49:56 +01:00
.github	build: fix docker release build - fixes #8062	2024-09-12 17:57:53 +01:00
backend	gcs: add access token auth with --gcs-access-token	2024-09-27 17:37:07 +01:00
bin	Makefile: Prevent `doc` recipe from creating dir named '$HOME'	2024-09-24 10:38:25 +01:00
cmd	build: replace "golang.org/x/exp/slices" with "slices" now go1.21 is required	2024-09-25 16:03:43 +01:00
cmdtest	cmd: change exit code from 1 to 2 for syntax and usage errors	2024-09-20 18:51:08 +02:00
contrib	docker volume plugin: add missing fuse3 dependency #6844	2023-03-15 15:57:53 +00:00
docs	gcs: add access token auth with --gcs-access-token	2024-09-27 17:37:07 +01:00
fs	fs/cache: fix parent not getting pinned when remote is a file	2024-09-28 13:49:56 +01:00
fstest	test_all: add ignoretests parameter for skipping certain tests	2024-09-25 16:03:43 +01:00
graphics	Version v1.66.0	2024-03-10 11:22:43 +00:00
lib	fs/cache: fix parent not getting pinned when remote is a file	2024-09-28 13:49:56 +01:00
librclone	docs/librclone: the newer and recommended ucrt64 subsystem of msys2 can now be used for building on windows	2024-01-01 21:56:45 +01:00
vfs	rc: add vfs/queue-set-expiry to adjust expiry of items in the VFS queue	2024-09-06 17:33:35 +01:00
.gitattributes	Add go mod and sum to gitattributes for consistent line endings	2024-04-13 11:16:42 +02:00
.gitignore	docs: tidy .gitignore for docs	2024-06-15 13:08:20 +01:00
.golangci.yml	build: enable custom linting rules with ruleguard via gocritic	2024-09-06 17:04:18 +01:00
CONTRIBUTING.md	docs: add note to CONTRIBUTING that the overview needs editing in 2 places	2024-09-25 17:56:33 +01:00
COPYING	Initial commit - some small parts working	2012-11-18 17:32:31 +00:00
Dockerfile	build: fix docker build on arm/v6	2024-01-03 17:43:23 +00:00
go.mod	build: replace "golang.org/x/exp/slices" with "slices" now go1.21 is required	2024-09-25 16:03:43 +01:00
go.sum	build: enable custom linting rules with ruleguard via gocritic	2024-09-06 17:04:18 +01:00
MAINTAINERS.md	chore: add childish-sambino as filescom maintainer	2024-08-15 22:00:26 +01:00
Makefile	Makefile: Fail when doc recipes create dir named '$HOME'	2024-09-24 10:38:25 +01:00
MANUAL.html	Version v1.68.0	2024-09-08 16:21:56 +01:00
MANUAL.md	Version v1.68.0	2024-09-08 16:21:56 +01:00
MANUAL.txt	Version v1.68.0	2024-09-08 16:21:56 +01:00
notes.txt	docs: spelling: etc.	2020-10-28 18:16:23 +00:00
rclone.1	Version v1.68.0	2024-09-08 16:21:56 +01:00
rclone.go	lib: add plugin support	2019-09-29 11:05:10 +01:00
README.md	docs: add missing sftp providers to README and main docs page - fixes #8038	2024-08-28 07:25:49 +01:00
RELEASE.md	docs: correct notes on docker manual build	2024-09-13 15:52:51 +01:00
VERSION	Start v1.69.0-DEV development	2024-09-08 17:22:19 +01:00