mirror of
https://github.com/rclone/rclone
synced 2024-11-30 09:10:05 +01:00
5f1d5a1897
The downloaders.Close() call acquires the downloaders' mutex before calling the wait group wait and the main downloaders thread has a periodical (5 seconds interval) call to kick its waiters and the waiter dispatch function tries to get the mutex. So a deadlock can occur if the Close() call starts, gets the mutex, while the main downloader thread already got the timer's tick and proceeded to call kickWaiters. The deadlock happens when the Close call gets the mutex between the timer's kick and the main downloader thread gets the mutex first. So it's a pretty short period of time and it probably explains why the problem has not surfaced, maybe something like tens of nanoseconds out of 5 seconds (~10^^-8). It took 5 days of continued stressing the Close calls for the deadlock to appear. |
||
|---|---|---|
| .. | ||
| downloaders | ||
| writeback | ||
| cache_test.go | ||
| cache.go | ||
| item_test.go | ||
| item.go | ||