mirror of
https://github.com/rclone/rclone
synced 2024-11-21 22:50:16 +01:00
2b0a25a64d
Before this change, the Memory backend had the potential to deadlock under certain conditions, if the ListR callback required locking the b.mu mutex. This was the case with operations.Purge, because Memory has no Purge method, and the fallback option does: err = DeleteFiles(ctx, listToChan(ctx, f, dir)) which potentially starts removing objects before the listing has completed. This change fixes the issue by batching all the entries before calling the callback on them.
41 lines
1.0 KiB
Go
41 lines
1.0 KiB
Go
package memory
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
_ "github.com/rclone/rclone/backend/local"
|
|
"github.com/rclone/rclone/fs/operations"
|
|
"github.com/rclone/rclone/fstest"
|
|
"github.com/rclone/rclone/fstest/fstests"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var t1 = fstest.Time("2001-02-03T04:05:06.499999999Z")
|
|
|
|
// InternalTest dispatches all internal tests
|
|
func (f *Fs) InternalTest(t *testing.T) {
|
|
t.Run("PurgeListDeadlock", func(t *testing.T) {
|
|
testPurgeListDeadlock(t)
|
|
})
|
|
}
|
|
|
|
// test that Purge fallback does not result in deadlock from concurrently listing and removing
|
|
func testPurgeListDeadlock(t *testing.T) {
|
|
ctx := context.Background()
|
|
r := fstest.NewRunIndividual(t)
|
|
r.Mkdir(ctx, r.Fremote)
|
|
r.Fremote.Features().Disable("Purge") // force fallback-purge
|
|
|
|
// make a lot of files to prevent it from finishing too quickly
|
|
for i := 0; i < 100; i++ {
|
|
dst := "file" + fmt.Sprint(i) + ".txt"
|
|
r.WriteObject(ctx, dst, "hello", t1)
|
|
}
|
|
|
|
require.NoError(t, operations.Purge(ctx, r.Fremote, ""))
|
|
}
|
|
|
|
var _ fstests.InternalTester = (*Fs)(nil)
|