5 Commits

Author	SHA1	Message	Date
albertony	c6d3714e73	build: fix gocritic lint issue assignop	2024-08-15 22:08:34 +01:00
albertony	68bf6aa584	build: remove build constraint syntax for go 1.16 and older	2024-04-18 16:53:55 +02:00
Nick Craig-Wood	acf1e2df84	lib/file: fix MkdirAll after go1.21.4 stdlib update ... In ths security related issue the go1.21.4 stdlib changed the parsing of volume names on Windows. https://github.com/golang/go/issues/63713 This had the consequences of breaking the MkdirAll tests which were looking for specific error messages which changed and using invalid paths. In particular under go1.21.3: filepath.VolumeName(`\\?\C:`) == `\\?\C:` But under go1.21.4 it is: filepath.VolumeName(`\\?\C:`) == `\\?` The path `\\?\C:` isn't actually a valid Windows path. I reported this as a FYI bug upstream - I'm not expecting it to be fixed. See: https://github.com/golang/go/issues/64101	2023-11-14 09:47:46 +00:00
albertony	65987f5970	lib/file: improve error message for create dir on non-existent network host on windows (#6420)	2022-10-28 21:00:22 +02:00
albertony	fbc7f2e61b	lib/file: improve error message when attempting to create dir on nonexistent drive on windows ... This replaces built-in os.MkdirAll with a patched version that stops the recursion when reaching the volume part of the path. The original version would continue recursion, and for extended length paths end up with \\? as the top-level directory, and the error message would then be something like: mkdir \\?: The filename, directory name, or volume label syntax is incorrect.	2021-10-01 23:18:39 +02:00