1
mirror of https://github.com/rclone/rclone synced 2024-11-28 06:41:41 +01:00

operations: Implement CopyDirMetadata, CopyDirModTime and SetDirModTime

This commit is contained in:
Nick Craig-Wood 2024-02-06 15:59:19 +00:00
parent 09953d77b5
commit e8fe0b0553

View File

@ -986,6 +986,64 @@ func Mkdir(ctx context.Context, f fs.Fs, dir string) error {
return nil return nil
} }
// MkdirMetadata makes a destination directory or container with metadata
//
// If the destination Fs doesn't support this it will fall back to
// Mkdir and in this case newDst will be nil.
func MkdirMetadata(ctx context.Context, f fs.Fs, dir string, metadata fs.Metadata) (newDst fs.Directory, err error) {
do := f.Features().MkdirMetadata
if do == nil {
return nil, Mkdir(ctx, f, dir)
}
logName := fs.LogDirName(f, dir)
if SkipDestructive(ctx, logName, "make directory") {
return nil, nil
}
fs.Debugf(fs.LogDirName(f, dir), "Making directory with metadata")
newDst, err = do(ctx, dir, metadata)
if err != nil {
err = fs.CountError(err)
return nil, err
}
if mtime, ok := metadata["mtime"]; ok {
fs.Infof(logName, "Made directory with metadata (mtime=%s)", mtime)
} else {
fs.Infof(logName, "Made directory with metadata")
}
return newDst, err
}
// MkdirModTime makes a destination directory or container with modtime
//
// If the destination Fs doesn't support this it will fall back to
// Mkdir and in this case newDst will be nil.
//
// If the directory was created with MkDir then it will attempt to use
// Fs.DirSetModTime if available.
func MkdirModTime(ctx context.Context, f fs.Fs, dir string, modTime time.Time) (newDst fs.Directory, err error) {
logName := fs.LogDirName(f, dir)
if SkipDestructive(ctx, logName, "make directory") {
return nil, nil
}
metadata := fs.Metadata{
"mtime": modTime.Format(time.RFC3339Nano),
}
newDst, err = MkdirMetadata(ctx, f, dir, metadata)
if err != nil {
return nil, err
}
if newDst != nil {
// The directory was created and we have logged already
return newDst, nil
}
// The directory was created with Mkdir then we should try to set the time
if do := f.Features().DirSetModTime; do != nil {
err = do(ctx, dir, modTime)
}
fs.Infof(logName, "Made directory with modification time %v", modTime)
return newDst, err
}
// TryRmdir removes a container but not if not empty. It doesn't // TryRmdir removes a container but not if not empty. It doesn't
// count errors but may return one. // count errors but may return one.
func TryRmdir(ctx context.Context, f fs.Fs, dir string) error { func TryRmdir(ctx context.Context, f fs.Fs, dir string) error {
@ -2428,3 +2486,116 @@ func SkipDestructive(ctx context.Context, subject interface{}, action string) (s
} }
return skip return skip
} }
// Return the best way of describing the directory for the logs
func dirName(f fs.Fs, dst fs.Directory, dir string) any {
if dst != nil {
if dst.Remote() != "" {
return dst
}
// Root is described as the Fs
return f
}
if dir != "" {
return dir
}
// Root is described as the Fs
return f
}
// CopyDirMetadata copies the src directory to dst or f if nil. If dst is nil then it uses
// dir as the name of the new directory.
//
// It returns the destination directory if possible. Note that this may
// be nil.
func CopyDirMetadata(ctx context.Context, f fs.Fs, dst fs.Directory, dir string, src fs.Directory) (newDst fs.Directory, err error) {
ci := fs.GetConfig(ctx)
logName := dirName(f, dst, dir)
if SkipDestructive(ctx, logName, "update directory metadata") {
return nil, nil
}
// Options for the directory metadata
options := []fs.OpenOption{}
if ci.MetadataSet != nil {
options = append(options, fs.MetadataOption(ci.MetadataSet))
}
// Read metadata from src and add options and use metadata mapper
metadata, err := fs.GetMetadataOptions(ctx, f, src, options)
if err != nil {
return nil, err
}
// Fall back to ModTime if metadata not available
if metadata == nil {
metadata = fs.Metadata{}
}
if metadata["mtime"] == "" {
metadata["mtime"] = src.ModTime(ctx).Format(time.RFC3339Nano)
}
// Now set the metadata
if dst == nil {
do := f.Features().MkdirMetadata
if do == nil {
return nil, fmt.Errorf("internal error: expecting %v to have MkdirMetadata method: %w", f, fs.ErrorNotImplemented)
}
newDst, err = do(ctx, dir, metadata)
} else {
do, ok := dst.(fs.SetMetadataer)
if !ok {
return nil, fmt.Errorf("internal error: expecting directory %T from %v to have SetMetadata method: %w", dir, f, fs.ErrorNotImplemented)
}
err = do.SetMetadata(ctx, metadata)
newDst = dst
}
if err != nil {
return nil, err
}
fs.Infof(logName, "Updated directory metadata")
return newDst, nil
}
// SetDirModTime sets the modtime on dst or dir
//
// If dst is nil then it uses dir as the name of the directory.
//
// It returns the destination directory if possible. Note that this
// may be nil.
//
// It does not create the directory.
func SetDirModTime(ctx context.Context, f fs.Fs, dst fs.Directory, dir string, modTime time.Time) (newDst fs.Directory, err error) {
logName := dirName(f, dst, dir)
if SkipDestructive(ctx, logName, "set directory modification time") {
return nil, nil
}
if dst != nil {
dir = dst.Remote()
}
// Try to set the ModTime with the Directory.SetModTime method first as this is the most efficient
if dst != nil {
if do, ok := dst.(fs.SetModTimer); ok {
err := do.SetModTime(ctx, modTime)
if err != nil {
return dst, err
}
fs.Infof(logName, "Set directory modification time (using SetModTime)")
return dst, nil
}
}
// Next try to set the ModTime with the Fs.DirSetModTime method as this works for non-metadata backends
if do := f.Features().DirSetModTime; do != nil {
err := do(ctx, dir, modTime)
if err != nil {
return dst, err
}
fs.Infof(logName, "Set directory modification time (using DirSetModTime)")
return dst, nil
}
// Something should have worked so return an error
return nil, fmt.Errorf("no method to set directory modtime found for %v (%T): %w", f, dir, fs.ErrorNotImplemented)
}