mount: Make include and exclude filters apply to mount - fixes #1060

cmd/mount/dir.go

@@ -78,7 +78,7 @@ func (d *Dir) readDir() error {
 		}
 		fs.Debugf(d.path, "Re-reading directory (%v old)", age)
 	}
-	objs, dirs, err := fs.NewLister().SetLevel(1).Start(d.f, d.path).GetAll()
+	entries, err := fs.ListDirSorted(d.f, false, d.path)
 	if err == fs.ErrorDirNotFound {
 		// We treat directory not found as empty because we
 		// create directories on the fly
@@ -93,26 +93,34 @@ func (d *Dir) readDir() error {
 	oldItems := d.items
 
 	// Cache the items by name
-	d.items = make(map[string]*DirEntry, len(objs)+len(dirs))
+	d.items = make(map[string]*DirEntry, len(entries))
-	for _, obj := range objs {
+	for _, entry := range entries {
-		name := path.Base(obj.Remote())
+		switch item := entry.(type) {
-		d.items[name] = &DirEntry{
+		case fs.Object:
-			o:    obj,
+			obj := item
-			node: nil,
+			name := path.Base(obj.Remote())
-		}
+			d.items[name] = &DirEntry{
-	}
+				o:    obj,
-	for _, dir := range dirs {
+				node: nil,
-		name := path.Base(dir.Remote())
-		// Use old dir value if it exists
-		if oldItem, ok := oldItems[name]; ok {
-			if _, ok := oldItem.o.(*fs.Dir); ok {
-				d.items[name] = oldItem
-				continue
 			}
-		}
+		case *fs.Dir:
-		d.items[name] = &DirEntry{
+			dir := item
-			o:    dir,
+			name := path.Base(dir.Remote())
-			node: nil,
+			// Use old dir value if it exists
+			if oldItem, ok := oldItems[name]; ok {
+				if _, ok := oldItem.o.(*fs.Dir); ok {
+					d.items[name] = oldItem
+					continue
+				}
+			}
+			d.items[name] = &DirEntry{
+				o:    dir,
+				node: nil,
+			}
+		default:
+			err = errors.Errorf("unknown type %T", item)
+			fs.Errorf(d.path, "readDir error: %v", err)
+			return err
 		}
 	}
 	d.read = when

cmd/mount/mount.go

@@ -114,6 +114,11 @@ can't use retries in the same way without making local copies of the
 uploads.  This might happen in the future, but for the moment rclone
 mount won't do that, so will be less reliable than the rclone command.
 
+### Filters ###
+
+Note that all the rclone filters can be used to select a subset of the
+files to be visible in the mount.
+
 ### Bugs ###
 
   * All the remotes should work for read, but some may not for write

fs/operations.go

@@ -530,8 +530,6 @@ func (ds DirEntries) Less(i, j int) bool {
 	return ds[i].Remote() < ds[j].Remote()
 }
 
-// FIXME can use this in Mount
-
 // ListDirSorted reads Object and *Dir into entries for the given Fs.
 //
 // dir is the start directory, "" for root