github/rclone
1
Fork 0
mirror of https://github.com/rclone/rclone synced 2024-09-03 21:31:30 +02:00
Code Releases Activity

fstests: ensure Fs.Put and Object.Update don't panic on unknown-sized uploads

Browse Source
This commit is contained in:
Cnly 2019-02-02 16:35:41 +08:00 committed by Nick Craig-Wood
parent 318d1bb6f9
commit cd46ce916b
1 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
fstest/fstests/fstests.go
View File

@ -1407,6 +1407,53 @@ func Run(t *testing.T, opt *Opt) {
})
// TestFsUploadUnknownSize ensures Fs.Put() and Object.Update() don't panic when
// src.Size() == -1
t.Run("FsUploadUnknownSize", func(t *testing.T) {
skipIfNotOk(t)
t.Run("FsPutUnknownSize", func(t *testing.T) {
defer func() {
assert.Nil(t, recover(), "Fs.Put() should not panic when src.Size() == -1")
}()
contents := fstest.RandomString(100)
in := bytes.NewBufferString(contents)
obji := object.NewStaticObjectInfo("unknown-size-put.txt", fstest.Time("2002-02-03T04:05:06.499999999Z"), -1, true, nil, nil)
obj, err := remote.Put(in, obji)
if err == nil {
require.NoError(t, obj.Remove(), "successfully uploaded unknown-sized file but failed to remove")
}
// if err != nil: it's okay as long as no panic
})
t.Run("FsUpdateUnknownSize", func(t *testing.T) {
unknownSizeUpdateFile := fstest.Item{
ModTime: fstest.Time("2002-02-03T04:05:06.499999999Z"),
Path: "unknown-size-update.txt",
}
testPut(t, remote, &unknownSizeUpdateFile)
defer func() {
assert.Nil(t, recover(), "Object.Update() should not panic when src.Size() == -1")
}()
newContents := fstest.RandomString(200)
in := bytes.NewBufferString(newContents)
obj := findObject(t, remote, unknownSizeUpdateFile.Path)
obji := object.NewStaticObjectInfo(unknownSizeUpdateFile.Path, unknownSizeUpdateFile.ModTime, -1, true, nil, obj.Fs())
err := obj.Update(in, obji)
if err == nil {
require.NoError(t, obj.Remove(), "successfully updated object with unknown-sized source but failed to remove")
}
// if err != nil: it's okay as long as no panic
})
})
// Purge the folder
err = operations.Purge(remote, "")
require.NoError(t, err)