From bca5d8009e7a5f5da9a72c15fddb3e5c0d29cbdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20M=C3=B6ller?= Date: Fri, 2 Nov 2018 13:12:22 +0100 Subject: [PATCH] onedrive: return errors instead of panic for invalid uploads --- backend/onedrive/onedrive.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/onedrive/onedrive.go b/backend/onedrive/onedrive.go index b54b3ce7d..ee2440b5a 100644 --- a/backend/onedrive/onedrive.go +++ b/backend/onedrive/onedrive.go @@ -1488,7 +1488,7 @@ func (o *Object) cancelUploadSession(url string) (err error) { // uploadMultipart uploads a file using multipart upload func (o *Object) uploadMultipart(in io.Reader, size int64, modTime time.Time) (info *api.Item, err error) { if size <= 0 { - panic("size passed into uploadMultipart must be > 0") + return nil, errors.New("unknown-sized upload not supported") } // Create upload session @@ -1535,7 +1535,7 @@ func (o *Object) uploadMultipart(in io.Reader, size int64, modTime time.Time) (i // This function will set modtime after uploading, which will create a new version for the remote file func (o *Object) uploadSinglepart(in io.Reader, size int64, modTime time.Time) (info *api.Item, err error) { if size < 0 || size > int64(fs.SizeSuffix(4*1024*1024)) { - panic("size passed into uploadSinglepart must be >= 0 and <= 4MiB") + return nil, errors.New("size passed into uploadSinglepart must be >= 0 and <= 4MiB") } fs.Debugf(o, "Starting singlepart upload")