1
mirror of https://github.com/rclone/rclone synced 2024-11-20 21:27:33 +01:00

bisync: fix output capture restoring the wrong output for logrus

Before this change, if rclone is used as a library and logrus is used
after a call to rc `sync/bisync`, logging does not work anymore and
leads to writing to a closed pipe.

This change restores the output correctly.

Fixes #8158
This commit is contained in:
Dimitrios Slamaris 2024-11-12 12:42:54 +01:00 committed by GitHub
parent 173b2ac956
commit abe884e744
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -5,20 +5,13 @@ import (
"bytes"
"log"
"github.com/rclone/rclone/fs"
"github.com/sirupsen/logrus"
)
// CaptureOutput runs a function capturing its output.
func CaptureOutput(fun func()) []byte {
logSave := log.Writer()
logrusSave := logrus.StandardLogger().Writer()
defer func() {
err := logrusSave.Close()
if err != nil {
fs.Errorf(nil, "error closing logrusSave: %v", err)
}
}()
logrusSave := logrus.StandardLogger().Out
buf := &bytes.Buffer{}
log.SetOutput(buf)
logrus.SetOutput(buf)