1
mirror of https://github.com/rclone/rclone synced 2024-12-18 07:45:55 +01:00

ftp: implement --ftp-no-check-upload to allow upload to write only dirs

Fixes #8079
This commit is contained in:
Nick Craig-Wood 2024-09-17 16:35:33 +01:00
parent 8c48cadd9c
commit 1a9e6a527d

View File

@ -180,12 +180,28 @@ If this is set and no password is supplied then rclone will ask for a password
Default: "", Default: "",
Help: `Socks 5 proxy host. Help: `Socks 5 proxy host.
Supports the format user:pass@host:port, user@host:port, host:port. Supports the format user:pass@host:port, user@host:port, host:port.
Example: Example:
myUser:myPass@localhost:9005 myUser:myPass@localhost:9005
`, `,
Advanced: true,
}, {
Name: "no_check_upload",
Default: false,
Help: `Don't check the upload is OK
Normally rclone will try to check the upload exists after it has
uploaded a file to make sure the size and modification time are as
expected.
This flag stops rclone doing these checks. This enables uploading to
folders which are write only.
You will likely need to use the --inplace flag also if uploading to
a write only folder.
`,
Advanced: true, Advanced: true,
}, { }, {
Name: config.ConfigEncoding, Name: config.ConfigEncoding,
@ -232,6 +248,7 @@ type Options struct {
AskPassword bool `config:"ask_password"` AskPassword bool `config:"ask_password"`
Enc encoder.MultiEncoder `config:"encoding"` Enc encoder.MultiEncoder `config:"encoding"`
SocksProxy string `config:"socks_proxy"` SocksProxy string `config:"socks_proxy"`
NoCheckUpload bool `config:"no_check_upload"`
} }
// Fs represents a remote FTP server // Fs represents a remote FTP server
@ -1303,6 +1320,16 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
return fmt.Errorf("update stor: %w", err) return fmt.Errorf("update stor: %w", err)
} }
o.fs.putFtpConnection(&c, nil) o.fs.putFtpConnection(&c, nil)
if o.fs.opt.NoCheckUpload {
o.info = &FileInfo{
Name: o.remote,
Size: uint64(src.Size()),
ModTime: src.ModTime(ctx),
precise: true,
IsDir: false,
}
return nil
}
if err = o.SetModTime(ctx, src.ModTime(ctx)); err != nil { if err = o.SetModTime(ctx, src.ModTime(ctx)); err != nil {
return fmt.Errorf("SetModTime: %w", err) return fmt.Errorf("SetModTime: %w", err)
} }