github/rclone
1
Fork 0
mirror of https://github.com/rclone/rclone synced 2024-12-20 10:25:56 +01:00
Code Releases Activity

mount: allow files of unkown size to be read properly

Browse Source 
Before this change, files of unknown size (eg Google Docs) would
appear in file listings with 0 size and would only allow 0 bytes to be
read.

This change sets the direct_io flag in the FUSE return which bypasses
the cache for these files.  This means that they can be read properly.

This is compatible with some, but not all applications.
This commit is contained in:
Nick Craig-Wood 2019-09-14 13:11:21 +01:00
parent ba121eddf0
commit 0baafb158f
4 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/cmount/fs.go
View File

@ -299,6 +299,9 @@ func (fsys *FS) Open(path string, flags int) (errc int, fh uint64) {
return translateError(err), fhUnset return translateError(err), fhUnset
} }
// FIXME add support for unknown length files setting direct_io
// See: https://github.com/billziss-gh/cgofuse/issues/38
return 0, fsys.openHandle(handle) return 0, fsys.openHandle(handle)
} }

5
cmd/mount/file.go
View File

@ -73,6 +73,11 @@ func (f *File) Open(ctx context.Context, req *fuse.OpenRequest, resp *fuse.OpenR
return nil, translateError(err) return nil, translateError(err)
} }
// If size unknown then use direct io to read
if handle.Node().DirEntry().Size() < 0 {
resp.Flags |= fuse.OpenDirectIO
}
return &FileHandle{handle}, nil return &FileHandle{handle}, nil
} }

9
docs/content/drive.md
View File

@ -882,9 +882,12 @@ without downloading them.
Google docs will transfer correctly with `rclone sync`, `rclone copy` Google docs will transfer correctly with `rclone sync`, `rclone copy`
etc as rclone knows to ignore the size when doing the transfer. etc as rclone knows to ignore the size when doing the transfer.
However an unfortunate consequence of this is that you can't download However an unfortunate consequence of this is that you may not be able
Google docs using `rclone mount` - you will get a 0 sized file. If to download Google docs using `rclone mount`. If it doesn't work you
you try again the doc may gain its correct size and be downloadable. will get a 0 sized file. If you try again the doc may gain its
correct size and be downloadable. Whther it will work on not depends
on the application accessing the mount and the OS you are running -
experiment to find out if it does work for you!
### Duplicated files ### ### Duplicated files ###

9
docs/content/googlephotos.md
View File

@ -277,13 +277,14 @@ that when syncing to Google Photos, rclone can only do a file
existence check. existence check.
It is possible to read the size of the media, but this needs an extra It is possible to read the size of the media, but this needs an extra
HTTP HEAD request per media item so is very slow and uses up a lot of HTTP HEAD request per media item so is **very slow** and uses up a lot of
transactions. This can be enabled with the `--gphotos-read-size` transactions. This can be enabled with the `--gphotos-read-size`
option or the `read_size = true` config parameter. option or the `read_size = true` config parameter.
If you want to use the backend with `rclone mount` you will need to If you want to use the backend with `rclone mount` you may need to
enable this flag otherwise you will not be able to read media off the enable this flag (depending on your OS and application using the
mount. photos) otherwise you may not be able to read media off the mount.
You'll need to experiment to see if it works for you without the flag.
### Albums ### Albums