From bdc03b1c75074bc3c7950223c600d8139a7a9ef0 Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Wed, 7 Jul 2021 12:51:55 +0800 Subject: [PATCH 1/3] Add tooltip for various columns Those strings sometimes are quite long and having a tooltip would save the action of resizing the column width to see the full message. The WebUI already has it done for all columns. --- src/gui/properties/trackerlistwidget.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gui/properties/trackerlistwidget.cpp b/src/gui/properties/trackerlistwidget.cpp index a1d00af09..ba2b8a9b0 100644 --- a/src/gui/properties/trackerlistwidget.cpp +++ b/src/gui/properties/trackerlistwidget.cpp @@ -373,6 +373,7 @@ void TrackerListWidget::loadTrackers() { item = new QTreeWidgetItem(); item->setText(COL_URL, trackerURL); + item->setToolTip(COL_URL, trackerURL); addTopLevelItem(item); m_trackerItems[trackerURL] = item; } @@ -400,6 +401,7 @@ void TrackerListWidget::loadTrackers() } item->setText(COL_MSG, entry.message); + item->setToolTip(COL_MSG, entry.message); item->setText(COL_PEERS, ((entry.numPeers > -1) ? QString::number(entry.numPeers) : tr("N/A"))); From 4dbf6af7338f6a7929a54c79fed0d02592e364aa Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Wed, 7 Jul 2021 13:16:19 +0800 Subject: [PATCH 2/3] Simplify initialization statement --- src/webui/www/private/scripts/dynamicTable.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/webui/www/private/scripts/dynamicTable.js b/src/webui/www/private/scripts/dynamicTable.js index 98e220f18..37519058e 100644 --- a/src/webui/www/private/scripts/dynamicTable.js +++ b/src/webui/www/private/scripts/dynamicTable.js @@ -621,16 +621,16 @@ window.qBittorrent.DynamicTable = (function() { let row; if (!this.rows.has(rowId)) { - row = {}; + row = { + 'full_data': {}, + 'rowId': rowId + }; this.rows.set(rowId, row); - row['full_data'] = {}; - row['rowId'] = rowId; } else row = this.rows.get(rowId); row['data'] = data; - for (const x in data) row['full_data'][x] = data[x]; }, From 8ec26e9ea9c1f6ea4c6ce9bcb0b7d507d294dc2e Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Wed, 7 Jul 2021 14:31:02 +0800 Subject: [PATCH 3/3] Don't use old style casts Ref: https://github.com/qbittorrent/qBittorrent/runs/2996702005?check_suite_focus=true#step:8:298 --- src/gui/macutilities.mm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gui/macutilities.mm b/src/gui/macutilities.mm index 910d77368..60e71cef0 100644 --- a/src/gui/macutilities.mm +++ b/src/gui/macutilities.mm @@ -68,14 +68,14 @@ namespace MacUtils if (class_getInstanceMethod(delClass, shouldHandle)) { - if (class_replaceMethod(delClass, shouldHandle, (IMP)dockClickHandler, "B@:")) + if (class_replaceMethod(delClass, shouldHandle, reinterpret_cast(dockClickHandler), "B@:")) qDebug("Registered dock click handler (replaced original method)"); else qWarning("Failed to replace method for dock click handler"); } else { - if (class_addMethod(delClass, shouldHandle, (IMP)dockClickHandler, "B@:")) + if (class_addMethod(delClass, shouldHandle, reinterpret_cast(dockClickHandler), "B@:")) qDebug("Registered dock click handler"); else qWarning("Failed to register dock click handler");