github/public-apis
1
Fork 0
mirror of https://github.com/public-apis/public-apis synced 2024-11-21 10:04:15 +01:00
Code Releases Activity

Fix false negative http code 404 in verification

Browse Source 
Some links when they were being checked returned the http code 404,
but the links were working correctly.

This was happening because before the request the link was concatenated
with the / character at the end, making it a different link from the
original. If the original link didn't have a path that is
accessed by / at the end, it would return a 404 error.

This behavior made it a false negative.
This commit is contained in:
Matheus Felipe 2022-02-07 07:09:01 -03:00
parent 51b4166a96
commit c2bdd9e5fc
No known key found for this signature in database
GPG Key ID: AA785C523274872F
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/validate/links.py
View File

@ -17,7 +17,7 @@ def find_links_in_text(text: str) -> List[str]:
raw_links = re.findall(link_pattern, text)
links = [
str(raw_link[0]).rstrip('/') for raw_link in raw_links
str(raw_link[0]) for raw_link in raw_links
]
return links
@ -49,6 +49,7 @@ def check_duplicate_links(links: List[str]) -> Tuple[bool, List]:
has_duplicate = False
for link in links:
link = link.rstrip('/')
if link not in seen:
seen[link] = 1
else:
@ -163,7 +164,7 @@ def check_if_link_is_working(link: str) -> Tuple[bool, str]:
error_message = ''
try:
resp = requests.get(link + '/', timeout=25, headers={
resp = requests.get(link, timeout=25, headers={
'User-Agent': fake_user_agent(),
'host': get_host_from_link(link)
})