mirror of
https://github.com/mpv-player/mpv
synced 2024-10-26 07:22:17 +02:00

sd_ass contains some code that treats subtitle events with duration 0
specially, and adjust their duration so that they will disappear with
the next event.
This is most likely not needed anymore. Some subtitle formats allow
omitting the duration so that the event is visible until the next one,
but both subreader.c as well as libavformat subtitle demuxers already
handle this.
Subtitles embedded in mp4 files (movtext) used to trigger this code. But
these files appear to export subtitle duration correctly (at least
libavcodec's movtext decoder is using this assumption). Since commit
6dbedd2
changed demux_lavf to actually copy the packet duration field,
the code removed with this commit isn't needed anymore for correct
display of movtext subtitles. (The change in sd_movtext is for dropping
empty subtitle events, which would now be "displayed" - libavcodec does
the same.)
On the other hand, this code incorrectly displayed hidden events in .srt
subtitles. See for example the first event in SubRip_capability_tester.srt
(part of FFmpeg's FATE). These intentionally have a duration of 0, and
should not be displayed. (As of with this commit, they are still
displayed in external .srt subs because of subreader.c hacks.)
However, we can't be 100% sure that this code is really unneeded, so
just comment the code. Hopefully it can be removed if there are no
regressions after some weeks or months.
340 lines
9.7 KiB
C
340 lines
9.7 KiB
C
/*
|
|
* This file is part of MPlayer.
|
|
*
|
|
* MPlayer is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* MPlayer is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with MPlayer; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include <stdlib.h>
|
|
#include <assert.h>
|
|
#include <string.h>
|
|
|
|
#include <ass/ass.h>
|
|
|
|
#include "talloc.h"
|
|
|
|
#include "core/options.h"
|
|
#include "core/mp_common.h"
|
|
#include "core/mp_msg.h"
|
|
#include "sub.h"
|
|
#include "dec_sub.h"
|
|
#include "ass_mp.h"
|
|
#include "sd.h"
|
|
|
|
// Enable code that treats subtitle events with duration 0 specially, and
|
|
// adjust their duration so that they will disappear with the next event.
|
|
#define INCOMPLETE_EVENTS 0
|
|
|
|
struct sd_ass_priv {
|
|
struct ass_track *ass_track;
|
|
bool vsfilter_aspect;
|
|
bool incomplete_event;
|
|
struct sub_bitmap *parts;
|
|
bool flush_on_seek;
|
|
char last_text[500];
|
|
};
|
|
|
|
static bool supports_format(const char *format)
|
|
{
|
|
// ass-text is produced by converters and the subreader.c ssa parser; this
|
|
// format has ASS tags, but doesn't start with any prelude, nor does it
|
|
// have extradata.
|
|
return format && (strcmp(format, "ass") == 0 ||
|
|
strcmp(format, "ssa") == 0 ||
|
|
strcmp(format, "ass-text") == 0);
|
|
}
|
|
|
|
static void free_last_event(ASS_Track *track)
|
|
{
|
|
assert(track->n_events > 0);
|
|
ass_free_event(track, track->n_events - 1);
|
|
track->n_events--;
|
|
}
|
|
|
|
static int init(struct sd *sd)
|
|
{
|
|
struct MPOpts *opts = sd->opts;
|
|
if (!sd->ass_library || !sd->ass_renderer || !sd->codec)
|
|
return -1;
|
|
|
|
bool is_converted = sd->converted_from != NULL;
|
|
|
|
struct sd_ass_priv *ctx = talloc_zero(NULL, struct sd_ass_priv);
|
|
sd->priv = ctx;
|
|
if (sd->ass_track) {
|
|
ctx->ass_track = sd->ass_track;
|
|
} else {
|
|
ctx->ass_track = ass_new_track(sd->ass_library);
|
|
if (!is_converted)
|
|
ctx->ass_track->track_type = TRACK_TYPE_ASS;
|
|
}
|
|
|
|
if (sd->extradata) {
|
|
ass_process_codec_private(ctx->ass_track, sd->extradata,
|
|
sd->extradata_len);
|
|
}
|
|
|
|
mp_ass_add_default_styles(ctx->ass_track, opts);
|
|
|
|
ctx->vsfilter_aspect = !is_converted;
|
|
return 0;
|
|
}
|
|
|
|
static void decode(struct sd *sd, struct demux_packet *packet)
|
|
{
|
|
void *data = packet->buffer;
|
|
int data_len = packet->len;
|
|
double pts = packet->pts;
|
|
double duration = packet->duration;
|
|
unsigned char *text = data;
|
|
struct sd_ass_priv *ctx = sd->priv;
|
|
ASS_Track *track = ctx->ass_track;
|
|
if (strcmp(sd->codec, "ass") == 0) {
|
|
ass_process_chunk(track, data, data_len,
|
|
(long long)(pts*1000 + 0.5),
|
|
(long long)(duration*1000 + 0.5));
|
|
return;
|
|
} else if (strcmp(sd->codec, "ssa") == 0) {
|
|
// broken ffmpeg ASS packet format
|
|
ctx->flush_on_seek = true;
|
|
ass_process_data(track, data, data_len);
|
|
return;
|
|
}
|
|
// plaintext subs
|
|
if (pts == MP_NOPTS_VALUE) {
|
|
mp_msg(MSGT_SUBREADER, MSGL_WARN, "Subtitle without pts, ignored\n");
|
|
return;
|
|
}
|
|
long long ipts = pts * 1000 + 0.5;
|
|
long long iduration = duration * 1000 + 0.5;
|
|
#if INCOMPLETE_EVENTS
|
|
if (ctx->incomplete_event) {
|
|
ctx->incomplete_event = false;
|
|
ASS_Event *event = track->events + track->n_events - 1;
|
|
if (ipts <= event->Start)
|
|
free_last_event(track);
|
|
else
|
|
event->Duration = ipts - event->Start;
|
|
}
|
|
// Note: we rely on there being guaranteed 0 bytes after data packets
|
|
int len = strlen(text);
|
|
if (len < 5) {
|
|
// Some tracks use a whitespace (but not empty) packet to mark end
|
|
// of previous subtitle.
|
|
for (int i = 0; i < len; i++)
|
|
if (!strchr(" \f\n\r\t\v", text[i]))
|
|
goto not_all_whitespace;
|
|
return;
|
|
}
|
|
not_all_whitespace:;
|
|
if (!sd->no_remove_duplicates) {
|
|
for (int i = 0; i < track->n_events; i++)
|
|
if (track->events[i].Start == ipts
|
|
&& (duration <= 0 || track->events[i].Duration == iduration)
|
|
&& strcmp(track->events[i].Text, text) == 0)
|
|
return; // We've already added this subtitle
|
|
}
|
|
if (duration <= 0) {
|
|
iduration = 10000;
|
|
ctx->incomplete_event = true;
|
|
}
|
|
#else
|
|
if (duration <= 0) {
|
|
mp_msg(MSGT_SUBREADER, MSGL_WARN, "Subtitle without duration or "
|
|
"duration set to 0 at pts %f, ignored\n", pts);
|
|
return;
|
|
}
|
|
if (!sd->no_remove_duplicates) {
|
|
for (int i = 0; i < track->n_events; i++) {
|
|
if (track->events[i].Start == ipts
|
|
&& (track->events[i].Duration == iduration)
|
|
&& strcmp(track->events[i].Text, text) == 0)
|
|
return; // We've already added this subtitle
|
|
}
|
|
}
|
|
#endif
|
|
int eid = ass_alloc_event(track);
|
|
ASS_Event *event = track->events + eid;
|
|
event->Start = ipts;
|
|
event->Duration = iduration;
|
|
event->Style = track->default_style;
|
|
event->Text = strdup(text);
|
|
}
|
|
|
|
static void get_bitmaps(struct sd *sd, struct mp_osd_res dim, double pts,
|
|
struct sub_bitmaps *res)
|
|
{
|
|
struct sd_ass_priv *ctx = sd->priv;
|
|
struct MPOpts *opts = sd->opts;
|
|
|
|
if (pts == MP_NOPTS_VALUE || !sd->ass_renderer)
|
|
return;
|
|
|
|
double scale = dim.display_par;
|
|
bool use_vs_aspect = opts->ass_style_override
|
|
? opts->ass_vsfilter_aspect_compat : 1;
|
|
if (ctx->vsfilter_aspect && use_vs_aspect)
|
|
scale = scale * dim.video_par;
|
|
ASS_Renderer *renderer = sd->ass_renderer;
|
|
mp_ass_configure(renderer, opts, &dim);
|
|
ass_set_aspect_ratio(renderer, scale, 1);
|
|
mp_ass_render_frame(renderer, ctx->ass_track, pts * 1000 + .5,
|
|
&ctx->parts, res);
|
|
talloc_steal(ctx, ctx->parts);
|
|
}
|
|
|
|
struct buf {
|
|
char *start;
|
|
int size;
|
|
int len;
|
|
};
|
|
|
|
static void append(struct buf *b, char c)
|
|
{
|
|
if (b->len < b->size) {
|
|
b->start[b->len] = c;
|
|
b->len++;
|
|
}
|
|
}
|
|
|
|
static void ass_to_plaintext(struct buf *b, const char *in)
|
|
{
|
|
bool in_tag = false;
|
|
bool in_drawing = false;
|
|
while (*in) {
|
|
if (in_tag) {
|
|
if (in[0] == '}') {
|
|
in += 1;
|
|
in_tag = false;
|
|
} else if (in[0] == '\\' && in[1] == 'p') {
|
|
in += 2;
|
|
// skip text between \pN and \p0 tags
|
|
if (in[0] == '0') {
|
|
in_drawing = false;
|
|
} else if (in[0] >= '1' && in[0] <= '9') {
|
|
in_drawing = true;
|
|
}
|
|
} else {
|
|
in += 1;
|
|
}
|
|
} else {
|
|
if (in[0] == '\\' && (in[1] == 'N' || in[1] == 'n')) {
|
|
in += 2;
|
|
append(b, '\n');
|
|
} else if (in[0] == '\\' && in[1] == 'h') {
|
|
in += 2;
|
|
append(b, ' ');
|
|
} else if (in[0] == '{') {
|
|
in += 1;
|
|
in_tag = true;
|
|
} else {
|
|
if (!in_drawing)
|
|
append(b, in[0]);
|
|
in += 1;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Empty string counts as whitespace. Reads s[len-1] even if there are \0s.
|
|
static bool is_whitespace_only(char *s, int len)
|
|
{
|
|
for (int n = 0; n < len; n++) {
|
|
if (s[n] != ' ' && s[n] != '\t')
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static char *get_text(struct sd *sd, double pts)
|
|
{
|
|
struct sd_ass_priv *ctx = sd->priv;
|
|
ASS_Track *track = ctx->ass_track;
|
|
|
|
if (pts == MP_NOPTS_VALUE)
|
|
return NULL;
|
|
|
|
struct buf b = {ctx->last_text, sizeof(ctx->last_text) - 1};
|
|
|
|
for (int i = 0; i < track->n_events; ++i) {
|
|
ASS_Event *event = track->events + i;
|
|
double start = event->Start / 1000.0;
|
|
double end = (event->Start + event->Duration) / 1000.0;
|
|
if (pts >= start && pts < end) {
|
|
if (event->Text) {
|
|
int start = b.len;
|
|
ass_to_plaintext(&b, event->Text);
|
|
if (!is_whitespace_only(&b.start[b.len], b.len - start))
|
|
append(&b, '\n');
|
|
}
|
|
}
|
|
}
|
|
|
|
b.start[b.len] = '\0';
|
|
|
|
if (b.len > 0 && b.start[b.len - 1] == '\n')
|
|
b.start[b.len - 1] = '\0';
|
|
|
|
return ctx->last_text;
|
|
}
|
|
|
|
static void fix_events(struct sd *sd)
|
|
{
|
|
struct sd_ass_priv *ctx = sd->priv;
|
|
ctx->flush_on_seek = false;
|
|
}
|
|
|
|
static void reset(struct sd *sd)
|
|
{
|
|
struct sd_ass_priv *ctx = sd->priv;
|
|
if (ctx->incomplete_event)
|
|
free_last_event(ctx->ass_track);
|
|
ctx->incomplete_event = false;
|
|
if (ctx->flush_on_seek)
|
|
ass_flush_events(ctx->ass_track);
|
|
ctx->flush_on_seek = false;
|
|
}
|
|
|
|
static void uninit(struct sd *sd)
|
|
{
|
|
struct sd_ass_priv *ctx = sd->priv;
|
|
|
|
if (sd->ass_track != ctx->ass_track)
|
|
ass_free_track(ctx->ass_track);
|
|
talloc_free(ctx);
|
|
}
|
|
|
|
const struct sd_functions sd_ass = {
|
|
.name = "ass",
|
|
.accept_packets_in_advance = true,
|
|
.supports_format = supports_format,
|
|
.init = init,
|
|
.decode = decode,
|
|
.get_bitmaps = get_bitmaps,
|
|
.get_text = get_text,
|
|
.fix_events = fix_events,
|
|
.reset = reset,
|
|
.uninit = uninit,
|
|
};
|
|
|
|
struct ass_track *sub_get_ass_track(struct dec_sub *sub)
|
|
{
|
|
struct sd *sd = sub_get_last_sd(sub);
|
|
if (sd && sd->driver == &sd_ass && sd->priv) {
|
|
struct sd_ass_priv *ctx = sd->priv;
|
|
return ctx->ass_track;
|
|
}
|
|
return NULL;
|
|
}
|