github/mpv
1
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2024-11-14 22:48:35 +01:00
Code Releases Activity

command: fix dangling pointer issue in script key bindings code

Browse Source 
This code was sending a string to a different thread, and then
deallocated the string shortly after, which means most of the time
the other thread was accessing a dangling pointer.

It's possible that this is the cause for #1002.
This commit is contained in:
wm4 2014-08-11 13:00:57 +02:00
parent ece61bfa10
commit b016f92309
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
player/command.c
View File

@ -3894,7 +3894,7 @@ int run_command(MPContext *mpctx, mp_cmd_t *cmd)
*event = (mpv_event_client_message){0};
for (int n = 1; n < cmd->nargs; n++) {
MP_TARRAY_APPEND(event, event->args, event->num_args,
cmd->args[n].v.s);
talloc_strdup(event, cmd->args[n].v.s));
}
if (mp_client_send_event(mpctx, cmd->args[0].v.s,
MPV_EVENT_CLIENT_MESSAGE, event) < 0)