github
/
mpv
mirror of https://github.com/mpv-player/mpv
1
Fork 0
Code Releases Activity

Revert "vo_dmabuf_wayland: assume counter-clockwise rotations" 

This commit was originally sparked by a change in sway. When looking at
the wording of the spec, it was believed that the rotation should be
counter-clockwise. But that was interpreted incorrectly. The rotation
direction in the spec is meant for compositors not clients. Clients
should be rotating clockwise and compositors rotate it the opposite
direction. Also see the discussion in upstream wayland*.

*: https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/369

This reverts commit 27ef1725e7.
This commit is contained in:
Dudemanguy 2024-04-08 14:02:57 -05:00
parent d3941f235a
commit 0d250892ba
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
video/out/vo_dmabuf_wayland.c
View File

@ -695,10 +695,7 @@ done:
if (!vo_wayland_reconfig(vo))
return VO_ERROR;
// mpv rotates clockwise but the wayland spec has counter-clockwise rotations
// swap 1 and 3 to match mpv's direction
int transform = (360 - img->params.rotate) % 360 / 90;
wl_surface_set_buffer_transform(vo->wl->video_surface, transform);
wl_surface_set_buffer_transform(vo->wl->video_surface, img->params.rotate / 90);
// Immediately destroy all buffers if params change.
destroy_buffers(vo);