From e73e1e7e6f505a000b517fb6a867783c170d65d4 Mon Sep 17 00:00:00 2001 From: Kevin Thomas Date: Fri, 31 Dec 2021 01:05:22 -0800 Subject: [PATCH] Use CMD in Dockerfile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit According to Dockerfile best practices (https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#entrypoint) the best use for ENTRYPOINT is to set the image’s main command and then use CMD as the default flags. This makes it easier to change the flags passed to monerod when running the Docker image. --- Dockerfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 587007470..1c373cbc9 100644 --- a/Dockerfile +++ b/Dockerfile @@ -61,5 +61,6 @@ EXPOSE 18081 # switch to user monero USER monero -ENTRYPOINT ["monerod", "--p2p-bind-ip=0.0.0.0", "--p2p-bind-port=18080", "--rpc-bind-ip=0.0.0.0", "--rpc-bind-port=18081", "--non-interactive", "--confirm-external-bind"] +ENTRYPOINT ["monerod"] +CMD ["--p2p-bind-ip=0.0.0.0", "--p2p-bind-port=18080", "--rpc-bind-ip=0.0.0.0", "--rpc-bind-port=18081", "--non-interactive", "--confirm-external-bind"]