mirror of
https://github.com/rapid7/metasploit-payloads
synced 2025-03-24 18:16:24 +01:00
57eda40fc7
I am sad. Like.. really sad. I'm sad for so many reasons. For nearly 7 years I've worked on this god forsaken source, and for many of those 7 years I have had the ext_server_mimikatz project configured to have warning level 3, and warnings as errors. While making changes to the build systems in the last week or so, I've even rebuilt this on updated toolsets on multiple platforms. Despite all this, one thing slipped through the cracks. I have NO idea why this warning wasn't shown in th past. Also.. how did this ever work!? Why is it that it's only rearing its ugly head now? I honestly don't know. Based on the code that I've had to fix in this PR, there's no reason why this should build without warnings on any machine. Yet, it does. It builds clean on my Windows 10 desktop with VS2013/2017/2019. Same on most of my other virtual machines. For some reason it only failed on this one VM after I had to fight to reproduce it when Brent hand an issue. The issue here was that a `string` type was being constructed from an iterator over a `wstring` type, and hence there was an implicit character conversion from `wchar_t` to `char`. This SHOULD be a warning, because clearly that's not a good thing. BUT HERE WE ARE. Anyway, we're proxying via the `_bstr_t` type now to avoid having to do horrible manual character conversions. Given that we're in C++ land already there's no point in working any harder. Also, this extension is probably going to go away soon anyway, so a temporary fix that does the job is good enough. RIP my morning. I won't be getting that back.
metasploit-payloads >
Appveyor build status:
This is a unified repository for different Metasploit Framework payloads, which merges these repositories:
An alternate cross-platform C Meterpreter, called Mettle, is developed at https://github.com/rapid7/mettle
See the individual directories for meterpreter-specific README, build instructions and license details: