Brent Cook
25731fee03
free utf8 conversion strings and avoid non-null terminated values
2015-06-04 09:00:24 -05:00
Brent Cook
773008d921
whitespace tweaks
2015-06-04 08:50:24 -05:00
David Maloney
2b07377328
fix copy error
...
use strncpy not memcpy to transfer the re-encoded
name and description into our account object.
also use sizeof for precise copy size. eliminates lingering
errors
MSP-12356
2015-06-02 12:44:49 -05:00
David Maloney
84cea10260
use all unicode for ntds account struct
...
force convert account name and description
to unicode for transport over the wire
MSP-12356
2015-06-02 12:35:30 -05:00
David Maloney
a3b4b53029
size and signedness issue fixes
...
fixes several size and signedness issues caught
during code review
MSP-12356
2015-05-18 11:08:58 -05:00
David Maloney
7595156c90
make jet instance name unique
...
use date and time to make sure the Jet
Instance name is unique. Hasn't actually
solved our issue, but that name is supposed
to be unique anyways.
MSP-12356
2015-05-07 12:39:46 -05:00
David Maloney
2fa794f1c9
more cleanup/split up
...
split the date stuff up into their own subfunction tooo
MSP-12356
2015-05-06 14:00:15 -05:00
David Maloney
1daa927175
split off hash reading functions
...
moved the reading o the nt and lm hash records
into seperate sub functions. more cleanup/readability work
MSP-12356
2015-05-06 13:30:44 -05:00
David Maloney
bc5b6a1554
split off hash history reading
...
moved the hash history read into a seperate sub function
to make it easier to read
MSP-12356
2015-05-06 13:20:21 -05:00
David Maloney
879d062aa0
un typedef structs
...
bcook says to not typedef structs and just use them as
raw structs, so i have made that conversion here
MSP-12356
2015-05-06 11:24:06 -05:00
David Maloney
dff1a12c38
some more code cleanup
...
just some various bits and bobs here to make
the code a little cleaner and easier to read
MSP-12356
2015-05-06 10:42:03 -05:00
David Maloney
a8b4010ed0
cleanup #get_column_info a bit
...
bcook showed me how to do this the way i originally
wanted to but didn't know how. This is much cleaner to read
MSP-12356
2015-05-06 10:31:18 -05:00
David Maloney
df1181fe32
cleanup flag conversion
...
use simpler conversion of bit flags to
quasi-boolean values. just a little space saved and easier to read hopefully
MSP-12356
2015-05-06 09:54:36 -05:00
David Maloney
39d1860f7d
switch from malloc to calloc
...
calloc does our memory init for us
so all the malloc/memset usage was totally
redudnant
MSP-12356
2015-05-06 09:45:31 -05:00
David Maloney
9d1af4c696
add doxygen to new code
...
added doygen style comments to the new NTDS
functions and typedefs as requested by OJ.
MSP-12356
2015-05-05 13:32:32 -05:00
David Maloney
e0665a2ba5
add some additional function comments
...
add some basic function documentation in
the form of comments. not eprfect, but a start
on propper documentation
MSP-12356
2015-05-04 11:14:42 -05:00
David Maloney
c9cf6be97a
more memory cleanup
...
more missing free calls
MSP-12356
2015-04-30 15:43:58 -05:00
David Maloney
3ebf0513b0
properly cleanup memory around hash history
...
we were not freeing the buffers we created
as palceholders for decrypting hash history.
this would cause crashes when we wold start dealing
with multiple accounts in a row with a hash history.
freeing the buffers seems to fix the problem
MSP-12356
2015-04-30 13:15:17 -05:00
David Maloney
3bfeec2a7a
w00t pulled an account down
...
successfully pulled an account down over the chanel
MSP-12356
2015-04-24 13:04:36 -05:00
David Maloney
52571872c4
move to the first user record
...
move through the datatable until we find
the first sam user object.
MSP-12356
2015-04-23 16:51:07 -05:00
David Maloney
54b91aab08
clean build
...
the project now builds cleanly. the code isn't fully itnegrated
but it's in there and it builds which means it's nearly
perfect =P
MSP-12356
2015-04-23 11:53:33 -05:00
David Maloney
2769d986fe
migrate all the poc code in
...
all of the poc libs are migrated in,
compiler warnings are blocking compile at this moment
2015-04-23 10:39:25 -05:00
David Maloney
85987b9cbe
start migrating ntds code in
...
moving the code chunks from the poc into
the actual meterp project
2015-04-22 16:03:30 -05:00