Merge pull request #1 from bcook-r7/land-5-maven-fixes

update sample module code and provide property defaults

java/meterpreter/extension-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml

@@ -5,6 +5,15 @@
 		name="Java Meterpreter extension archetype">
 	<requiredProperties>
 		<requiredProperty key="pluginName" />
+		<requiredProperty key="groupId">
+			<defaultValue>com.metasploit</defaultValue>
+		</requiredProperty>
+		<requiredProperty key="artifactId">
+			<defaultValue>Metasploit-Java-Meterpreter-${pluginName}</defaultValue>
+		</requiredProperty>
+		<requiredProperty key="package">
+			<defaultValue>com.metasploit.meterpreter.${pluginName}</defaultValue>
+		</requiredProperty>
 	</requiredProperties>
 	<fileSets>
 	<fileSet filtered="true" packaged="true" encoding="UTF-8">

java/meterpreter/extension-archetype/src/main/resources/archetype-resources/__pluginName__.rb

@@ -1,13 +1,15 @@
+# -*- coding: binary -*-
+
 module Rex
   module Post
     module Meterpreter
       module Extensions
+        # This module contains a 'Hello World' meterpreter extension
         module ${pluginName.substring(0,1).toUpperCase()}${pluginName.substring(1)}
+          TLV_TYPE_GREETEE = TLV_META_TYPE_STRING | (TLV_EXTENSIONS + 1)
 
-TLV_TYPE_GREETEE = TLV_META_TYPE_STRING | (TLV_EXTENSIONS + 1);
+          # This module implements a 'Hello World' meterpreter extension
-
           class ${pluginName.substring(0,1).toUpperCase()}${pluginName.substring(1)} < Extension
-
             def initialize(client)
               super(client, '${pluginName}')
 
@@ -20,18 +22,27 @@ class ${pluginName.substring(0,1).toUpperCase()}${pluginName.substring(1)} < Ext
                 ])
             end
 
-	def ${pluginName}_greet_world()
+            # Sends a greet_world request and gets a reply
+            #
+            # @return [String]
+            def ${pluginName}_greet_world
               request = Packet.create_request('${pluginName}_greet_world')
               response = client.send_request(request)
-		return response.get_tlv_value(TLV_TYPE_STRING)
+              response.get_tlv_value(TLV_TYPE_STRING)
             end
 
+            # Sends a greet_someone request and gets a reply
+            #
+            # @return [String]
             def ${pluginName}_greet_someone(greetee)
               request = Packet.create_request('${pluginName}_greet_someone')
               request.add_tlv(TLV_TYPE_GREETEE, greetee)
               response = client.send_request(request)
-		return response.get_tlv_value(TLV_TYPE_STRING)
+              response.get_tlv_value(TLV_TYPE_STRING)
+            end
+          end
+        end
+      end
+    end
   end
 end
-
-end; end; end; end; end