1
mirror of https://github.com/rapid7/metasploit-framework synced 2024-11-12 11:52:01 +01:00

modules should not handle exceptions like this. if you're just going to print a backtrace, let the dispatcher deal with it so we can get logs

git-svn-id: file:///home/svn/framework3/trunk@7353 4d416f70-5f16-0410-b530-b9f4589650da
This commit is contained in:
James Lee 2009-11-04 17:04:01 +00:00
parent 34d76a72e0
commit 68564f9d5e
2 changed files with 4 additions and 14 deletions

View File

@ -84,16 +84,10 @@ class Metasploit3 < Msf::Exploit::Remote
return if ((p = regenerate_payload(cli)) == nil)
# Transmit the response to the client
begin
send_response(cli, generate_zip(p), { 'Content-Type' => 'application/zip' } )
# Handle the payload
handler(cli)
rescue ::Exception => e
$stderr.puts "Error: #{e}"
$stderr.puts e.backtrace.join("\n")+"\n\n"
end
send_response(cli, generate_zip(p), { 'Content-Type' => 'application/zip' } )
# Handle the payload
handler(cli)
end
def generate_zip(shellcode)

View File

@ -135,11 +135,7 @@ class Metasploit3 < Msf::Exploit::Remote
handler
rescue EOFError
rescue => e
$stderr.puts "Error: #{e} #{e.class}"
end
end