From 251ecc3b0ba95b20bbbf9a68a67e204c81d4175e Mon Sep 17 00:00:00 2001
From: philsmd <philsmd@hashcat.net>
Date: Wed, 9 Feb 2022 16:43:24 +0100
Subject: [PATCH] fixes #3029: cracking long salts in -m 4510/4710
---
OpenCL/m04510_a0-optimized.cl | 24 ++++++++++++++----------
OpenCL/m04510_a1-optimized.cl | 24 ++++++++++++++----------
OpenCL/m04510_a3-optimized.cl | 24 ++++++++++++++----------
OpenCL/m04710_a0-optimized.cl | 23 ++++++++++++++---------
OpenCL/m04710_a1-optimized.cl | 23 ++++++++++++++---------
OpenCL/m04710_a3-optimized.cl | 23 ++++++++++++++---------
docs/changes.txt | 1 +
src/modules/module_04510.c | 13 ++++++++++++-
src/modules/module_04710.c | 13 ++++++++++++-
tools/test_modules/m04510.pm | 2 +-
tools/test_modules/m04710.pm | 2 +-
11 files changed, 111 insertions(+), 61 deletions(-)
diff --git a/OpenCL/m04510_a0-optimized.cl b/OpenCL/m04510_a0-optimized.cl
index 280526e12..42dbdc1ce 100644
--- a/OpenCL/m04510_a0-optimized.cl
+++ b/OpenCL/m04510_a0-optimized.cl
@@ -1015,6 +1015,11 @@ KERNEL_FQ void m04510_m04 (KERN_ATTR_RULES ())
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u);
SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_M_SIMD (d, e, c, b);
}
}
@@ -1113,12 +1118,6 @@ KERNEL_FQ void m04510_s04 (KERN_ATTR_RULES ())
digests_buf[DIGESTS_OFFSET_HOST].digest_buf[DGST_R3]
};
- /**
- * reverse
- */
-
- const u32 e_rev = hc_rotl32_S (search[1], 2u);
-
/**
* loop
*/
@@ -2024,19 +2023,24 @@ KERNEL_FQ void m04510_s04 (KERN_ATTR_RULES ())
SHA1_STEP (SHA1_F1, b, c, d, e, a, wa_t);
wb_t = hc_rotl32 ((w8_t ^ w3_t ^ wd_t ^ wb_t), 1u);
SHA1_STEP (SHA1_F1, a, b, c, d, e, wb_t);
-
- if (MATCHES_NONE_VS (e, e_rev))
- continue;
-
wc_t = hc_rotl32 ((w9_t ^ w4_t ^ we_t ^ wc_t), 1u);
SHA1_STEP (SHA1_F1, e, a, b, c, d, wc_t);
wd_t = hc_rotl32 ((wa_t ^ w5_t ^ wf_t ^ wd_t), 1u);
SHA1_STEP (SHA1_F1, d, e, a, b, c, wd_t);
+
+ if (MATCHES_NONE_VS (e + digest[4] - SHA1M_E, search[1]))
+ continue;
+
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u);
SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u);
SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_S_SIMD (d, e, c, b);
}
}
diff --git a/OpenCL/m04510_a1-optimized.cl b/OpenCL/m04510_a1-optimized.cl
index 5b0bea450..9b7f0b7a9 100644
--- a/OpenCL/m04510_a1-optimized.cl
+++ b/OpenCL/m04510_a1-optimized.cl
@@ -1070,6 +1070,11 @@ KERNEL_FQ void m04510_m04 (KERN_ATTR_BASIC ())
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u);
SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_M_SIMD (d, e, c, b);
}
}
@@ -1168,12 +1173,6 @@ KERNEL_FQ void m04510_s04 (KERN_ATTR_BASIC ())
digests_buf[DIGESTS_OFFSET_HOST].digest_buf[DGST_R3]
};
- /**
- * reverse
- */
-
- const u32 e_rev = hc_rotl32_S (search[1], 2u);
-
/**
* loop
*/
@@ -2136,19 +2135,24 @@ KERNEL_FQ void m04510_s04 (KERN_ATTR_BASIC ())
SHA1_STEP (SHA1_F1, b, c, d, e, a, wa_t);
wb_t = hc_rotl32 ((w8_t ^ w3_t ^ wd_t ^ wb_t), 1u);
SHA1_STEP (SHA1_F1, a, b, c, d, e, wb_t);
-
- if (MATCHES_NONE_VS (e, e_rev))
- continue;
-
wc_t = hc_rotl32 ((w9_t ^ w4_t ^ we_t ^ wc_t), 1u);
SHA1_STEP (SHA1_F1, e, a, b, c, d, wc_t);
wd_t = hc_rotl32 ((wa_t ^ w5_t ^ wf_t ^ wd_t), 1u);
SHA1_STEP (SHA1_F1, d, e, a, b, c, wd_t);
+
+ if (MATCHES_NONE_VS (e + digest[4] - SHA1M_E, search[1]))
+ continue;
+
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u);
SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u);
SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_S_SIMD (d, e, c, b);
}
}
diff --git a/OpenCL/m04510_a3-optimized.cl b/OpenCL/m04510_a3-optimized.cl
index 306daf8a0..baa17e789 100644
--- a/OpenCL/m04510_a3-optimized.cl
+++ b/OpenCL/m04510_a3-optimized.cl
@@ -969,6 +969,11 @@ DECLSPEC void m04510m (PRIVATE_AS u32 *w0, PRIVATE_AS u32 *w1, PRIVATE_AS u32 *w
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u);
SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_M_SIMD (d, e, c, b);
}
}
@@ -1018,12 +1023,6 @@ DECLSPEC void m04510s (PRIVATE_AS u32 *w0, PRIVATE_AS u32 *w1, PRIVATE_AS u32 *w
digests_buf[DIGESTS_OFFSET_HOST].digest_buf[DGST_R3]
};
- /**
- * reverse
- */
-
- const u32 e_rev = hc_rotl32_S (search[1], 2u);
-
/**
* loop
*/
@@ -1926,19 +1925,24 @@ DECLSPEC void m04510s (PRIVATE_AS u32 *w0, PRIVATE_AS u32 *w1, PRIVATE_AS u32 *w
SHA1_STEP (SHA1_F1, b, c, d, e, a, wa_t);
wb_t = hc_rotl32 ((w8_t ^ w3_t ^ wd_t ^ wb_t), 1u);
SHA1_STEP (SHA1_F1, a, b, c, d, e, wb_t);
-
- if (MATCHES_NONE_VS (e, e_rev))
- continue;
-
wc_t = hc_rotl32 ((w9_t ^ w4_t ^ we_t ^ wc_t), 1u);
SHA1_STEP (SHA1_F1, e, a, b, c, d, wc_t);
wd_t = hc_rotl32 ((wa_t ^ w5_t ^ wf_t ^ wd_t), 1u);
SHA1_STEP (SHA1_F1, d, e, a, b, c, wd_t);
+
+ if (MATCHES_NONE_VS (e + digest[4] - SHA1M_E, search[1]))
+ continue;
+
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u);
SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u);
SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_S_SIMD (d, e, c, b);
}
}
diff --git a/OpenCL/m04710_a0-optimized.cl b/OpenCL/m04710_a0-optimized.cl
index d7098e09a..4d6c1f8fd 100644
--- a/OpenCL/m04710_a0-optimized.cl
+++ b/OpenCL/m04710_a0-optimized.cl
@@ -715,6 +715,11 @@ KERNEL_FQ void m04710_m04 (KERN_ATTR_RULES ())
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_M_SIMD (d, e, c, b);
}
}
@@ -814,12 +819,6 @@ KERNEL_FQ void m04710_s04 (KERN_ATTR_RULES ())
digests_buf[DIGESTS_OFFSET_HOST].digest_buf[DGST_R3]
};
- /**
- * reverse
- */
-
- const u32 e_rev = hc_rotl32_S (search[1], 2u);
-
/**
* loop
*/
@@ -1426,14 +1425,20 @@ KERNEL_FQ void m04710_s04 (KERN_ATTR_RULES ())
w9_t = hc_rotl32 ((w6_t ^ w1_t ^ wb_t ^ w9_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, w9_t);
wa_t = hc_rotl32 ((w7_t ^ w2_t ^ wc_t ^ wa_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wa_t);
wb_t = hc_rotl32 ((w8_t ^ w3_t ^ wd_t ^ wb_t), 1u); SHA1_STEP (SHA1_F1, a, b, c, d, e, wb_t);
-
- if (MATCHES_NONE_VS (e, e_rev)) continue;
-
wc_t = hc_rotl32 ((w9_t ^ w4_t ^ we_t ^ wc_t), 1u); SHA1_STEP (SHA1_F1, e, a, b, c, d, wc_t);
wd_t = hc_rotl32 ((wa_t ^ w5_t ^ wf_t ^ wd_t), 1u); SHA1_STEP (SHA1_F1, d, e, a, b, c, wd_t);
+
+ if (MATCHES_NONE_VS (e + digest[4] - SHA1M_E, search[1]))
+ continue;
+
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_S_SIMD (d, e, c, b);
}
}
diff --git a/OpenCL/m04710_a1-optimized.cl b/OpenCL/m04710_a1-optimized.cl
index 0c7c10390..6a68a527d 100644
--- a/OpenCL/m04710_a1-optimized.cl
+++ b/OpenCL/m04710_a1-optimized.cl
@@ -768,6 +768,11 @@ KERNEL_FQ void m04710_m04 (KERN_ATTR_BASIC ())
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_M_SIMD (d, e, c, b);
}
}
@@ -867,12 +872,6 @@ KERNEL_FQ void m04710_s04 (KERN_ATTR_BASIC ())
digests_buf[DIGESTS_OFFSET_HOST].digest_buf[DGST_R3]
};
- /**
- * reverse
- */
-
- const u32 e_rev = hc_rotl32_S (search[1], 2u);
-
/**
* loop
*/
@@ -1534,14 +1533,20 @@ KERNEL_FQ void m04710_s04 (KERN_ATTR_BASIC ())
w9_t = hc_rotl32 ((w6_t ^ w1_t ^ wb_t ^ w9_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, w9_t);
wa_t = hc_rotl32 ((w7_t ^ w2_t ^ wc_t ^ wa_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wa_t);
wb_t = hc_rotl32 ((w8_t ^ w3_t ^ wd_t ^ wb_t), 1u); SHA1_STEP (SHA1_F1, a, b, c, d, e, wb_t);
-
- if (MATCHES_NONE_VS (e, e_rev)) continue;
-
wc_t = hc_rotl32 ((w9_t ^ w4_t ^ we_t ^ wc_t), 1u); SHA1_STEP (SHA1_F1, e, a, b, c, d, wc_t);
wd_t = hc_rotl32 ((wa_t ^ w5_t ^ wf_t ^ wd_t), 1u); SHA1_STEP (SHA1_F1, d, e, a, b, c, wd_t);
+
+ if (MATCHES_NONE_VS (e + digest[4] - SHA1M_E, search[1]))
+ continue;
+
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_S_SIMD (d, e, c, b);
}
}
diff --git a/OpenCL/m04710_a3-optimized.cl b/OpenCL/m04710_a3-optimized.cl
index 1c2d6e95f..91691afae 100644
--- a/OpenCL/m04710_a3-optimized.cl
+++ b/OpenCL/m04710_a3-optimized.cl
@@ -683,6 +683,11 @@ DECLSPEC void m04710m (PRIVATE_AS u32 *w0, PRIVATE_AS u32 *w1, PRIVATE_AS u32 *w
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_M_SIMD (d, e, c, b);
}
}
@@ -733,12 +738,6 @@ DECLSPEC void m04710s (PRIVATE_AS u32 *w0, PRIVATE_AS u32 *w1, PRIVATE_AS u32 *w
digests_buf[DIGESTS_OFFSET_HOST].digest_buf[DGST_R3]
};
- /**
- * reverse
- */
-
- const u32 e_rev = hc_rotl32_S (search[1], 2u);
-
/**
* loop
*/
@@ -1356,14 +1355,20 @@ DECLSPEC void m04710s (PRIVATE_AS u32 *w0, PRIVATE_AS u32 *w1, PRIVATE_AS u32 *w
w9_t = hc_rotl32 ((w6_t ^ w1_t ^ wb_t ^ w9_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, w9_t);
wa_t = hc_rotl32 ((w7_t ^ w2_t ^ wc_t ^ wa_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wa_t);
wb_t = hc_rotl32 ((w8_t ^ w3_t ^ wd_t ^ wb_t), 1u); SHA1_STEP (SHA1_F1, a, b, c, d, e, wb_t);
-
- if (MATCHES_NONE_VS (e, e_rev)) continue;
-
wc_t = hc_rotl32 ((w9_t ^ w4_t ^ we_t ^ wc_t), 1u); SHA1_STEP (SHA1_F1, e, a, b, c, d, wc_t);
wd_t = hc_rotl32 ((wa_t ^ w5_t ^ wf_t ^ wd_t), 1u); SHA1_STEP (SHA1_F1, d, e, a, b, c, wd_t);
+
+ if (MATCHES_NONE_VS (e + digest[4] - SHA1M_E, search[1]))
+ continue;
+
we_t = hc_rotl32 ((wb_t ^ w6_t ^ w0_t ^ we_t), 1u); SHA1_STEP (SHA1_F1, c, d, e, a, b, we_t);
wf_t = hc_rotl32 ((wc_t ^ w7_t ^ w1_t ^ wf_t), 1u); SHA1_STEP (SHA1_F1, b, c, d, e, a, wf_t);
+ b += digest[1] - SHA1M_B;
+ c += digest[2] - SHA1M_C;
+ d += digest[3] - SHA1M_D;
+ e += digest[4] - SHA1M_E;
+
COMPARE_S_SIMD (d, e, c, b);
}
}
diff --git a/docs/changes.txt b/docs/changes.txt
index d3692495e..41a6ef347 100644
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -26,6 +26,7 @@
- Fixed building error on Raspberry Pi
- Fixed false negative on Unit Test in case of out-of-memory with grep in single mode
- Fixed false negative on Unit Test with hash-type 25400
+- Fixed false negative on hash-types 4510 and 4710 for hashes with long salts
- Fixed functional error when nonce-error-corrections that were set on the command line in hash-mode 22000/22001 were not accepted
- Fixed handling of devices in benchmark mode for "kernel build error". Instead of canceling, skip the device and move on to the next
- Fixed handling of password candidates that are shorter than the minimum password length in Association Attack
diff --git a/src/modules/module_04510.c b/src/modules/module_04510.c
index 1ed2cc140..23aa8e962 100644
--- a/src/modules/module_04510.c
+++ b/src/modules/module_04510.c
@@ -46,6 +46,17 @@ u32 module_salt_type (MAYBE_UNUSED const hashconfig_t *hashconfig,
const char *module_st_hash (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra) { return ST_HASH; }
const char *module_st_pass (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra) { return ST_PASS; }
+u32 module_salt_max (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra)
+{
+ const bool optimized_kernel = (hashconfig->opti_type & OPTI_TYPE_OPTIMIZED_KERNEL);
+
+ // allow 64 bytes salts instead of 51 (default salt max for optimized: SALT_MAX_OLD)
+
+ const u32 salt_max = (optimized_kernel == true) ? 64 : hashconfig->salt_max;
+
+ return salt_max;
+}
+
int module_hash_decode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED void *digest_buf, MAYBE_UNUSED salt_t *salt, MAYBE_UNUSED void *esalt_buf, MAYBE_UNUSED void *hook_salt_buf, MAYBE_UNUSED hashinfo_t *hash_info, const char *line_buf, MAYBE_UNUSED const int line_len)
{
u32 *digest = (u32 *) digest_buf;
@@ -226,7 +237,7 @@ void module_init (module_ctx_t *module_ctx)
module_ctx->module_pwdump_column = MODULE_DEFAULT;
module_ctx->module_pw_max = MODULE_DEFAULT;
module_ctx->module_pw_min = MODULE_DEFAULT;
- module_ctx->module_salt_max = MODULE_DEFAULT;
+ module_ctx->module_salt_max = module_salt_max;
module_ctx->module_salt_min = MODULE_DEFAULT;
module_ctx->module_salt_type = module_salt_type;
module_ctx->module_separator = MODULE_DEFAULT;
diff --git a/src/modules/module_04710.c b/src/modules/module_04710.c
index 95174240a..3f562620e 100644
--- a/src/modules/module_04710.c
+++ b/src/modules/module_04710.c
@@ -46,6 +46,17 @@ u32 module_salt_type (MAYBE_UNUSED const hashconfig_t *hashconfig,
const char *module_st_hash (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra) { return ST_HASH; }
const char *module_st_pass (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra) { return ST_PASS; }
+u32 module_salt_max (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra)
+{
+ const bool optimized_kernel = (hashconfig->opti_type & OPTI_TYPE_OPTIMIZED_KERNEL);
+
+ // allow 64 bytes salts instead of 51 (default salt max for optimized: SALT_MAX_OLD)
+
+ const u32 salt_max = (optimized_kernel == true) ? 64 : hashconfig->salt_max;
+
+ return salt_max;
+}
+
int module_hash_decode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED void *digest_buf, MAYBE_UNUSED salt_t *salt, MAYBE_UNUSED void *esalt_buf, MAYBE_UNUSED void *hook_salt_buf, MAYBE_UNUSED hashinfo_t *hash_info, const char *line_buf, MAYBE_UNUSED const int line_len)
{
u32 *digest = (u32 *) digest_buf;
@@ -226,7 +237,7 @@ void module_init (module_ctx_t *module_ctx)
module_ctx->module_pwdump_column = MODULE_DEFAULT;
module_ctx->module_pw_max = MODULE_DEFAULT;
module_ctx->module_pw_min = MODULE_DEFAULT;
- module_ctx->module_salt_max = MODULE_DEFAULT;
+ module_ctx->module_salt_max = module_salt_max;
module_ctx->module_salt_min = MODULE_DEFAULT;
module_ctx->module_salt_type = module_salt_type;
module_ctx->module_separator = MODULE_DEFAULT;
diff --git a/tools/test_modules/m04510.pm b/tools/test_modules/m04510.pm
index d016b6483..5256895ec 100644
--- a/tools/test_modules/m04510.pm
+++ b/tools/test_modules/m04510.pm
@@ -10,7 +10,7 @@ use warnings;
use Digest::SHA qw (sha1_hex);
-sub module_constraints { [[0, 256], [0, 256], [0, 55], [0, 15], [-1, -1]] }
+sub module_constraints { [[0, 256], [0, 256], [0, 55], [0, 64], [-1, -1]] }
sub module_generate_hash
{
diff --git a/tools/test_modules/m04710.pm b/tools/test_modules/m04710.pm
index 824676936..cbf923cbe 100644
--- a/tools/test_modules/m04710.pm
+++ b/tools/test_modules/m04710.pm
@@ -11,7 +11,7 @@ use warnings;
use Digest::MD5 qw (md5_hex);
use Digest::SHA qw (sha1_hex);
-sub module_constraints { [[0, 256], [0, 256], [0, 55], [0, 15], [-1, -1]] }
+sub module_constraints { [[0, 256], [0, 256], [0, 55], [0, 64], [-1, -1]] }
sub module_generate_hash
{