1
mirror of https://github.com/home-assistant/frontend synced 2024-10-03 06:57:32 +02:00

dont allow UI editor when templates are used in repeat (#19188)

This commit is contained in:
Bram Kragten 2023-12-29 18:59:11 +01:00 committed by GitHub
parent 442cce1574
commit cb568d005e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,4 +1,4 @@
import { css, CSSResultGroup, html, LitElement } from "lit"; import { css, CSSResultGroup, html, LitElement, PropertyValues } from "lit";
import { customElement, property } from "lit/decorators"; import { customElement, property } from "lit/decorators";
import memoizeOne from "memoize-one"; import memoizeOne from "memoize-one";
import { fireEvent } from "../../../../../common/dom/fire_event"; import { fireEvent } from "../../../../../common/dom/fire_event";
@ -12,6 +12,7 @@ import type { ActionElement } from "../ha-automation-action-row";
import type { LocalizeFunc } from "../../../../../common/translations/localize"; import type { LocalizeFunc } from "../../../../../common/translations/localize";
import "../../../../../components/ha-form/ha-form"; import "../../../../../components/ha-form/ha-form";
import type { SchemaUnion } from "../../../../../components/ha-form/types"; import type { SchemaUnion } from "../../../../../components/ha-form/types";
import { hasTemplate } from "../../../../../common/string/has-template";
const OPTIONS = ["count", "while", "until", "for_each"] as const; const OPTIONS = ["count", "while", "until", "for_each"] as const;
@ -31,6 +32,20 @@ export class HaRepeatAction extends LitElement implements ActionElement {
return { repeat: { count: 2, sequence: [] } }; return { repeat: { count: 2, sequence: [] } };
} }
public willUpdate(changedProperties: PropertyValues) {
if (!changedProperties.has("action")) {
return;
}
// Check for templates in action. If found, revert to YAML mode.
if (this.action && hasTemplate(this.action)) {
fireEvent(
this,
"ui-mode-not-available",
Error(this.hass.localize("ui.errors.config.no_template_editor_support"))
);
}
}
private _schema = memoizeOne( private _schema = memoizeOne(
(localize: LocalizeFunc, type: string, reOrderMode: boolean) => (localize: LocalizeFunc, type: string, reOrderMode: boolean) =>
[ [
@ -92,7 +107,7 @@ export class HaRepeatAction extends LitElement implements ActionElement {
this.reOrderMode this.reOrderMode
); );
const data = { ...action, type }; const data = { ...action, type };
return html` <ha-form return html`<ha-form
.hass=${this.hass} .hass=${this.hass}
.data=${data} .data=${data}
.schema=${schema} .schema=${schema}