mirror of https://github.com/home-assistant/core
9fdad592c2
* Make MQTT Alarm Control Panel features conditional The MQTT Alarm Control Panel currently enables all features (arm home, arm away, arm night, arm vacation, arm custom bypass) unconditionally. This clutters the interface and can even be potentially dangerous, by enabling modes that the remote alarm may not support. Make all the features conditional, by adding a new "supported_features" configuration option, comprising a list of the supported features as options. Feature enablement seems inconsistent across the MQTT component; this implementation is most alike to the Humidifier modes option, but using a generic "supported_features" name that other implementations may reuse in the future. The default value of this new setting remains to be all features, which while it may be overly expansive, is necessary to maintain backwards compatibility. * Apply suggestions from code review * Use vol.Optional() instead of vol.Required() for "supported_features". * Move the initialization of _attr_supported_features to _setup_from_config. Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> * Apply suggestions from emontnemery's code review * Use vol.In() instead of cv.multi_seelct() * Remove superfluous _attr_supported_features initializers, already present in the base class. Co-authored-by: Erik Montnemery <erik@montnemery.com> * Add invalid config tests for the MQTT Alarm Control Panel * Set expected_features to None in the invalid MQTT Alarm Control Panel tests * Add another expected_features=None in the invalid tests Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> --------- Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> |
||
|---|---|---|
| .. | ||
| auth | ||
| backports | ||
| brands | ||
| components | ||
| generated | ||
| helpers | ||
| scripts | ||
| util | ||
| __init__.py | ||
| __main__.py | ||
| block_async_io.py | ||
| bootstrap.py | ||
| config.py | ||
| config_entries.py | ||
| const.py | ||
| core.py | ||
| data_entry_flow.py | ||
| exceptions.py | ||
| loader.py | ||
| package_constraints.txt | ||
| requirements.py | ||
| runner.py | ||
| setup.py | ||
| strings.json | ||