github/ha-core
1
Fork 0
mirror of https://github.com/home-assistant/core synced 2024-07-30 21:18:57 +02:00
Code Releases Activity

Update mqtt to use HassJob (#41796)

Browse Source 
Avoids the overhead of checking the callable type at run time
This commit is contained in:
J. Nick Koston 2020-10-14 15:04:48 -05:00 committed by GitHub
parent 4e8012fcea
commit e0df91ef9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
homeassistant/components/mqtt/__init__.py
View File

@ -31,7 +31,7 @@ from homeassistant.const import (
EVENT_HOMEASSISTANT_STOP,
)
from homeassistant.const import CONF_UNIQUE_ID # noqa: F401
from homeassistant.core import CoreState, Event, ServiceCall, callback
from homeassistant.core import CoreState, Event, HassJob, ServiceCall, callback
from homeassistant.exceptions import HomeAssistantError, Unauthorized
from homeassistant.helpers import config_validation as cv, event, template
from homeassistant.helpers.dispatcher import async_dispatcher_connect, dispatcher_send
@ -630,7 +630,7 @@ class Subscription:
topic: str = attr.ib()
matcher: Any = attr.ib()
callback: MessageCallbackType = attr.ib()
job: HassJob = attr.ib()
qos: int = attr.ib(default=0)
encoding: str = attr.ib(default="utf-8")
@ -839,7 +839,7 @@ class MQTT:
raise HomeAssistantError("Topic needs to be a string!")
subscription = Subscription(
topic, _matcher_for_topic(topic), msg_callback, qos, encoding
topic, _matcher_for_topic(topic), HassJob(msg_callback), qos, encoding
)
self.subscriptions.append(subscription)
self._matching_subscriptions.cache_clear()
@ -978,12 +978,12 @@ class MQTT:
msg.payload,
msg.topic,
subscription.encoding,
subscription.callback,
subscription.job,
)
continue
self.hass.async_run_job(
subscription.callback,
self.hass.async_run_hass_job(
subscription.job,
Message(
msg.topic,
payload,
@ -1479,14 +1479,16 @@ async def websocket_subscribe(hass, connection, msg):
def async_subscribe_connection_status(hass, connection_status_callback):
"""Subscribe to MQTT connection changes."""
connection_status_callback_job = HassJob(connection_status_callback)
@callback
def connected():
hass.async_add_job(connection_status_callback, True)
hass.async_add_hass_job(connection_status_callback_job, True)
@callback
def disconnected():
_LOGGER.error("Calling connection_status_callback, False")
hass.async_add_job(connection_status_callback, False)
hass.async_add_hass_job(connection_status_callback_job, False)
subscriptions = {
"connect": async_dispatcher_connect(hass, MQTT_CONNECTED, connected),